ConfigurationTest::testCustomConfig() - Code Metrics - Inspection of "exlude tests from scrutinizer analysis" - povs/ListerBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a65783...53adb5 )

by Povilas

created 2020-01-18 21:34 UTC

ConfigurationTest::testCustomConfig() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	56
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	38
dl	0
loc	56
rs	9.312
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace Povs\ListerBundle\DependencyInjection;

use PHPUnit\Framework\TestCase;
use Povs\ListerBundle\Type\ListType\ArrayListType;
use Povs\ListerBundle\Type\ListType\CsvListType;
use Symfony\Component\Config\Definition\Processor;

/**
 * @author Povilas Margaiatis <[email protected]>
 */
class ConfigurationTest extends TestCase
{
    /**
     * @var Configuration
     */
    private $configuration;

    /**
     * @var Processor
     */
    private $processor;

    public function setUp(): void
    {
        $this->configuration = new Configuration();
        $this->processor = new Processor();
    }

    public function testDefaultConfig(): void
    {
        $defaultConfig = [
            'types' => [
                'list' => ArrayListType::class
            ],
            'list_config' => [
                'identifier' => 'id',
                'alias' => 'l',
                'translate' => false,
                'translation_domain' => null,
                'multi_column_sort' => false,
                'form_configuration' => [],
                'request' => [
                    'page' => 'page',
                    'length' => 'length',
                    'sort' => 'sort',
                    'filter' => null
                ],
                'type_configuration' => []
            ],
        ];

        $config = $this->processor->processConfiguration($this->configuration, []);
        $this->assertEquals($defaultConfig, $config);
    }

    public function testCustomConfig(): void
    {
        $customConfig = [
            'types' => [
                'list' => ArrayListType::class,
                'csv' => CsvListType::class
            ],
            'list_config' => [
                'translate' => true,
                'multi_column_sort' => true,
                'form_configuration' => [
                    'config' => 'value'
                ],
                'request' => [
                    'filter' => 'new_filter'
                ],
                'type_configuration' => [
                    'list' => [
                        'length' => 1000,
                        'limit' => 10000
                    ]
                ]
            ],
        ];

        $expectedConfig = [
            'types' => [
                'list' => ArrayListType::class,
                'csv' => CsvListType::class
            ],
            'list_config' => [
                'identifier' => 'id',
                'alias' => 'l',
                'translate' => true,
                'translation_domain' => null,
                'multi_column_sort' => true,
                'form_configuration' => [
                    'config' => 'value'
                ],
                'request' => [
                    'page' => 'page',
                    'length' => 'length',
                    'sort' => 'sort',
                    'filter' => 'new_filter'
                ],
                'type_configuration' => [
                    'list' => [
                        'length' => 1000,
                        'limit' => 10000
                    ]
                ]
            ],
        ];

        $config = $this->processor->processConfiguration($this->configuration, ['povs_lister' => $customConfig]);
        $this->assertEquals($expectedConfig, $config);
    }
}


1			<?php
2
3			namespace Povs\ListerBundle\DependencyInjection;
4
5			use PHPUnit\Framework\TestCase;
6			use Povs\ListerBundle\Type\ListType\ArrayListType;
7			use Povs\ListerBundle\Type\ListType\CsvListType;
8			use Symfony\Component\Config\Definition\Processor;
9
10			/**
11			* @author Povilas Margaiatis <[email protected]>
12			*/
13			class ConfigurationTest extends TestCase
14			{
15			/**
16			* @var Configuration
17			*/
18			private $configuration;
19
20			/**
21			* @var Processor
22			*/
23			private $processor;
24
25			public function setUp(): void
26			{
27			$this->configuration = new Configuration();
28			$this->processor = new Processor();
29			}
30
31			public function testDefaultConfig(): void
32			{
33			$defaultConfig = [
34			'types' => [
35			'list' => ArrayListType::class
36			],
37			'list_config' => [
38			'identifier' => 'id',
39			'alias' => 'l',
40			'translate' => false,
41			'translation_domain' => null,
42			'multi_column_sort' => false,
43			'form_configuration' => [],
44			'request' => [
45			'page' => 'page',
46			'length' => 'length',
47			'sort' => 'sort',
48			'filter' => null
49			],
50			'type_configuration' => []
51			],
52			];
53
54			$config = $this->processor->processConfiguration($this->configuration, []);
55			$this->assertEquals($defaultConfig, $config);
56			}
57
58			public function testCustomConfig(): void
59			{
60			$customConfig = [
61			'types' => [
62			'list' => ArrayListType::class,
63			'csv' => CsvListType::class
64			],
65			'list_config' => [
66			'translate' => true,
67			'multi_column_sort' => true,
68			'form_configuration' => [
69			'config' => 'value'
70			],
71			'request' => [
72			'filter' => 'new_filter'
73			],
74			'type_configuration' => [
75			'list' => [
76			'length' => 1000,
77			'limit' => 10000
78			]
79			]
80			],
81			];
82
83			$expectedConfig = [
84			'types' => [
85			'list' => ArrayListType::class,
86			'csv' => CsvListType::class
87			],
88			'list_config' => [
89			'identifier' => 'id',
90			'alias' => 'l',
91			'translate' => true,
92			'translation_domain' => null,
93			'multi_column_sort' => true,
94			'form_configuration' => [
95			'config' => 'value'
96			],
97			'request' => [
98			'page' => 'page',
99			'length' => 'length',
100			'sort' => 'sort',
101			'filter' => 'new_filter'
102			],
103			'type_configuration' => [
104			'list' => [
105			'length' => 1000,
106			'limit' => 10000
107			]
108			]
109			],
110			];
111
112			$config = $this->processor->processConfiguration($this->configuration, ['povs_lister' => $customConfig]);
113			$this->assertEquals($expectedConfig, $config);
114			}
115			}
116

povs / ListerBundle

Push — master ( a65783...53adb5 )

ConfigurationTest::testCustomConfig() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like