Povs\ListerBundle\Service\Paginator

Complexity

Total Complexity

6

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getCount()	0	18	3
A	getData()	0	11	2

<?php

namespace Povs\ListerBundle\Service;

use Doctrine\ORM\QueryBuilder;
use Povs\ListerBundle\Exception\ListQueryException;
use Throwable;

/**
 * @author Povilas Margaiatis <p.margaitis@gmail.com>
 */
class Paginator
{
    /**
     * @var QueryBuilder
     */
    private $queryBuilder;

    /**
     * @var string
     */
    private $alias;

    /**
     * @var string
     */
    private $identifier;

    /**
     * @var int|null
     */
    private $count;

    /**
     * ListPaginator constructor.
     *
     * @param QueryBuilder       $queryBuilder
     * @param string             $alias       query base entity alias
     * @param string             $identifier query base entity identifier
     */
    public function __construct(QueryBuilder $queryBuilder, string $alias, string $identifier)
    {
        $this->queryBuilder = $queryBuilder;
        $this->alias = $alias;
        $this->identifier = $identifier;
    }

    /**
     * @return int
     */
    public function getCount(): int
    {
        if (null === $this->count) {
            $queryBuilder = clone $this->queryBuilder;

            try {
                $this->count = $queryBuilder->select(sprintf('COUNT(DISTINCT %s.%s)', $this->alias, $this->identifier))

It seems like $queryBuilder->select(sprintf('COUNT(DISTINCT %s.%s)', $this->alias, $this->identifier))->distinct(false)->resetDQLPart('orderBy')->resetDQLPart('groupBy')->getQuery()->getSingleScalarResult() can also be of type boolean or string. However, the property $count is declared as type integer|null. Maybe add an additional type check?

                    ->distinct(false)
                    ->resetDQLPart('orderBy')
                    ->resetDQLPart('groupBy')
                    ->getQuery()
                    ->getSingleScalarResult();
            } catch (Throwable $e) {
                throw ListQueryException::invalidQueryConfiguration($e->getMessage(), $queryBuilder->getDQL());
            }
        }

        return $this->count;
    }

    /**
     * @param int $offset
     * @param int $length
     *
     * @return array
     */
    public function getData(int $offset, int $length): array
    {
        $queryBuilder = clone $this->queryBuilder;

        try {
            return $queryBuilder->setFirstResult($offset)

The expression return $queryBuilder->setFirstResult($offset)->setMaxResults($length)->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

                ->setMaxResults($length)
                ->getQuery()
                ->getResult();
        } catch (Throwable $e) {
            throw ListQueryException::invalidQueryConfiguration($e->getMessage(), $queryBuilder->getDQL());
        }
    }
}