Command::configure() - Code Metrics - Inspection of "Add compatibility with phpunit/php-timer 2.x" - povils/phpmnd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#66)

by Jonas

created 2018-02-05 13:17 UTC

Command::configure() B

↳ Parent: Command

Complexity

Conditions	1
Paths	1

Size

Total Lines	88
Code Lines	70

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	88
rs	8.6012
cc	1
eloc	70
nc	1
nop	0

How to fix Long Method

<?php

namespace Povils\PHPMND\Console;

use Povils\PHPMND\Detector;
use Povils\PHPMND\ExtensionResolver;
use Povils\PHPMND\FileReportList;
use Povils\PHPMND\HintList;
use Povils\PHPMND\PHPFinder;
use Povils\PHPMND\Printer;
use SebastianBergmann\Timer\Timer;
use Symfony\Component\Console\Command\Command as BaseCommand;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Command
 *
 * @package Povils\PHPMND\Console
 */
class Command extends BaseCommand
{
    const EXIT_CODE_SUCCESS = 0;
    const EXIT_CODE_FAILURE = 1;

    /**
     * @inheritdoc
     */
    protected function configure()
    {
        $this
            ->setName('phpmnd')
            ->setDefinition(
                [
                    new InputArgument(
                        'directory',
                        InputArgument::REQUIRED,
                        'Directory to analyze'
                    )
                ]
            )
            ->addOption(
                'extensions',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of extensions'
            )
            ->addOption(
                'ignore-numbers',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of numbers to ignore',
                '0, 1'
            )
            ->addOption(
                'ignore-funcs',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of functions to ignore when using "argument" extension'
            )
            ->addOption(
                'exclude',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Exclude a directory from code analysis (must be relative to source)'
            )
            ->addOption(
                'exclude-path',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Exclude a path from code analysis (must be relative to source)'
            )
            ->addOption(
                'exclude-file',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Exclude a file from code analysis (must be relative to source)'
            )
            ->addOption(
                'suffixes',
                null,
                InputOption::VALUE_REQUIRED,
                'Comma-separated string of valid source code filename extensions',
                'php'
            )
            ->addOption(
                'progress',
                null,
                InputOption::VALUE_NONE,
                'Show progress bar'
            )
            ->addOption(
                'hint',
                null,
                InputOption::VALUE_NONE,
                'Suggest replacements for magic numbers'
            )
            ->addOption(
                'non-zero-exit-on-violation',
                null,
                InputOption::VALUE_NONE,
                'Return a non zero exit code when there are magic numbers'
            )
            ->addOption(
                'strings',
                null,
                InputOption::VALUE_NONE,
                'Include strings literal search in code analysis'
            )
            ->addOption(
                'ignore-strings',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of strings to ignore when using "strings" option'
            );
    }

    /**
     * @inheritdoc
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $finder = $this->createFinder($input);

        if (0 === $finder->count()) {
            $output->writeln('No files found to scan');
            return self::EXIT_CODE_SUCCESS;
        }

        $progressBar = null;
        if ($input->getOption('progress')) {
            $progressBar = new ProgressBar($output, $finder->count());
            $progressBar->start();
        }

        $hintList = new HintList;
        $detector = new Detector($this->createOption($input), $hintList);

        $fileReportList = new FileReportList();
        $printer = new Printer();
        foreach ($finder as $file) {
            try {
                $fileReport = $detector->detect($file);
                if ($fileReport->hasMagicNumbers()) {
                    $fileReportList->addFileReport($fileReport);
                }
            } catch (\Exception $e) {
                $output->writeln($e->getMessage());
            }

            if ($input->getOption('progress')) {
                $progressBar->advance();
            }
        }

        if ($input->getOption('progress')) {
            $progressBar->finish();
        }

        if ($output->getVerbosity() !== OutputInterface::VERBOSITY_QUIET) {
            $output->writeln('');
            $printer->printData($output, $fileReportList, $hintList);

            $resourceUsage = class_exists(Timer::class)
                ? Timer::resourceUsage()
                : \PHP_Timer::resourceUsage();

            $output->writeln('<info>' . $resourceUsage . '</info>');
        }

        if ($input->getOption('non-zero-exit-on-violation') && $fileReportList->hasMagicNumbers()) {
            return self::EXIT_CODE_FAILURE;
        }
        return self::EXIT_CODE_SUCCESS;
    }

    /**
     * @param InputInterface $input
     * @return Option
     * @throws \Exception
     */
    private function createOption(InputInterface $input)
    {
        $option = new Option;
        $option->setIgnoreNumbers(array_map([$this, 'castToNumber'], $this->getCSVOption($input, 'ignore-numbers')));
        $option->setIgnoreFuncs($this->getCSVOption($input, 'ignore-funcs'));
        $option->setIncludeStrings($input->getOption('strings'));
        $option->setIgnoreStrings($this->getCSVOption($input, 'ignore-strings'));
        $option->setGiveHint($input->getOption('hint'));
        $option->setExtensions(
            (new ExtensionResolver())->resolve($this->getCSVOption($input, 'extensions'))
        );

        return $option;
    }

    /**
     * @param InputInterface $input
     * @param string $option
     *
     * @return array
     */
    private function getCSVOption(InputInterface $input, $option)
    {
        $result = $input->getOption($option);
        if (false === is_array($result)) {
            return array_filter(
                explode(',', $result),
                function ($value) {
                    return false === empty($value);
                }
            );
        }

        if (null === $result) {
            return [];
        }

        return $result;
    }

    /**
     * @param InputInterface $input
     *
     * @return PHPFinder
     */
    protected function createFinder(InputInterface $input)
    {
        return new PHPFinder(
            $input->getArgument('directory'),
            $input->getOption('exclude'),
            $input->getOption('exclude-path'),
            $input->getOption('exclude-file'),
            $this->getCSVOption($input, 'suffixes')
        );
    }

    /**
     * @param string $value
     *
     * @return int|float|string
     */
    private function castToNumber($value)
    {
        if (is_numeric($value)) {
            $value += 0; // '2' -> (int) 2, '2.' -> (float) 2.0
        }

        return $value;
    }
}


1			<?php
2
3			namespace Povils\PHPMND\Console;
4
5			use Povils\PHPMND\Detector;
6			use Povils\PHPMND\ExtensionResolver;
7			use Povils\PHPMND\FileReportList;
8			use Povils\PHPMND\HintList;
9			use Povils\PHPMND\PHPFinder;
10			use Povils\PHPMND\Printer;
11			use SebastianBergmann\Timer\Timer;
12			use Symfony\Component\Console\Command\Command as BaseCommand;
13			use Symfony\Component\Console\Helper\ProgressBar;
14			use Symfony\Component\Console\Input\InputArgument;
15			use Symfony\Component\Console\Input\InputInterface;
16			use Symfony\Component\Console\Input\InputOption;
17			use Symfony\Component\Console\Output\OutputInterface;
18
19			/**
20			* Class Command
21			*
22			* @package Povils\PHPMND\Console
23			*/
24			class Command extends BaseCommand
25			{
26			const EXIT_CODE_SUCCESS = 0;
27			const EXIT_CODE_FAILURE = 1;
28
29			/**
30			* @inheritdoc
31			*/
32			protected function configure()
33			{
34			$this
35			->setName('phpmnd')
36			->setDefinition(
37			[
38			new InputArgument(
39			'directory',
40			InputArgument::REQUIRED,
41			'Directory to analyze'
42			)
43			]
44			)
45			->addOption(
46			'extensions',
47			null,
48			InputOption::VALUE_REQUIRED,
49			'A comma-separated list of extensions'
50			)
51			->addOption(
52			'ignore-numbers',
53			null,
54			InputOption::VALUE_REQUIRED,
55			'A comma-separated list of numbers to ignore',
56			'0, 1'
57			)
58			->addOption(
59			'ignore-funcs',
60			null,
61			InputOption::VALUE_REQUIRED,
62			'A comma-separated list of functions to ignore when using "argument" extension'
63			)
64			->addOption(
65			'exclude',
66			null,
67			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
68			'Exclude a directory from code analysis (must be relative to source)'
69			)
70			->addOption(
71			'exclude-path',
72			null,
73			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
74			'Exclude a path from code analysis (must be relative to source)'
75			)
76			->addOption(
77			'exclude-file',
78			null,
79			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
80			'Exclude a file from code analysis (must be relative to source)'
81			)
82			->addOption(
83			'suffixes',
84			null,
85			InputOption::VALUE_REQUIRED,
86			'Comma-separated string of valid source code filename extensions',
87			'php'
88			)
89			->addOption(
90			'progress',
91			null,
92			InputOption::VALUE_NONE,
93			'Show progress bar'
94			)
95			->addOption(
96			'hint',
97			null,
98			InputOption::VALUE_NONE,
99			'Suggest replacements for magic numbers'
100			)
101			->addOption(
102			'non-zero-exit-on-violation',
103			null,
104			InputOption::VALUE_NONE,
105			'Return a non zero exit code when there are magic numbers'
106			)
107			->addOption(
108			'strings',
109			null,
110			InputOption::VALUE_NONE,
111			'Include strings literal search in code analysis'
112			)
113			->addOption(
114			'ignore-strings',
115			null,
116			InputOption::VALUE_REQUIRED,
117			'A comma-separated list of strings to ignore when using "strings" option'
118			);
119			}
120
121			/**
122			* @inheritdoc
123			*/
124			protected function execute(InputInterface $input, OutputInterface $output)
125			{
126			$finder = $this->createFinder($input);
127
128			if (0 === $finder->count()) {
129			$output->writeln('No files found to scan');
130			return self::EXIT_CODE_SUCCESS;
131			}
132
133			$progressBar = null;
134			if ($input->getOption('progress')) {
135			$progressBar = new ProgressBar($output, $finder->count());
136			$progressBar->start();
137			}
138
139			$hintList = new HintList;
140			$detector = new Detector($this->createOption($input), $hintList);
141
142			$fileReportList = new FileReportList();
143			$printer = new Printer();
144			foreach ($finder as $file) {
145			try {
146			$fileReport = $detector->detect($file);
147			if ($fileReport->hasMagicNumbers()) {
148			$fileReportList->addFileReport($fileReport);
149			}
150			} catch (\Exception $e) {
151			$output->writeln($e->getMessage());
152			}
153
154			if ($input->getOption('progress')) {
155			$progressBar->advance();
156			}
157			}
158
159			if ($input->getOption('progress')) {
160			$progressBar->finish();
161			}
162
163			if ($output->getVerbosity() !== OutputInterface::VERBOSITY_QUIET) {
164			$output->writeln('');
165			$printer->printData($output, $fileReportList, $hintList);
166
167			$resourceUsage = class_exists(Timer::class)
168			? Timer::resourceUsage()
169			: \PHP_Timer::resourceUsage();
170
171			$output->writeln('<info>' . $resourceUsage . '</info>');
172			}
173
174			if ($input->getOption('non-zero-exit-on-violation') && $fileReportList->hasMagicNumbers()) {
175			return self::EXIT_CODE_FAILURE;
176			}
177			return self::EXIT_CODE_SUCCESS;
178			}
179
180			/**
181			* @param InputInterface $input
182			* @return Option
183			* @throws \Exception
184			*/
185			private function createOption(InputInterface $input)
186			{
187			$option = new Option;
188			$option->setIgnoreNumbers(array_map([$this, 'castToNumber'], $this->getCSVOption($input, 'ignore-numbers')));
189			$option->setIgnoreFuncs($this->getCSVOption($input, 'ignore-funcs'));
190			$option->setIncludeStrings($input->getOption('strings'));
191			$option->setIgnoreStrings($this->getCSVOption($input, 'ignore-strings'));
192			$option->setGiveHint($input->getOption('hint'));
193			$option->setExtensions(
194			(new ExtensionResolver())->resolve($this->getCSVOption($input, 'extensions'))
195			);
196
197			return $option;
198			}
199
200			/**
201			* @param InputInterface $input
202			* @param string $option
203			*
204			* @return array
205			*/
206			private function getCSVOption(InputInterface $input, $option)
207			{
208			$result = $input->getOption($option);
209			if (false === is_array($result)) {
210			return array_filter(
211			explode(',', $result),
212			function ($value) {
213			return false === empty($value);
214			}
215			);
216			}
217
218			if (null === $result) {
219			return [];
220			}
221
222			return $result;
223			}
224
225			/**
226			* @param InputInterface $input
227			*
228			* @return PHPFinder
229			*/
230			protected function createFinder(InputInterface $input)
231			{
232			return new PHPFinder(
233			$input->getArgument('directory'),
234			$input->getOption('exclude'),
235			$input->getOption('exclude-path'),
236			$input->getOption('exclude-file'),
237			$this->getCSVOption($input, 'suffixes')
238			);
239			}
240
241			/**
242			* @param string $value
243			*
244			* @return int\|float\|string
245			*/
246			private function castToNumber($value)
247			{
248			if (is_numeric($value)) {
249			$value += 0; // '2' -> (int) 2, '2.' -> (float) 2.0
250			}
251
252			return $value;
253			}
254			}
255

povils / phpmnd

Pull Request — master (#66)

Command::configure() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like