Povils\PHPMND\Visitor\DetectorVisitor

Complexity

Total Complexity

13

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	enterNode()	0	19	7
A	isNumber()	0	4	2
A	ignoreNumber()	0	4	1
A	ignoreFunc()	0	8	2

<?php

namespace Povils\PHPMND\Visitor;

use PhpParser\Node;
use PhpParser\Node\Const_;
use PhpParser\Node\Scalar;
use PhpParser\Node\Scalar\DNumber;
use PhpParser\Node\Scalar\LNumber;
use PhpParser\NodeTraverser;
use PhpParser\NodeVisitorAbstract;
use Povils\PHPMND\Console\Option;
use Povils\PHPMND\Extension\Extension;
use Povils\PHPMND\Extension\FunctionAwareExtension;
use Povils\PHPMND\FileReport;

/**
 * Class DetectorVisitor
 *
 * @package Povils\PHPMND
 */
class DetectorVisitor extends NodeVisitorAbstract
{
    /**
     * @var FileReport
     */
    private $fileReport;

    /**
     * @var Option
     */
    private $option;

    /**
     * @param FileReport $fileReport
     * @param Option $option
     */
    public function __construct(FileReport $fileReport, Option $option)
    {
        $this->fileReport = $fileReport;
        $this->option = $option;
    }

    /**
     * @inheritdoc
     */
    public function enterNode(Node $node)
    {
        if ($node instanceof Const_) {
            return NodeTraverser::DONT_TRAVERSE_CHILDREN;
        }

        /** @var LNumber $node */
        if ($this->isNumber($node) && false === $this->ignoreNumber($node)) {
            foreach ($this->option->getExtensions() as $extension) {
                if ($extension->extend($node) && false == $this->ignoreFunc($node, $extension)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

                    $this->fileReport->addEntry($node->getLine(), $node->value);

                    return null;
                }
            }
        }

        return null;
    }

    /**
     * @param Node $node
     *
     * @return bool
     */
    protected function isNumber(Node $node)
    {
        return $node instanceof LNumber || $node instanceof DNumber;
    }

    /**
     * @param LNumber|DNumber|Scalar $node
     *
     * @return bool
     */
    private function ignoreNumber(Scalar $node)
    {
        return in_array($node->value, $this->option->getIgnoreNumbers(), true);

The property value does not seem to exist in PhpParser\Node\Scalar.

    }

    /**
     * @param Node      $node
     * @param Extension $extension
     *
     * @return bool
     */
    private function ignoreFunc(Node $node, Extension $extension)
    {
        if ($extension instanceof FunctionAwareExtension) {
            return $extension->ignoreFunc($node, $this->option->getIgnoreFuncs());
        }

        return false;
    }
}