Application - Code Metrics - Inspection of "Update namespace to a more neutral PHPMND" - povils/phpmnd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#38)

by Pádraic

created 2017-05-02 22:17 UTC

Application A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

Metric	Value
wmc	9
lcom	0
cbo	6
dl	0
loc	65
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	getCommandName()	4	1
A	getDefaultCommands()	7	1
A	getDefinition()	7	1
B	doRun()	21	5

<?php

namespace PHPMND\Console;

use Symfony\Component\Console\Application as BaseApplication;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Application
 *
 * @package PHPMND\Console
 */
class Application extends BaseApplication
{
    const VERSION = '1.0.3';
    const COMMAND_NAME = 'phpmnd';

    public function __construct()
    {
        parent::__construct('phpmnd', self::VERSION);
    }

    /**
     * @inheritdoc
     */
    protected function getCommandName(InputInterface $input)
    {
        return self::COMMAND_NAME;
    }

    /**
     * @inheritdoc
     */
    protected function getDefaultCommands()
    {
        $defaultCommands = parent::getDefaultCommands();
        $defaultCommands[] = new Command;

        return $defaultCommands;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function getDefinition()
    {
        $inputDefinition = parent::getDefinition();
        $inputDefinition->setArguments();

        return $inputDefinition;
    }

    /**
     * @inheritdoc
     */
    public function doRun(InputInterface $input, OutputInterface $output)
    {
        if (false === $input->hasParameterOption('--quiet')) {
            $output->write(
                sprintf(
                    'phpmnd %s by Povilas Susinskas' . PHP_EOL,
                    $this->getVersion()
                )
            );
        }

        if ($input->hasParameterOption('--version') || $input->hasParameterOption('-V')) {
            exit;
        }

        if (null === $input->getFirstArgument()) {
            $input = new ArrayInput(['--help']);
        }

        parent::doRun($input, $output);
    }
}


1			<?php
2
3			namespace PHPMND\Console;
4
5			use Symfony\Component\Console\Application as BaseApplication;
6			use Symfony\Component\Console\Input\ArrayInput;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9
10			/**
11			* Class Application
12			*
13			* @package PHPMND\Console
14			*/
15			class Application extends BaseApplication
16			{
17			const VERSION = '1.0.3';
18			const COMMAND_NAME = 'phpmnd';
19
20			public function __construct()
21			{
22			parent::__construct('phpmnd', self::VERSION);
23			}
24
25			/**
26			* @inheritdoc
27			*/
28			protected function getCommandName(InputInterface $input)
29			{
30			return self::COMMAND_NAME;
31			}
32
33			/**
34			* @inheritdoc
35			*/
36			protected function getDefaultCommands()
37			{
38			$defaultCommands = parent::getDefaultCommands();
39			$defaultCommands[] = new Command;
40
41			return $defaultCommands;
			0 ignored issues – show Best Practice introduced 2017-05-02 22:20 UTC by Report Bug Copy Issue Report The expression `return $defaultCommands;` seems to be an `array`, but some of its elements' types (`PHPMND\Console\Command`) are incompatible with the return type of the parent method `Symfony\Component\Consol...ion::getDefaultCommands` of type `array<Symfony\Component\...le\Command\ListCommand>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
42			}
43
44			/**
45			* @inheritdoc
46			*/
47			public function getDefinition()
48			{
49			$inputDefinition = parent::getDefinition();
50			$inputDefinition->setArguments();
51
52			return $inputDefinition;
53			}
54
55			/**
56			* @inheritdoc
57			*/
58			public function doRun(InputInterface $input, OutputInterface $output)
59			{
60			if (false === $input->hasParameterOption('--quiet')) {
61			$output->write(
62			sprintf(
63			'phpmnd %s by Povilas Susinskas' . PHP_EOL,
64			$this->getVersion()
65			)
66			);
67			}
68
69			if ($input->hasParameterOption('--version') \|\| $input->hasParameterOption('-V')) {
70			exit;
71			}
72
73			if (null === $input->getFirstArgument()) {
74			$input = new ArrayInput(['--help']);
75			}
76
77			parent::doRun($input, $output);
78			}
79			}
80

povils / phpmnd

Pull Request — master (#38)

Application A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like