Command::configure() - Code Metrics - Inspection of "Merge pull request #70 from MacFJA/add-xml-output" - povils/phpmnd - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 132a7c...1cf077 )

by Povilas

created 2018-03-17 19:08 UTC

Command::configure() B

↳ Parent: Command

Complexity

Conditions	1
Paths	1

Size

Total Lines	101
Code Lines	80

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	101
rs	8.2857
cc	1
eloc	80
nc	1
nop	0

How to fix Long Method

<?php

namespace Povils\PHPMND\Console;

use Povils\PHPMND\Detector;
use Povils\PHPMND\ExtensionResolver;
use Povils\PHPMND\FileReportList;
use Povils\PHPMND\HintList;
use Povils\PHPMND\PHPFinder;
use Povils\PHPMND\Printer;
use SebastianBergmann\Timer\Timer;
use Symfony\Component\Console\Command\Command as BaseCommand;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Command
 *
 * @package Povils\PHPMND\Console
 */
class Command extends BaseCommand
{
    const EXIT_CODE_SUCCESS = 0;
    const EXIT_CODE_FAILURE = 1;

    /**
     * @inheritdoc
     */
    protected function configure()
    {
        $this
            ->setName('phpmnd')
            ->setDefinition(
                [
                    new InputArgument(
                        'directory',
                        InputArgument::REQUIRED,
                        'Directory to analyze'
                    )
                ]
            )
            ->addOption(
                'extensions',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of extensions'
            )
            ->addOption(
                'ignore-numbers',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of numbers to ignore',
                '0, 1'
            )
            ->addOption(
                'ignore-funcs',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of functions to ignore when using "argument" extension'
            )
            ->addOption(
                'exclude',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Exclude a directory from code analysis (must be relative to source)'
            )
            ->addOption(
                'exclude-path',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Exclude a path from code analysis (must be relative to source)'
            )
            ->addOption(
                'exclude-file',
                null,
                InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY,
                'Exclude a file from code analysis (must be relative to source)'
            )
            ->addOption(
                'suffixes',
                null,
                InputOption::VALUE_REQUIRED,
                'Comma-separated string of valid source code filename extensions',
                'php'
            )
            ->addOption(
                'progress',
                null,
                InputOption::VALUE_NONE,
                'Show progress bar'
            )
            ->addOption(
                'hint',
                null,
                InputOption::VALUE_NONE,
                'Suggest replacements for magic numbers'
            )
            ->addOption(
                'non-zero-exit-on-violation',
                null,
                InputOption::VALUE_NONE,
                'Return a non zero exit code when there are magic numbers'
            )
            ->addOption(
                'strings',
                null,
                InputOption::VALUE_NONE,
                'Include strings literal search in code analysis'
            )
            ->addOption(
                'ignore-strings',
                null,
                InputOption::VALUE_REQUIRED,
                'A comma-separated list of strings to ignore when using "strings" option'
            )
            ->addOption(
                'include-numeric-string',
                null,
                InputOption::VALUE_NONE,
                'Include strings which are numeric'
            )
            ->addOption(
                'xml-output',
                null,
                InputOption::VALUE_REQUIRED,
                'Generate an XML output to the specified path'
            )
        ;
    }

    /**
     * @inheritdoc
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $finder = $this->createFinder($input);

        if (0 === $finder->count()) {
            $output->writeln('No files found to scan');
            return self::EXIT_CODE_SUCCESS;
        }

        $progressBar = null;
        if ($input->getOption('progress')) {
            $progressBar = new ProgressBar($output, $finder->count());
            $progressBar->start();
        }

        $hintList = new HintList;
        $detector = new Detector($this->createOption($input), $hintList);

        $fileReportList = new FileReportList();
        $printer = new Printer\Console();
        foreach ($finder as $file) {
            try {
                $fileReport = $detector->detect($file);
                if ($fileReport->hasMagicNumbers()) {
                    $fileReportList->addFileReport($fileReport);
                }
            } catch (\Exception $e) {
                $output->writeln($e->getMessage());
            }

            if ($input->getOption('progress')) {
                $progressBar->advance();
            }
        }

        if ($input->getOption('progress')) {
            $progressBar->finish();
        }

        if ($input->getOption('xml-output')) {
            $xmlOutput = new Printer\Xml($input->getOption('xml-output'));
            $xmlOutput->printData($output, $fileReportList, $hintList);
        }

        if ($output->getVerbosity() !== OutputInterface::VERBOSITY_QUIET) {
            $output->writeln('');
            $printer->printData($output, $fileReportList, $hintList);
            $output->writeln('<info>' . Timer::resourceUsage() . '</info>');
        }

        if ($input->getOption('non-zero-exit-on-violation') && $fileReportList->hasMagicNumbers()) {
            return self::EXIT_CODE_FAILURE;
        }
        return self::EXIT_CODE_SUCCESS;
    }

    /**
     * @param InputInterface $input
     * @return Option
     * @throws \Exception
     */
    private function createOption(InputInterface $input)
    {
        $option = new Option;
        $option->setIgnoreNumbers(array_map([$this, 'castToNumber'], $this->getCSVOption($input, 'ignore-numbers')));
        $option->setIgnoreFuncs($this->getCSVOption($input, 'ignore-funcs'));
        $option->setIncludeStrings($input->getOption('strings'));
        $option->setIncludeNumericStrings($input->getOption('include-numeric-string'));
        $option->setIgnoreStrings($this->getCSVOption($input, 'ignore-strings'));
        $option->setGiveHint($input->getOption('hint'));
        $option->setExtensions(
            (new ExtensionResolver())->resolve($this->getCSVOption($input, 'extensions'))
        );

        return $option;
    }

    /**
     * @param InputInterface $input
     * @param string $option
     *
     * @return array
     */
    private function getCSVOption(InputInterface $input, $option)
    {
        $result = $input->getOption($option);
        if (false === is_array($result)) {
            return array_filter(
                explode(',', $result),
                function ($value) {
                    return false === empty($value);
                }
            );
        }

        if (null === $result) {
            return [];
        }

        return $result;
    }

    /**
     * @param InputInterface $input
     *
     * @return PHPFinder
     */
    protected function createFinder(InputInterface $input)
    {
        return new PHPFinder(
            $input->getArgument('directory'),
            $input->getOption('exclude'),
            $input->getOption('exclude-path'),
            $input->getOption('exclude-file'),
            $this->getCSVOption($input, 'suffixes')
        );
    }

    /**
     * @param string $value
     *
     * @return int|float|string
     */
    private function castToNumber($value)
    {
        if (is_numeric($value)) {
            $value += 0; // '2' -> (int) 2, '2.' -> (float) 2.0
        }

        return $value;
    }
}


1			<?php
2
3			namespace Povils\PHPMND\Console;
4
5			use Povils\PHPMND\Detector;
6			use Povils\PHPMND\ExtensionResolver;
7			use Povils\PHPMND\FileReportList;
8			use Povils\PHPMND\HintList;
9			use Povils\PHPMND\PHPFinder;
10			use Povils\PHPMND\Printer;
11			use SebastianBergmann\Timer\Timer;
12			use Symfony\Component\Console\Command\Command as BaseCommand;
13			use Symfony\Component\Console\Helper\ProgressBar;
14			use Symfony\Component\Console\Input\InputArgument;
15			use Symfony\Component\Console\Input\InputInterface;
16			use Symfony\Component\Console\Input\InputOption;
17			use Symfony\Component\Console\Output\OutputInterface;
18
19			/**
20			* Class Command
21			*
22			* @package Povils\PHPMND\Console
23			*/
24			class Command extends BaseCommand
25			{
26			const EXIT_CODE_SUCCESS = 0;
27			const EXIT_CODE_FAILURE = 1;
28
29			/**
30			* @inheritdoc
31			*/
32			protected function configure()
33			{
34			$this
35			->setName('phpmnd')
36			->setDefinition(
37			[
38			new InputArgument(
39			'directory',
40			InputArgument::REQUIRED,
41			'Directory to analyze'
42			)
43			]
44			)
45			->addOption(
46			'extensions',
47			null,
48			InputOption::VALUE_REQUIRED,
49			'A comma-separated list of extensions'
50			)
51			->addOption(
52			'ignore-numbers',
53			null,
54			InputOption::VALUE_REQUIRED,
55			'A comma-separated list of numbers to ignore',
56			'0, 1'
57			)
58			->addOption(
59			'ignore-funcs',
60			null,
61			InputOption::VALUE_REQUIRED,
62			'A comma-separated list of functions to ignore when using "argument" extension'
63			)
64			->addOption(
65			'exclude',
66			null,
67			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
68			'Exclude a directory from code analysis (must be relative to source)'
69			)
70			->addOption(
71			'exclude-path',
72			null,
73			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
74			'Exclude a path from code analysis (must be relative to source)'
75			)
76			->addOption(
77			'exclude-file',
78			null,
79			InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY,
80			'Exclude a file from code analysis (must be relative to source)'
81			)
82			->addOption(
83			'suffixes',
84			null,
85			InputOption::VALUE_REQUIRED,
86			'Comma-separated string of valid source code filename extensions',
87			'php'
88			)
89			->addOption(
90			'progress',
91			null,
92			InputOption::VALUE_NONE,
93			'Show progress bar'
94			)
95			->addOption(
96			'hint',
97			null,
98			InputOption::VALUE_NONE,
99			'Suggest replacements for magic numbers'
100			)
101			->addOption(
102			'non-zero-exit-on-violation',
103			null,
104			InputOption::VALUE_NONE,
105			'Return a non zero exit code when there are magic numbers'
106			)
107			->addOption(
108			'strings',
109			null,
110			InputOption::VALUE_NONE,
111			'Include strings literal search in code analysis'
112			)
113			->addOption(
114			'ignore-strings',
115			null,
116			InputOption::VALUE_REQUIRED,
117			'A comma-separated list of strings to ignore when using "strings" option'
118			)
119			->addOption(
120			'include-numeric-string',
121			null,
122			InputOption::VALUE_NONE,
123			'Include strings which are numeric'
124			)
125			->addOption(
126			'xml-output',
127			null,
128			InputOption::VALUE_REQUIRED,
129			'Generate an XML output to the specified path'
130			)
131			;
132			}
133
134			/**
135			* @inheritdoc
136			*/
137			protected function execute(InputInterface $input, OutputInterface $output)
138			{
139			$finder = $this->createFinder($input);
140
141			if (0 === $finder->count()) {
142			$output->writeln('No files found to scan');
143			return self::EXIT_CODE_SUCCESS;
144			}
145
146			$progressBar = null;
147			if ($input->getOption('progress')) {
148			$progressBar = new ProgressBar($output, $finder->count());
149			$progressBar->start();
150			}
151
152			$hintList = new HintList;
153			$detector = new Detector($this->createOption($input), $hintList);
154
155			$fileReportList = new FileReportList();
156			$printer = new Printer\Console();
157			foreach ($finder as $file) {
158			try {
159			$fileReport = $detector->detect($file);
160			if ($fileReport->hasMagicNumbers()) {
161			$fileReportList->addFileReport($fileReport);
162			}
163			} catch (\Exception $e) {
164			$output->writeln($e->getMessage());
165			}
166
167			if ($input->getOption('progress')) {
168			$progressBar->advance();
169			}
170			}
171
172			if ($input->getOption('progress')) {
173			$progressBar->finish();
174			}
175
176			if ($input->getOption('xml-output')) {
177			$xmlOutput = new Printer\Xml($input->getOption('xml-output'));
178			$xmlOutput->printData($output, $fileReportList, $hintList);
179			}
180
181			if ($output->getVerbosity() !== OutputInterface::VERBOSITY_QUIET) {
182			$output->writeln('');
183			$printer->printData($output, $fileReportList, $hintList);
184			$output->writeln('<info>' . Timer::resourceUsage() . '</info>');
185			}
186
187			if ($input->getOption('non-zero-exit-on-violation') && $fileReportList->hasMagicNumbers()) {
188			return self::EXIT_CODE_FAILURE;
189			}
190			return self::EXIT_CODE_SUCCESS;
191			}
192
193			/**
194			* @param InputInterface $input
195			* @return Option
196			* @throws \Exception
197			*/
198			private function createOption(InputInterface $input)
199			{
200			$option = new Option;
201			$option->setIgnoreNumbers(array_map([$this, 'castToNumber'], $this->getCSVOption($input, 'ignore-numbers')));
202			$option->setIgnoreFuncs($this->getCSVOption($input, 'ignore-funcs'));
203			$option->setIncludeStrings($input->getOption('strings'));
204			$option->setIncludeNumericStrings($input->getOption('include-numeric-string'));
205			$option->setIgnoreStrings($this->getCSVOption($input, 'ignore-strings'));
206			$option->setGiveHint($input->getOption('hint'));
207			$option->setExtensions(
208			(new ExtensionResolver())->resolve($this->getCSVOption($input, 'extensions'))
209			);
210
211			return $option;
212			}
213
214			/**
215			* @param InputInterface $input
216			* @param string $option
217			*
218			* @return array
219			*/
220			private function getCSVOption(InputInterface $input, $option)
221			{
222			$result = $input->getOption($option);
223			if (false === is_array($result)) {
224			return array_filter(
225			explode(',', $result),
226			function ($value) {
227			return false === empty($value);
228			}
229			);
230			}
231
232			if (null === $result) {
233			return [];
234			}
235
236			return $result;
237			}
238
239			/**
240			* @param InputInterface $input
241			*
242			* @return PHPFinder
243			*/
244			protected function createFinder(InputInterface $input)
245			{
246			return new PHPFinder(
247			$input->getArgument('directory'),
248			$input->getOption('exclude'),
249			$input->getOption('exclude-path'),
250			$input->getOption('exclude-file'),
251			$this->getCSVOption($input, 'suffixes')
252			);
253			}
254
255			/**
256			* @param string $value
257			*
258			* @return int\|float\|string
259			*/
260			private function castToNumber($value)
261			{
262			if (is_numeric($value)) {
263			$value += 0; // '2' -> (int) 2, '2.' -> (float) 2.0
264			}
265
266			return $value;
267			}
268			}
269

povils / phpmnd

Push — master ( 132a7c...1cf077 )

Command::configure() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like