potievdev / slim-rbac

src/Component/Config/RbacConfigLoader.php

<?php

namespace Potievdev\SlimRbac\Component\Config;

use Potievdev\SlimRbac\Exception\ConfigNotFoundException;
use Symfony\Component\Config\Definition\Processor;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Yaml\Yaml;

class RbacConfigLoader
{
    /**
     * @throws ConfigNotFoundException
     */
    public static function loadConfigs(): array
    {
        $configDirectories = [
            __DIR__ . '/../../../config',
            __DIR__ . '/../../../../../',
            __DIR__ . '/../../../../../config',
        ];

        $fileLocator = new FileLocator($configDirectories);
        $fileName = $fileLocator->locate('sr_config.yaml');

        if ($fileName === null) {

The condition $fileName === null is always false.

            throw ConfigNotFoundException::configFileNotFound($configDirectories);
        }

        return (new Processor())
            ->processConfiguration(new RbacConfigStructure(), Yaml::parseFile($fileName));

It seems like $fileName can also be of type string[]; however, parameter $filename of Symfony\Component\Yaml\Yaml::parseFile() does only seem to accept string, maybe add an additional type check?

    }

}