Issues in Url.php - All Issues - Inspection of "Added test getClient" - postpayio/postpay-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 421969...277b3a )

by Dani

created 2019-11-07 05:00 UTC

src/Http/Url.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Postpay\Http;

class Url
{
    /**
     * Appends params to the URL.
     *
     * @param string $path   The URL path that will receive the params.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array  $params The params to append to the URL.
     *
     * @return string
     */
    public static function addParamsToUrl($url, array $params = [])
    {
        if (empty($params)) {
            return $url;
        }
        return $url . '?' . http_build_query($params, null, '&');
    }

    /**
     * Check for a "/" prefix and prepend it if not exists.
     *
     * @param string|null $string
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return string|null
     */
    public static function slashPrefix($path)
    {
        return strpos($path, '/') === 0 ? $path : '/' . $path;
    }
}


1			<?php
2
3			namespace Postpay\Http;
4
5			class Url
6			{
7			/**
8			* Appends params to the URL.
9			*
10			* @param string $path The URL path that will receive the params.
			0 ignored issues – show Bug introduced 2019-11-07 04:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$path`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
11			* @param array $params The params to append to the URL.
12			*
13			* @return string
14			*/
15			public static function addParamsToUrl($url, array $params = [])
16			{
17			if (empty($params)) {
18			return $url;
19			}
20			return $url . '?' . http_build_query($params, null, '&');
21			}
22
23			/**
24			* Check for a "/" prefix and prepend it if not exists.
25			*
26			* @param string\|null $string
			0 ignored issues – show Bug introduced 2019-11-07 04:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$string`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
27			*
28			* @return string\|null
29			*/
30			public static function slashPrefix($path)
31			{
32			return strpos($path, '/') === 0 ? $path : '/' . $path;
33			}
34			}
35

postpayio / postpay-php

Push — master ( 421969...277b3a )

src/Http/Url.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like