Issues in PostpayTest.php - New Issues - Inspection of "Added tests" - postpayio/postpay-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5319ee...e6b641 )

by Dani

created 2019-11-09 18:22 UTC

tests/PostpayTest.php (1 issue)

Labels

Documentation 1

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Postpay\Tests;

use InvalidArgumentException;
use PHPUnit\Framework\TestCase;
use Postpay\Exceptions\PostpayException;
use Postpay\Http\Request;
use Postpay\Http\Response;
use Postpay\HttpClients\Client;
use Postpay\HttpClients\ClientInterface;
use Postpay\HttpClients\CurlClient;
use Postpay\HttpClients\GuzzleClient;
use Postpay\Postpay;

class PostpayTest extends TestCase
{
    protected $config = [
        'merchant_id' => 'id',
        'secret_key' => 'sk',
    ];

    public function setUp()
    {
        $clientHandler = $this->createMock(ClientInterface::class);
        $clientHandler->method('send')->willReturnCallback(
            function (Request $request) {
                return new Response($request);
            }
        );
        $this->postpay = new Postpay($this->config);
        $this->postpay->setClientHandler($clientHandler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testCredentialsRequired()
    {
        $this->expectException(PostpayException::class);
        new Postpay();
    }

    public function testGetClient()
    {
        self::assertInstanceOf(Client::class, $this->postpay->getClient());
    }

    public function testCreateClientHandler()
    {
        $clientHandler = $this->postpay::CreateClientHandler('curl');
        self::assertInstanceOf(CurlClient::class, $clientHandler);

        $clientHandler = $this->postpay::CreateClientHandler('guzzle');
        self::assertInstanceOf(GuzzleClient::class, $clientHandler);

        $this->expectException(InvalidArgumentException::class);
        $this->postpay::CreateClientHandler('invalid');
    }

    public function testGetLastResponse()
    {
        $response = $this->postpay->get('/');
        self::assertEquals($response, $this->postpay->getLastResponse());
    }

    public function testGet()
    {
        $response = $this->postpay->get('/');
        self::assertEquals('GET', $response->getRequest()->getMethod());
    }

    public function testPost()
    {
        $response = $this->postpay->post('/');
        self::assertEquals('POST', $response->getRequest()->getMethod());
    }

    public function testPut()
    {
        $response = $this->postpay->put('/');
        self::assertEquals('PUT', $response->getRequest()->getMethod());
    }

    public function testPatch()
    {
        $response = $this->postpay->patch('/');
        self::assertEquals('PATCH', $response->getRequest()->getMethod());
    }

    public function testDelete()
    {
        $response = $this->postpay->delete('/');
        self::assertEquals('DELETE', $response->getRequest()->getMethod());
    }

    public function testQuery()
    {
        $response = $this->postpay->query('{}');
        self::assertEquals('POST', $response->getRequest()->getMethod());
    }
}


1			<?php
2
3			namespace Postpay\Tests;
4
5			use InvalidArgumentException;
6			use PHPUnit\Framework\TestCase;
7			use Postpay\Exceptions\PostpayException;
8			use Postpay\Http\Request;
9			use Postpay\Http\Response;
10			use Postpay\HttpClients\Client;
11			use Postpay\HttpClients\ClientInterface;
12			use Postpay\HttpClients\CurlClient;
13			use Postpay\HttpClients\GuzzleClient;
14			use Postpay\Postpay;
15
16			class PostpayTest extends TestCase
17			{
18			protected $config = [
19			'merchant_id' => 'id',
20			'secret_key' => 'sk',
21			];
22
23			public function setUp()
24			{
25			$clientHandler = $this->createMock(ClientInterface::class);
26			$clientHandler->method('send')->willReturnCallback(
27			function (Request $request) {
28			return new Response($request);
29			}
30			);
31			$this->postpay = new Postpay($this->config);
32			$this->postpay->setClientHandler($clientHandler);
			1 ignored issue – show Documentation introduced 2019-11-09 18:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$clientHandler` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Postpay\HttpClients\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			}
34
35			public function testCredentialsRequired()
36			{
37			$this->expectException(PostpayException::class);
38			new Postpay();
39			}
40
41			public function testGetClient()
42			{
43			self::assertInstanceOf(Client::class, $this->postpay->getClient());
44			}
45
46			public function testCreateClientHandler()
47			{
48			$clientHandler = $this->postpay::CreateClientHandler('curl');
49			self::assertInstanceOf(CurlClient::class, $clientHandler);
50
51			$clientHandler = $this->postpay::CreateClientHandler('guzzle');
52			self::assertInstanceOf(GuzzleClient::class, $clientHandler);
53
54			$this->expectException(InvalidArgumentException::class);
55			$this->postpay::CreateClientHandler('invalid');
56			}
57
58			public function testGetLastResponse()
59			{
60			$response = $this->postpay->get('/');
61			self::assertEquals($response, $this->postpay->getLastResponse());
62			}
63
64			public function testGet()
65			{
66			$response = $this->postpay->get('/');
67			self::assertEquals('GET', $response->getRequest()->getMethod());
68			}
69
70			public function testPost()
71			{
72			$response = $this->postpay->post('/');
73			self::assertEquals('POST', $response->getRequest()->getMethod());
74			}
75
76			public function testPut()
77			{
78			$response = $this->postpay->put('/');
79			self::assertEquals('PUT', $response->getRequest()->getMethod());
80			}
81
82			public function testPatch()
83			{
84			$response = $this->postpay->patch('/');
85			self::assertEquals('PATCH', $response->getRequest()->getMethod());
86			}
87
88			public function testDelete()
89			{
90			$response = $this->postpay->delete('/');
91			self::assertEquals('DELETE', $response->getRequest()->getMethod());
92			}
93
94			public function testQuery()
95			{
96			$response = $this->postpay->query('{}');
97			self::assertEquals('POST', $response->getRequest()->getMethod());
98			}
99			}
100

postpayio / postpay-php

Push — master ( 5319ee...e6b641 )

tests/PostpayTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like