Issues in ClientTest.php - New Issues - Inspection of "Added tests" - postpayio/postpay-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5319ee...e6b641 )

by Dani

created 2019-11-09 18:22 UTC

tests/HttpClients/ClientTest.php (2 issues)

Showing only issues like (Show All)

mismatching argument types.

Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Postpay\Tests\HttpClients;

use PHPUnit\Framework\TestCase;
use Postpay\Exceptions\RESTfulException;
use Postpay\Http\Request;
use Postpay\Http\Response;
use Postpay\HttpClients\Client;
use Postpay\HttpClients\ClientInterface;
use Postpay\HttpClients\GuzzleClient;

class ClientTest extends TestCase
{
    public function testGetClientHandler()
    {
        $client = new Client();

        self::assertInstanceOf(
            ClientInterface::class,
            $client->getClientHandler()
        );
    }

    public function testSetClientHandler()
    {
        $client = new Client();
        $clientHandler = new GuzzleClient();
        $client->setClientHandler($clientHandler);

        self::assertEquals($clientHandler, $client->getClientHandler());
    }

    public function testRequest()
    {
        $clientHandler = $this->createMock(ClientInterface::class);

        $clientHandler->method('send')->willReturnCallback(
            function (Request $request) {
                return new Response($request, 200);
            }
        );
        $client = new Client($clientHandler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $response = $client->request(new Request('GET'));
        self::assertSame(200, $response->getStatusCode());
    }

    public function testRequestError()
    {
        $clientHandler = $this->createMock(ClientInterface::class);

        $clientHandler->method('send')->willReturnCallback(
            function (Request $request) {
                $body = json_encode([RESTfulException::ERROR_KEY => true]);
                return new Response($request, 400, [], $body);
            }
        );
        $client = new Client($clientHandler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->expectException(RESTfulException::class);
        $client->request(new Request('GET'));
    }
}


1			<?php
2
3			namespace Postpay\Tests\HttpClients;
4
5			use PHPUnit\Framework\TestCase;
6			use Postpay\Exceptions\RESTfulException;
7			use Postpay\Http\Request;
8			use Postpay\Http\Response;
9			use Postpay\HttpClients\Client;
10			use Postpay\HttpClients\ClientInterface;
11			use Postpay\HttpClients\GuzzleClient;
12
13			class ClientTest extends TestCase
14			{
15			public function testGetClientHandler()
16			{
17			$client = new Client();
18
19			self::assertInstanceOf(
20			ClientInterface::class,
21			$client->getClientHandler()
22			);
23			}
24
25			public function testSetClientHandler()
26			{
27			$client = new Client();
28			$clientHandler = new GuzzleClient();
29			$client->setClientHandler($clientHandler);
30
31			self::assertEquals($clientHandler, $client->getClientHandler());
32			}
33
34			public function testRequest()
35			{
36			$clientHandler = $this->createMock(ClientInterface::class);
37
38			$clientHandler->method('send')->willReturnCallback(
39			function (Request $request) {
40			return new Response($request, 200);
41			}
42			);
43			$client = new Client($clientHandler);
			1 ignored issue – show Documentation introduced 2019-11-09 18:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$clientHandler` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Postpay\HttpClients\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44
45			$response = $client->request(new Request('GET'));
46			self::assertSame(200, $response->getStatusCode());
47			}
48
49			public function testRequestError()
50			{
51			$clientHandler = $this->createMock(ClientInterface::class);
52
53			$clientHandler->method('send')->willReturnCallback(
54			function (Request $request) {
55			$body = json_encode([RESTfulException::ERROR_KEY => true]);
56			return new Response($request, 400, [], $body);
57			}
58			);
59			$client = new Client($clientHandler);
			1 ignored issue – show Documentation introduced 2019-11-09 18:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$clientHandler` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Postpay\HttpClients\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60
61			$this->expectException(RESTfulException::class);
62			$client->request(new Request('GET'));
63			}
64			}
65

postpayio / postpay-php

Push — master ( 5319ee...e6b641 )

tests/HttpClients/ClientTest.php (2 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like