Complex classes like DoctrineExtension often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DoctrineExtension, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 55 | class DoctrineExtension extends CompilerExtension |
||
| 56 | { |
||
| 57 | /** |
||
| 58 | * @var string |
||
| 59 | */ |
||
| 60 | private const DOCTRINE_SQL_PANEL = DoctrineSQLPanel::class; |
||
| 61 | |||
| 62 | private $classMappings = []; |
||
| 63 | |||
| 64 | private $entitySources = []; |
||
| 65 | |||
| 66 | /** |
||
| 67 | * @var array |
||
| 68 | */ |
||
| 69 | private static $defaults = [ |
||
| 70 | 'debug' => '%debugMode%', |
||
| 71 | 'dbal' => [ |
||
| 72 | 'type_overrides' => [], |
||
| 73 | 'types' => [], |
||
| 74 | 'schema_filter' => NULL, |
||
| 75 | ], |
||
| 76 | 'prefix' => 'doctrine.default', |
||
| 77 | 'proxyDir' => '%tempDir%/cache/proxies', |
||
| 78 | 'sourceDir' => NULL, |
||
| 79 | 'entityManagerClassName' => EntityManager::class, |
||
| 80 | 'defaultRepositoryClassName' => EntityRepository::class, |
||
| 81 | 'repositoryFactory' => NULL, |
||
| 82 | 'namingStrategy' => UnderscoreNamingStrategy::class, |
||
| 83 | 'sqlLogger' => NULL, |
||
| 84 | 'targetEntityMappings' => [], |
||
| 85 | 'metadata' => [], |
||
| 86 | 'functions' => [], |
||
| 87 | // caches |
||
| 88 | 'metadataCache' => 'default', |
||
| 89 | 'queryCache' => 'default', |
||
| 90 | 'resultCache' => 'default', |
||
| 91 | 'hydrationCache' => 'default', |
||
| 92 | 'secondLevelCache' => [ |
||
| 93 | 'enabled' => FALSE, |
||
| 94 | 'factoryClass' => DefaultCacheFactory::class, |
||
| 95 | 'driver' => 'default', |
||
| 96 | 'regions' => [ |
||
| 97 | 'defaultLifetime' => 3600, |
||
| 98 | 'defaultLockLifetime' => 60, |
||
| 99 | ], |
||
| 100 | 'fileLockRegionDirectory' => '%tempDir%/cache/Doctrine.Cache.Locks', |
||
| 101 | 'logging' => '%debugMode%', |
||
| 102 | ], |
||
| 103 | 'cache' => [ |
||
| 104 | 'redis' => [ |
||
| 105 | 'class' => RedisCache::class, |
||
| 106 | ], |
||
| 107 | ], |
||
| 108 | ]; |
||
| 109 | |||
| 110 | /** |
||
| 111 | * {@inheritdoc} |
||
| 112 | */ |
||
| 113 | 1 | public function loadConfiguration(): void |
|
| 114 | { |
||
| 115 | 1 | $config = $this->parseConfig(); |
|
| 116 | |||
| 117 | 1 | $builder = $this->getContainerBuilder(); |
|
| 118 | 1 | $name = $config['prefix']; |
|
| 119 | |||
| 120 | 1 | $configurationDefinition = $builder->addDefinition($name . '.config') |
|
| 121 | 1 | ->setType(Configuration::class) |
|
| 122 | 1 | ->addSetup('setFilterSchemaAssetsExpression', [$config['dbal']['schema_filter']]) |
|
| 123 | 1 | ->addSetup('setDefaultRepositoryClassName', [$config['defaultRepositoryClassName']]); |
|
| 124 | |||
| 125 | 1 | if ($config['repositoryFactory']) { |
|
| 126 | $builder->addDefinition($name . '.repositoryFactory') |
||
| 127 | ->setType($config['repositoryFactory']); |
||
| 128 | $configurationDefinition->addSetup('setRepositoryFactory', ['@' . $name . '.repositoryFactory']); |
||
| 129 | } |
||
| 130 | 1 | if ($config['sqlLogger']) { |
|
| 131 | $builder->addDefinition($name . '.sqlLogger') |
||
| 132 | ->setType($config['sqlLogger']); |
||
| 133 | $configurationDefinition->addSetup('setSQLLogger', ['@' . $name . '.sqlLogger']); |
||
| 134 | } |
||
| 135 | |||
| 136 | 1 | if ($config['metadataCache'] !== FALSE) { |
|
| 137 | 1 | $configurationDefinition->addSetup( |
|
| 138 | 1 | 'setMetadataCacheImpl', |
|
| 139 | 1 | [$this->getCache($name . '.metadata', $builder, $config['metadataCache'])] |
|
| 140 | ); |
||
| 141 | } |
||
| 142 | |||
| 143 | 1 | if ($config['queryCache'] !== FALSE) { |
|
| 144 | 1 | $configurationDefinition->addSetup( |
|
| 145 | 1 | 'setQueryCacheImpl', |
|
| 146 | 1 | [$this->getCache($name . '.query', $builder, $config['queryCache'])] |
|
| 147 | ); |
||
| 148 | } |
||
| 149 | |||
| 150 | 1 | if ($config['resultCache'] !== FALSE) { |
|
| 151 | 1 | $configurationDefinition->addSetup( |
|
| 152 | 1 | 'setResultCacheImpl', |
|
| 153 | 1 | [$this->getCache($name . '.ormResult', $builder, $config['resultCache'])] |
|
| 154 | ); |
||
| 155 | } |
||
| 156 | |||
| 157 | 1 | if ($config['hydrationCache'] !== FALSE) { |
|
| 158 | 1 | $configurationDefinition->addSetup( |
|
| 159 | 1 | 'setHydrationCacheImpl', |
|
| 160 | 1 | [$this->getCache($name . '.hydration', $builder, $config['hydrationCache'])] |
|
| 161 | ); |
||
| 162 | } |
||
| 163 | |||
| 164 | 1 | $this->processSecondLevelCache($name, $config['secondLevelCache']); |
|
| 165 | |||
| 166 | 1 | $builder->addDefinition($name . '.connection') |
|
| 167 | 1 | ->setType(Connection::class) |
|
| 168 | 1 | ->setFactory('@' . $name . '.entityManager::getConnection'); |
|
| 169 | |||
| 170 | 1 | $builder->addDefinition($name . '.entityManager') |
|
| 171 | 1 | ->setType($config['entityManagerClassName']) |
|
| 172 | 1 | ->setFactory( |
|
| 173 | 1 | $config['entityManagerClassName'] . '::create', |
|
| 174 | 1 | [$config['connection'], '@' . $name . '.config', '@Doctrine\Common\EventManager'] |
|
| 175 | ); |
||
| 176 | |||
| 177 | 1 | $builder->addDefinition($name . '.namingStrategy') |
|
| 178 | 1 | ->setType($config['namingStrategy']); |
|
| 179 | |||
| 180 | 1 | $builder->addDefinition($name . '.resolver') |
|
| 181 | 1 | ->setType(ResolveTargetEntityListener::class); |
|
| 182 | |||
| 183 | 1 | if ($this->hasIBarPanelInterface()) { |
|
| 184 | 1 | $builder->addDefinition($this->prefix($name . '.diagnosticsPanel')) |
|
| 185 | 1 | ->setType(self::DOCTRINE_SQL_PANEL); |
|
| 186 | } |
||
| 187 | |||
| 188 | // import Doctrine commands into Symfony/Console if exists |
||
| 189 | 1 | $this->registerCommandsIntoConsole($builder, $name); |
|
| 190 | 1 | } |
|
| 191 | |||
| 192 | /** |
||
| 193 | * {@inheritdoc} |
||
| 194 | */ |
||
| 195 | 1 | public function beforeCompile(): void |
|
| 196 | { |
||
| 197 | 1 | $config = $this->getConfig(self::$defaults); |
|
| 198 | 1 | $name = $config['prefix']; |
|
| 199 | |||
| 200 | 1 | $builder = $this->getContainerBuilder(); |
|
| 201 | |||
| 202 | 1 | $configDefinition = $builder->getDefinition($name . '.config') |
|
| 203 | 1 | ->setFactory( |
|
| 204 | 1 | '\Doctrine\ORM\Tools\Setup::createAnnotationMetadataConfiguration', |
|
| 205 | 1 | [array_values($this->entitySources), $config['debug'], $config['proxyDir'], NULL, FALSE] |
|
| 206 | ) |
||
| 207 | 1 | ->addSetup('setNamingStrategy', ['@' . $name . '.namingStrategy']); |
|
| 208 | |||
| 209 | 1 | foreach ($config['functions'] as $functionName => $function) { |
|
| 210 | 1 | $configDefinition->addSetup('addCustomStringFunction', [$functionName, $function]); |
|
| 211 | } |
||
| 212 | |||
| 213 | 1 | foreach ($this->classMappings as $source => $target) { |
|
| 214 | $builder->getDefinition($name . '.resolver') |
||
| 215 | ->addSetup('addResolveTargetEntity', [$source, $target, []]); |
||
| 216 | } |
||
| 217 | |||
| 218 | 1 | $this->processDbalTypes($name, $config['dbal']['types']); |
|
| 219 | 1 | $this->processDbalTypeOverrides($name, $config['dbal']['type_overrides']); |
|
| 220 | 1 | $this->processEventSubscribers($name); |
|
| 221 | 1 | $this->processFilters(); |
|
| 222 | 1 | } |
|
| 223 | |||
| 224 | /** |
||
| 225 | * {@inheritdoc} |
||
| 226 | */ |
||
| 227 | 1 | public function afterCompile(ClassType $classType): void |
|
| 228 | { |
||
| 229 | 1 | $initialize = $classType->methods['initialize']; |
|
| 230 | 1 | if ($this->hasIBarPanelInterface()) { |
|
| 231 | 1 | $initialize->addBody('$this->getByType(\'' . self::DOCTRINE_SQL_PANEL . '\')->bindToBar();'); |
|
| 232 | } |
||
| 233 | |||
| 234 | 1 | $initialize->addBody( |
|
| 235 | 1 | '$filterCollection = $this->getByType(\'' . EntityManagerInterface::class . '\')->getFilters();' |
|
| 236 | ); |
||
| 237 | 1 | $builder = $this->getContainerBuilder(); |
|
| 238 | 1 | $filterDefinitions = $builder->findByType(SQLFilter::class); |
|
| 239 | 1 | foreach (array_keys($filterDefinitions) as $name) { |
|
| 240 | $initialize->addBody('$filterCollection->enable(\'' . $name . '\');'); |
||
| 241 | } |
||
| 242 | 1 | } |
|
| 243 | |||
| 244 | 1 | protected function processSecondLevelCache($name, array $config): void |
|
| 245 | { |
||
| 246 | 1 | if (! $config['enabled']) { |
|
| 247 | 1 | return; |
|
| 248 | } |
||
| 249 | |||
| 250 | $builder = $this->getContainerBuilder(); |
||
| 251 | |||
| 252 | $cacheService = $this->getCache($name . '.secondLevel', $builder, $config['driver']); |
||
| 253 | |||
| 254 | $builder->addDefinition($this->prefix($name . '.cacheFactory')) |
||
| 255 | ->setType(CacheFactory::class) |
||
| 256 | ->setFactory($config['factoryClass'], [ |
||
| 257 | $this->prefix('@' . $name . '.cacheRegionsConfiguration'), |
||
| 258 | $cacheService, |
||
| 259 | ]) |
||
| 260 | ->addSetup('setFileLockRegionDirectory', [$config['fileLockRegionDirectory']]); |
||
| 261 | |||
| 262 | $builder->addDefinition($this->prefix($name . '.cacheRegionsConfiguration')) |
||
| 263 | ->setFactory(RegionsConfiguration::class, [ |
||
| 264 | $config['regions']['defaultLifetime'], |
||
| 265 | $config['regions']['defaultLockLifetime'], |
||
| 266 | ]); |
||
| 267 | |||
| 268 | $logger = $builder->addDefinition($this->prefix($name . '.cacheLogger')) |
||
| 269 | ->setType(CacheLogger::class) |
||
| 270 | ->setFactory(CacheLoggerChain::class) |
||
| 271 | ->setAutowired(FALSE); |
||
| 272 | |||
| 273 | if ($config['logging']) { |
||
| 274 | $logger->addSetup('setLogger', ['statistics', new Statement(StatisticsCacheLogger::class)]); |
||
| 275 | } |
||
| 276 | |||
| 277 | $cacheConfigName = $this->prefix($name . '.ormCacheConfiguration'); |
||
| 278 | $builder->addDefinition($cacheConfigName) |
||
| 279 | ->setType(CacheConfiguration::class) |
||
| 280 | ->addSetup('setCacheFactory', [$this->prefix('@' . $name . '.cacheFactory')]) |
||
| 281 | ->addSetup('setCacheLogger', [$this->prefix('@' . $name . '.cacheLogger')]) |
||
| 282 | ->setAutowired(FALSE); |
||
| 283 | |||
| 284 | $configuration = $builder->getDefinitionByType(Configuration::class); |
||
| 285 | $configuration->addSetup('setSecondLevelCacheEnabled'); |
||
| 286 | $configuration->addSetup('setSecondLevelCacheConfiguration', ['@' . $cacheConfigName]); |
||
| 287 | } |
||
| 288 | |||
| 289 | /** |
||
| 290 | * @throws AssertionException |
||
| 291 | */ |
||
| 292 | 1 | private function parseConfig(): array |
|
| 318 | |||
| 319 | 1 | private function getCache(string $prefix, ContainerBuilder $containerBuilder, string $cacheType): string |
|
| 320 | { |
||
| 321 | 1 | $cacheServiceName = $containerBuilder->getByType(Cache::class); |
|
| 322 | 1 | if ($cacheServiceName !== NULL && strlen($cacheServiceName) > 0) { |
|
| 365 | |||
| 366 | 1 | private function hasIBarPanelInterface(): bool |
|
| 370 | |||
| 371 | 1 | private function registerCommandsIntoConsole(ContainerBuilder $containerBuilder, string $name): void |
|
| 400 | |||
| 401 | 1 | private function processDbalTypes(string $name, array $types): void |
|
| 413 | |||
| 414 | 1 | private function processDbalTypeOverrides(string $name, array $types): void |
|
| 423 | |||
| 424 | 1 | private function processEventSubscribers(string $name): void |
|
| 441 | |||
| 442 | 1 | private function processFilters(): void |
|
| 443 | { |
||
| 444 | 1 | $builder = $this->getContainerBuilder(); |
|
| 445 | |||
| 446 | 1 | $configurationService = $builder->getDefinitionByType(Configuration::class); |
|
| 447 | 1 | foreach ($builder->findByType(SQLFilter::class) as $name => $filterDefinition) { |
|
| 448 | $configurationService->addSetup('addFilter', [$name, $filterDefinition->getType()]); |
||
| 449 | } |
||
| 450 | 1 | } |
|
| 451 | |||
| 452 | 1 | private function hasSymfonyConsole(): bool |
|
| 453 | { |
||
| 454 | 1 | return class_exists(Application::class); |
|
| 455 | } |
||
| 456 | |||
| 457 | 1 | private function hasEventManager(ContainerBuilder $containerBuilder): bool |
|
| 462 | } |
||
| 463 |