WeburgDownload::getPopularTorrentsUrls() - Code Metrics - Inspection of "phpmd and scrutinizer inspection fixes, code clean..." - popstas/transmission-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f277c1...6f7267 )

by Stanislav

created 2016-02-28 21:12 UTC

WeburgDownload::getPopularTorrentsUrls() B

↳ Parent: WeburgDownload

Complexity

Conditions	6
Paths	8

Size

Total Lines	56
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	56
rs	8.7592
cc	6
eloc	34
nc	8
nop	3

How to fix Long Method

<?php

namespace Popstas\Transmission\Console\Command;

use Popstas\Transmission\Console\WeburgClient;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class WeburgDownload extends Command
{
    protected function configure()
    {
        parent::configure();
        $this
            ->setName('weburg-download')
            ->setAliases(['wd'])
            ->setDescription('Download torrents from weburg.net')
            ->addOption('download-torrents-dir', null, InputOption::VALUE_OPTIONAL, 'Torrents destination directory')
            ->addOption('days', null, InputOption::VALUE_OPTIONAL, 'Max age of series torrent', 3)
            ->addArgument('movie-id', null, 'Movie ID or URL')
            ->setHelp(<<<EOT
The <info>weburg-download</info> scans weburg.net top page and downloads popular torrents.
EOT
            );
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $config = $this->getApplication()->getConfig();

        $weburgClient = $this->getApplication()->getWeburgClient();
        if (!isset($weburgClient)) {
            $this->getApplication()->setWeburgClient($this->createWeburgClient());
            $weburgClient = $this->getApplication()->getWeburgClient();
        }

        try {
            list($torrentsDir, $downloadDir) = $this->getTorrentsDirectory($input);
        } catch (\RuntimeException $e) {
            $output->writeln($e->getMessage());
            return 1;
        }

        $movieArgument = $input->getArgument('movie-id');
        if (isset($movieArgument)) {
            $movieId = $weburgClient->cleanMovieId($movieArgument);
            if (!$movieId) {
                $output->writeln($movieArgument . ' seems not weburg movie ID or URL');
                return 1;
            }

            $daysMax = $config->overrideConfig($input, 'days', 'weburg-series-max-age');

            $torrentsUrls = $this->getMovieTorrentsUrls($weburgClient, $movieId, $daysMax);

        } else {
            $torrentsUrls = $this->getPopularTorrentsUrls($output, $weburgClient, $downloadDir);
        }

        if (!$input->getOption('dry-run')) {
            foreach ($torrentsUrls as $torrentUrl) {
                $weburgClient->downloadTorrent($torrentUrl, $torrentsDir);
            }
        } else {
            $output->writeln('dry-run, don\'t really download');
        }

        return 0;
    }

    public function getPopularTorrentsUrls(OutputInterface $output, WeburgClient $weburgClient, $downloadDir)
    {
        $torrentsUrls = [];

        $config = $this->getApplication()->getConfig();
        $logger = $this->getApplication()->getLogger();

        $moviesIds = $weburgClient->getMoviesIds();

        $progress = new ProgressBar($output, count($moviesIds));
        $progress->start();

        foreach ($moviesIds as $movieId) {
            $progress->setMessage('Check movie ' . $movieId . '...');
            $progress->advance();

            $downloadedLogfile = $downloadDir . '/' . $movieId;

            $isDownloaded = file_exists($downloadedLogfile);
            if ($isDownloaded) {
                continue;
            }

            $movieInfo = $weburgClient->getMovieInfoById($movieId);
            foreach (array_keys($movieInfo) as $infoField) {
                if (!isset($movieInfo[$infoField])) {
                    $logger->warning('Cannot find ' . $infoField . ' in movie ' . $movieId);
                }
            }

            $isTorrentPopular = $weburgClient->isTorrentPopular(
                $movieInfo,
                $config->get('download-comments-min'),
                $config->get('download-imdb-min'),
                $config->get('download-kinopoisk-min'),
                $config->get('download-votes-min')
            );

            if ($isTorrentPopular) {
                $progress->setMessage('Download movie ' . $movieId . '...');

                $movieUrls = $weburgClient->getMovieTorrentUrlsById($movieId);
                $torrentsUrls = array_merge($torrentsUrls, $movieUrls);
                $logger->info('Download movie ' . $movieId . ': ' . $movieInfo['title']);

                file_put_contents(
                    $downloadedLogfile,
                    date('Y-m-d H:i:s') . "\n" . implode("\n", $torrentsUrls)
                );
            }
        }

        $progress->finish();
        
        return $torrentsUrls;
    }

    public function getMovieTorrentsUrls(WeburgClient $weburgClient, $movieId, $daysMax)
    {
        $torrentsUrls = [];

        $logger = $this->getApplication()->getLogger();

        $movieInfo = $weburgClient->getMovieInfoById($movieId);
        $logger->info('Search series ' . $movieId);
        if (!empty($movieInfo['hashes'])) {
            $seriesUrls = $weburgClient->getSeriesTorrents($movieId, $movieInfo['hashes'], $daysMax);
            $torrentsUrls = array_merge($torrentsUrls, $seriesUrls);

            if (count($seriesUrls)) {
                $logger->info('Download series ' . $movieId . ': '
                    . $movieInfo['title'] . ' (' . count($seriesUrls) . ')');
            }
        } else {
            $torrentsUrls = array_merge($torrentsUrls, $weburgClient->getMovieTorrentUrlsById($movieId));
        }
        
        return $torrentsUrls;
    }

    /**
     * @param InputInterface $input
     * @return array
     * @throws \RuntimeException
     */
    private function getTorrentsDirectory(InputInterface $input)
    {
        $config = $this->getApplication()->getConfig();

        $torrentsDir = $config->overrideConfig($input, 'download-torrents-dir');
        if (!$torrentsDir) {
            throw new \RuntimeException('Destination directory not defined. '
                .'Use command with --download-torrents-dir=/path/to/dir parameter '
                .'or define destination directory \'download-torrents-dir\' in config file.');
        }

        if (!file_exists($torrentsDir)) {
            throw new \RuntimeException('Destination directory not exists: ' . $torrentsDir);
        }

        $downloadDir = $torrentsDir . '/downloaded';
        if (!file_exists($downloadDir)) {
            mkdir($downloadDir, 0777);
        }

        return [$torrentsDir, $downloadDir];
    }
}


1			<?php
2
3			namespace Popstas\Transmission\Console\Command;
4
5			use Popstas\Transmission\Console\WeburgClient;
6			use Symfony\Component\Console\Helper\ProgressBar;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Input\InputOption;
9			use Symfony\Component\Console\Output\OutputInterface;
10
11			class WeburgDownload extends Command
12			{
13			protected function configure()
14			{
15			parent::configure();
16			$this
17			->setName('weburg-download')
18			->setAliases(['wd'])
19			->setDescription('Download torrents from weburg.net')
20			->addOption('download-torrents-dir', null, InputOption::VALUE_OPTIONAL, 'Torrents destination directory')
21			->addOption('days', null, InputOption::VALUE_OPTIONAL, 'Max age of series torrent', 3)
22			->addArgument('movie-id', null, 'Movie ID or URL')
23			->setHelp(<<<EOT
24			The <info>weburg-download</info> scans weburg.net top page and downloads popular torrents.
25			EOT
26			);
27			}
28
29			protected function execute(InputInterface $input, OutputInterface $output)
30			{
31			$config = $this->getApplication()->getConfig();
32
33			$weburgClient = $this->getApplication()->getWeburgClient();
34			if (!isset($weburgClient)) {
35			$this->getApplication()->setWeburgClient($this->createWeburgClient());
36			$weburgClient = $this->getApplication()->getWeburgClient();
37			}
38
39			try {
40			list($torrentsDir, $downloadDir) = $this->getTorrentsDirectory($input);
41			} catch (\RuntimeException $e) {
42			$output->writeln($e->getMessage());
43			return 1;
44			}
45
46			$movieArgument = $input->getArgument('movie-id');
47			if (isset($movieArgument)) {
48			$movieId = $weburgClient->cleanMovieId($movieArgument);
49			if (!$movieId) {
50			$output->writeln($movieArgument . ' seems not weburg movie ID or URL');
51			return 1;
52			}
53
54			$daysMax = $config->overrideConfig($input, 'days', 'weburg-series-max-age');
55
56			$torrentsUrls = $this->getMovieTorrentsUrls($weburgClient, $movieId, $daysMax);
57
58			} else {
59			$torrentsUrls = $this->getPopularTorrentsUrls($output, $weburgClient, $downloadDir);
60			}
61
62			if (!$input->getOption('dry-run')) {
63			foreach ($torrentsUrls as $torrentUrl) {
64			$weburgClient->downloadTorrent($torrentUrl, $torrentsDir);
65			}
66			} else {
67			$output->writeln('dry-run, don\'t really download');
68			}
69
70			return 0;
71			}
72
73			public function getPopularTorrentsUrls(OutputInterface $output, WeburgClient $weburgClient, $downloadDir)
74			{
75			$torrentsUrls = [];
76
77			$config = $this->getApplication()->getConfig();
78			$logger = $this->getApplication()->getLogger();
79
80			$moviesIds = $weburgClient->getMoviesIds();
81
82			$progress = new ProgressBar($output, count($moviesIds));
83			$progress->start();
84
85			foreach ($moviesIds as $movieId) {
86			$progress->setMessage('Check movie ' . $movieId . '...');
87			$progress->advance();
88
89			$downloadedLogfile = $downloadDir . '/' . $movieId;
90
91			$isDownloaded = file_exists($downloadedLogfile);
92			if ($isDownloaded) {
93			continue;
94			}
95
96			$movieInfo = $weburgClient->getMovieInfoById($movieId);
97			foreach (array_keys($movieInfo) as $infoField) {
98			if (!isset($movieInfo[$infoField])) {
99			$logger->warning('Cannot find ' . $infoField . ' in movie ' . $movieId);
100			}
101			}
102
103			$isTorrentPopular = $weburgClient->isTorrentPopular(
104			$movieInfo,
105			$config->get('download-comments-min'),
106			$config->get('download-imdb-min'),
107			$config->get('download-kinopoisk-min'),
108			$config->get('download-votes-min')
109			);
110
111			if ($isTorrentPopular) {
112			$progress->setMessage('Download movie ' . $movieId . '...');
113
114			$movieUrls = $weburgClient->getMovieTorrentUrlsById($movieId);
115			$torrentsUrls = array_merge($torrentsUrls, $movieUrls);
116			$logger->info('Download movie ' . $movieId . ': ' . $movieInfo['title']);
117
118			file_put_contents(
119			$downloadedLogfile,
120			date('Y-m-d H:i:s') . "\n" . implode("\n", $torrentsUrls)
121			);
122			}
123			}
124
125			$progress->finish();
126
127			return $torrentsUrls;
128			}
129
130			public function getMovieTorrentsUrls(WeburgClient $weburgClient, $movieId, $daysMax)
131			{
132			$torrentsUrls = [];
133
134			$logger = $this->getApplication()->getLogger();
135
136			$movieInfo = $weburgClient->getMovieInfoById($movieId);
137			$logger->info('Search series ' . $movieId);
138			if (!empty($movieInfo['hashes'])) {
139			$seriesUrls = $weburgClient->getSeriesTorrents($movieId, $movieInfo['hashes'], $daysMax);
140			$torrentsUrls = array_merge($torrentsUrls, $seriesUrls);
141
142			if (count($seriesUrls)) {
143			$logger->info('Download series ' . $movieId . ': '
144			. $movieInfo['title'] . ' (' . count($seriesUrls) . ')');
145			}
146			} else {
147			$torrentsUrls = array_merge($torrentsUrls, $weburgClient->getMovieTorrentUrlsById($movieId));
148			}
149
150			return $torrentsUrls;
151			}
152
153			/**
154			* @param InputInterface $input
155			* @return array
156			* @throws \RuntimeException
157			*/
158			private function getTorrentsDirectory(InputInterface $input)
159			{
160			$config = $this->getApplication()->getConfig();
161
162			$torrentsDir = $config->overrideConfig($input, 'download-torrents-dir');
163			if (!$torrentsDir) {
164			throw new \RuntimeException('Destination directory not defined. '
165			.'Use command with --download-torrents-dir=/path/to/dir parameter '
166			.'or define destination directory \'download-torrents-dir\' in config file.');
167			}
168
169			if (!file_exists($torrentsDir)) {
170			throw new \RuntimeException('Destination directory not exists: ' . $torrentsDir);
171			}
172
173			$downloadDir = $torrentsDir . '/downloaded';
174			if (!file_exists($downloadDir)) {
175			mkdir($downloadDir, 0777);
176			}
177
178			return [$torrentsDir, $downloadDir];
179			}
180			}
181

popstas / transmission-cli

Push — master ( f277c1...6f7267 )

WeburgDownload::getPopularTorrentsUrls() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like