Command::initialize() - Code Metrics - Inspection of "feat(weburg-download): add downloaded torrents wit..." - popstas/transmission-cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 556e6f...7229c3 )

by Stanislav

created 2016-03-07 19:36 UTC

Command::initialize() B

↳ Parent: Command

Complexity

Conditions	6
Paths	18

Size

Total Lines	58
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	9
Bugs	1	Features	3

Metric	Value
c	9
b	1
f	3
dl	0
loc	58
rs	8.7274
cc	6
eloc	37
nc	18
nop	2

How to fix Long Method

<?php

namespace Popstas\Transmission\Console\Command;

use GuzzleHttp;
use InfluxDB;
use Martial\Transmission\API;
use Popstas\Transmission\Console;
use Popstas\Transmission\Console\Application;
use Popstas\Transmission\Console\Config;
use Popstas\Transmission\Console\TransmissionClient;
use Psr\Log\LogLevel;
use Symfony\Component\Console\Command\Command as BaseCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Logger\ConsoleLogger;
use Symfony\Component\Console\Output\OutputInterface;

class Command extends BaseCommand
{
    private $rawHelp;

    protected function configure()
    {
        $this->addOption('dry-run', null, InputOption::VALUE_NONE, 'Dry run, don\'t change any data');
        $this->addOption('config', null, InputOption::VALUE_OPTIONAL, 'Configuration file');
        $this->addOption('transmission-host', null, InputOption::VALUE_OPTIONAL, 'Transmission host');
        $this->addOption('transmission-port', null, InputOption::VALUE_OPTIONAL, 'Transmission port');
        $this->addOption('transmission-user', null, InputOption::VALUE_OPTIONAL, 'Transmission user');
        $this->addOption('transmission-password', null, InputOption::VALUE_OPTIONAL, 'Transmission password');
    }

    /**
     * @return Application
     */
    public function getApplication()
    {
        return parent::getApplication();
    }

    protected function initialize(InputInterface $input, OutputInterface $output)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // logger
        $logger = $this->getApplication()->getLogger();
        if (!isset($logger)) {
            $verbosityLevelMap = [
                LogLevel::NOTICE => OutputInterface::VERBOSITY_NORMAL,
                LogLevel::INFO   => OutputInterface::VERBOSITY_VERBOSE,
                LogLevel::DEBUG  => OutputInterface::VERBOSITY_DEBUG,
            ];
            $logger = new ConsoleLogger($output, $verbosityLevelMap);
            $this->getApplication()->setLogger($logger);
        }

        // config
        $config = $this->getApplication()->getConfig();
        if (!isset($config)) {
            $config = new Config($input->getOption('config'));
            try {
                $config->loadConfigFile();
            } catch (\RuntimeException $e) {
                $logger->critical($e->getMessage());
                $this->setCode(function () {
                    return 1;
                });
                return;
            }
            $this->getApplication()->setConfig($config);
        }

        // compatibility: first client available at old config names
        // this overrides config values to options from command line arguments
        $firstTransmission = $config->get('transmission')[0];
        $vars = ['host', 'port', 'user', 'password'];
        foreach ($vars as $var) {
            $configName = 'transmission-' . $var;
            $config->set($configName, $this->getInputOption($input, $configName, $firstTransmission[$var]));
        }

        // client
        $client = $this->getApplication()->getClient();
        if (!isset($client)) {
            $client = $this->createTransmissionClient(
                $config->get('transmission-host'),
                $config->get('transmission-port'),
                $config->get('transmission-user'),
                $config->get('transmission-password')
            );
            $this->getApplication()->setClient($client);
        }

        $logger->info('[{date}] command: {args}', [
            'date' => date('Y-m-d H:i:s'),
            'args' => implode(' ', array_slice($_SERVER['argv'], 1)),
        ]);

        parent::initialize($input, $output);
    }

    private function createTransmissionClient($host, $port, $user, $password)
    {
        $logger = $this->getApplication()->getLogger();

        $connect = ['host' => $host, 'port' => $port, 'user' => $user, 'password' => $password];

        $baseUri = 'http://' . $connect['host'] . ':' . $connect['port'] . '/transmission/rpc';
        $httpClient = new GuzzleHttp\Client(['base_uri' => $baseUri]);

        $api = new API\RpcClient($httpClient, $connect['user'], $connect['password']);
        $api->setLogger($logger);

        $logger->debug('Connect Transmission using: {user}:{password}@{host}:{port}', $connect);

        return new TransmissionClient($api);
    }

    private function getInputOption(InputInterface $input, $optionName, $defaultValue = null)
    {
        $value = $defaultValue;
        $optionValue = $input->hasOption($optionName) ? $input->getOption($optionName) : null;
        if (isset($optionValue)) {
            $value = $optionValue;
        }
        return $value;
    }

    public function dryRun(
        InputInterface $input,
        OutputInterface $output,
        \Closure $callback,
        $message = 'dry-run, don\'t doing anything'
    ) {
        if (!$input->getOption('dry-run')) {
            return $callback();
        } else {
            $output->writeln($message);
            return true;
        }
    }

    public function setHelp($help)
    {
        $this->rawHelp = $help;
        $help = preg_replace('/```\n(.*?)\n```/mis', '<info>$1</info>', $help);
        $help = preg_replace('/(\n|^)#+ (.*)/', '$1<question>$2</question>', $help);
        $help = preg_replace('/`([^`]*?)`/', '<comment>$1</comment>', $help);
        $help = preg_replace('/\*\*(.*?)\*\*/', '<comment>$1</comment>', $help);
        return parent::setHelp($help);
    }

    public function getRawHelp()
    {
        return $this->rawHelp;
    }
}


1			<?php
2
3			namespace Popstas\Transmission\Console\Command;
4
5			use GuzzleHttp;
6			use InfluxDB;
7			use Martial\Transmission\API;
8			use Popstas\Transmission\Console;
9			use Popstas\Transmission\Console\Application;
10			use Popstas\Transmission\Console\Config;
11			use Popstas\Transmission\Console\TransmissionClient;
12			use Psr\Log\LogLevel;
13			use Symfony\Component\Console\Command\Command as BaseCommand;
14			use Symfony\Component\Console\Input\InputInterface;
15			use Symfony\Component\Console\Input\InputOption;
16			use Symfony\Component\Console\Logger\ConsoleLogger;
17			use Symfony\Component\Console\Output\OutputInterface;
18
19			class Command extends BaseCommand
20			{
21			private $rawHelp;
22
23			protected function configure()
24			{
25			$this->addOption('dry-run', null, InputOption::VALUE_NONE, 'Dry run, don\'t change any data');
26			$this->addOption('config', null, InputOption::VALUE_OPTIONAL, 'Configuration file');
27			$this->addOption('transmission-host', null, InputOption::VALUE_OPTIONAL, 'Transmission host');
28			$this->addOption('transmission-port', null, InputOption::VALUE_OPTIONAL, 'Transmission port');
29			$this->addOption('transmission-user', null, InputOption::VALUE_OPTIONAL, 'Transmission user');
30			$this->addOption('transmission-password', null, InputOption::VALUE_OPTIONAL, 'Transmission password');
31			}
32
33			/**
34			* @return Application
35			*/
36			public function getApplication()
37			{
38			return parent::getApplication();
39			}
40
41			protected function initialize(InputInterface $input, OutputInterface $output)
			0 ignored issues – show Coding Style introduced 2016-02-28 05:20 UTC by Report Bug Copy Issue Report `initialize` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
42			{
43			// logger
44			$logger = $this->getApplication()->getLogger();
45			if (!isset($logger)) {
46			$verbosityLevelMap = [
47			LogLevel::NOTICE => OutputInterface::VERBOSITY_NORMAL,
48			LogLevel::INFO => OutputInterface::VERBOSITY_VERBOSE,
49			LogLevel::DEBUG => OutputInterface::VERBOSITY_DEBUG,
50			];
51			$logger = new ConsoleLogger($output, $verbosityLevelMap);
52			$this->getApplication()->setLogger($logger);
53			}
54
55			// config
56			$config = $this->getApplication()->getConfig();
57			if (!isset($config)) {
58			$config = new Config($input->getOption('config'));
59			try {
60			$config->loadConfigFile();
61			} catch (\RuntimeException $e) {
62			$logger->critical($e->getMessage());
63			$this->setCode(function () {
64			return 1;
65			});
66			return;
67			}
68			$this->getApplication()->setConfig($config);
69			}
70
71			// compatibility: first client available at old config names
72			// this overrides config values to options from command line arguments
73			$firstTransmission = $config->get('transmission')[0];
74			$vars = ['host', 'port', 'user', 'password'];
75			foreach ($vars as $var) {
76			$configName = 'transmission-' . $var;
77			$config->set($configName, $this->getInputOption($input, $configName, $firstTransmission[$var]));
78			}
79
80			// client
81			$client = $this->getApplication()->getClient();
82			if (!isset($client)) {
83			$client = $this->createTransmissionClient(
84			$config->get('transmission-host'),
85			$config->get('transmission-port'),
86			$config->get('transmission-user'),
87			$config->get('transmission-password')
88			);
89			$this->getApplication()->setClient($client);
90			}
91
92			$logger->info('[{date}] command: {args}', [
93			'date' => date('Y-m-d H:i:s'),
94			'args' => implode(' ', array_slice($_SERVER['argv'], 1)),
95			]);
96
97			parent::initialize($input, $output);
98			}
99
100			private function createTransmissionClient($host, $port, $user, $password)
101			{
102			$logger = $this->getApplication()->getLogger();
103
104			$connect = ['host' => $host, 'port' => $port, 'user' => $user, 'password' => $password];
105
106			$baseUri = 'http://' . $connect['host'] . ':' . $connect['port'] . '/transmission/rpc';
107			$httpClient = new GuzzleHttp\Client(['base_uri' => $baseUri]);
108
109			$api = new API\RpcClient($httpClient, $connect['user'], $connect['password']);
110			$api->setLogger($logger);
111
112			$logger->debug('Connect Transmission using: {user}:{password}@{host}:{port}', $connect);
113
114			return new TransmissionClient($api);
115			}
116
117			private function getInputOption(InputInterface $input, $optionName, $defaultValue = null)
118			{
119			$value = $defaultValue;
120			$optionValue = $input->hasOption($optionName) ? $input->getOption($optionName) : null;
121			if (isset($optionValue)) {
122			$value = $optionValue;
123			}
124			return $value;
125			}
126
127			public function dryRun(
128			InputInterface $input,
129			OutputInterface $output,
130			\Closure $callback,
131			$message = 'dry-run, don\'t doing anything'
132			) {
133			if (!$input->getOption('dry-run')) {
134			return $callback();
135			} else {
136			$output->writeln($message);
137			return true;
138			}
139			}
140
141			public function setHelp($help)
142			{
143			$this->rawHelp = $help;
144			$help = preg_replace('/```\n(.*?)\n```/mis', '<info>$1</info>', $help);
145			$help = preg_replace('/(\n\|^)#+ (.*)/', '$1<question>$2</question>', $help);
146			$help = preg_replace('/`([^`]*?)`/', '<comment>$1</comment>', $help);
147			$help = preg_replace('/\\(.?)\\*/', '<comment>$1</comment>', $help);
148			return parent::setHelp($help);
149			}
150
151			public function getRawHelp()
152			{
153			return $this->rawHelp;
154			}
155			}
156

popstas / transmission-cli

Push — master ( 556e6f...7229c3 )

Command::initialize() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like