popstas / transmission-cli

src/Command/TorrentAdd.php

<?php

namespace Popstas\Transmission\Console\Command;

use Popstas\Transmission\Console\TransmissionClient;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class TorrentAdd extends Command
{
    protected function configure()
    {
        parent::configure();
        $this
            ->setName('torrent-add')
            ->setAliases(['ta'])
            ->setDescription('Add torrents to Transmission')
            ->addOption('yes', 'y', InputOption::VALUE_NONE, 'Don\'t ask confirmation')
            ->addArgument('torrent-files', InputArgument::IS_ARRAY, 'List of torrent files to add')
            ->setHelp(<<<EOT
## Add torrents

By default, Transmission may to freeze if you add several torrents at same time.
Therefore, preferred way to add torrents - with `torrent-add`.
After each add file command sleeps for 10 seconds for give time to freeze Transmission.
After that command waits for Transmission answer and add next file, etc.

```
transmission-cli torrent-add file|url [file2] [fileX]
```
EOT
            );
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $client = $this->getApplication()->getClient();
        $config = $this->getApplication()->getConfig();

        $torrentFiles = $input->getArgument('torrent-files');
        foreach ($torrentFiles as $torrentFile) {
            $this->addFile($input, $output, $client, $torrentFile);
        }

        $output->writeln('All torrents added.');

        if (!$config->get('allow-duplicates')) {
            $this->removeDuplicates($input, $output);
        }
    }

    private function addFile(InputInterface $input, OutputInterface $output, TransmissionClient $client, $torrentFile)
    {
        $this->dryRun($input, $output, function () use ($torrentFile, $client, $input, $output) {
            $torrentAdded = $client->addTorrent($torrentFile);
            if ($torrentAdded) {

The expression $torrentAdded of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                if (isset($torrentAdded['duplicate'])) {
                    $output->writeln($torrentFile . ' was not added. Probably it was added before.');
                } else {
                    $output->writeln($torrentFile . ' added. Waiting for Transmission...');
                    $client->waitForTransmission(10);
                }
            }
        }, 'dry-run, don\'t really add torrents');
    }

    private function removeDuplicates(InputInterface $input, OutputInterface $output)
    {
        $config = $this->getApplication()->getConfig();

        $command = $this->getApplication()->find('torrent-remove-duplicates');
        $arguments = array(
            'command'             => 'torrent-remove-duplicates',
            '--transmission-host' => $config->get('transmission-host'),
            '--yes'               => $input->getOption('yes'),
            '--dry-run'           => $input->getOption('dry-run')
        );
        $commandInput = new ArrayInput($arguments);
        $command->run($commandInput, $output);
    }
}