Issues in firebaseStubTest.php (master) - Issues in master - pongo/firebase-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/firebaseStubTest.php (11 issues)

Labels

Severity

Minor 11

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Firebase;

require_once __DIR__ . '/../src/firebaseStub.php';

class FirebaseStubTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var FirebaseStub
     */
    protected $_firebaseStub;

    const DEFAULT_URL = 'https://firebaseStub.firebaseio.com/';
    const DEFAULT_TOKEN = 'MqL0c8tKCtheLSYcygBrIanhU8Z2hULOFs9OKPdEp';
    const DEFAULT_TIMEOUT = 10;
    const DEFAULT_PATH = 'example/path';
    const DEFAULT_DATA = '{"firstName": "Howdy", "lastName": "Doody"}';
    const DEFAULT_PUSH_DATA = '{"firstName": "1skdSDdksdlisS"}';

    const UPDATED_URI = 'https://myfirebaseStub.firebaseio.com/';
    const UPDATED_TOKEN = 'MqL0c8tEmBeRLSYcygBrIanhU8Z2hULOFs9OKPdEp';
    const UPDATED_TIMEOUT = 30;

    const INSECURE_URL = 'http://insecure.firebaseio.com';
    const INVALID_DATA = '"firstName" "Howdy", "lastName": "Doody" "": ';
    const MISSING_DATA = '';
    const NULL_DATA = null;

    public function setUp()
    {
        $this->_firebaseStub = new FirebaseStub(self::DEFAULT_URL, self::DEFAULT_TOKEN);
    }

    public function testBaseURIInitializationOnInstantiation()
    {
        $this->assertEquals(self::DEFAULT_TOKEN, $this->_firebaseStub->_token);
    }

    public function testSetBaseURI()
    {
        $actualResponse = $this->_firebaseStub->setBaseURI(self::UPDATED_URI);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals(null, $actualResponse);

        $this->assertEquals(self::UPDATED_URI, $this->_firebaseStub->_baseURI);
    }

    public function testTokenInitializationOnInstantiation()
    {
        $this->assertEquals(self::DEFAULT_TOKEN, $this->_firebaseStub->_token);
    }

    public function testSetToken()
    {
        $actualResponse = $this->_firebaseStub->setToken(self::UPDATED_TOKEN);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals(null, $actualResponse);

        $this->assertEquals(self::UPDATED_TOKEN, $this->_firebaseStub->_token);
    }

    public function testTimeoutInitializationOnInstantiation()
    {
        $this->assertEquals(self::DEFAULT_TIMEOUT, $this->_firebaseStub->_timeout);
    }

    public function testSetTimeout()
    {
        $actualResponse = $this->_firebaseStub->setTimeout(self::UPDATED_TIMEOUT);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals(null, $actualResponse);

        $this->assertEquals(self::UPDATED_TIMEOUT, $this->_firebaseStub->_timeout);
    }

    public function testSet()
    {
        $this->_firebaseStub->setResponse(self::DEFAULT_DATA);
        $actualResponse = $this->_firebaseStub->set(self::DEFAULT_PATH, self::DEFAULT_DATA);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals(self::DEFAULT_DATA, $actualResponse);
    }

    public function testPush()
    {
        $this->_firebaseStub->setResponse(self::DEFAULT_PUSH_DATA);
        $actualResponse = $this->_firebaseStub->push(self::DEFAULT_PATH, self::DEFAULT_DATA);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals(self::DEFAULT_PUSH_DATA, $actualResponse);
    }

    public function testUpdate()
    {
        $this->_firebaseStub->setResponse(self::DEFAULT_DATA);
        $actualResponse = $this->_firebaseStub->update(self::DEFAULT_PATH, self::DEFAULT_DATA);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals(self::DEFAULT_DATA, $actualResponse);
    }

    public function testDelete()
    {
        $actualResponse = $this->_firebaseStub->delete(self::DEFAULT_PATH);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals(null, $actualResponse);
    }

    public function testInvalidBaseUri()
    {
        $firebase = new FirebaseStub(self::INSECURE_URL);
        $response = $firebase->set(self::DEFAULT_PATH, self::DEFAULT_DATA);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals($this->_getErrorMessages('INSECURE_URL'), $response);
    }

    public function testMissingData()
    {
        $response = $this->_firebaseStub->set(self::DEFAULT_PATH, self::MISSING_DATA);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals($this->_getErrorMessages('NO_DATA'), $response);
    }

    public function testNullData()
    {
        $response = $this->_firebaseStub->set(self::DEFAULT_PATH, self::NULL_DATA);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals($this->_getErrorMessages('NO_DATA'), $response);
    }

    /**
     * @param string $errorCode
     */
    private function _getErrorMessages($errorCode)
    {
        $errorMessages = Array(
            'INSECURE_URL' => 'Firebase does not support non-ssl traffic. Please try your request again over https.',
            'INVALID_JSON' => 'Invalid data; couldn\'t parse JSON object, array, or value. Perhaps you\'re using invalid characters in your key names.',
            'NO_DATA' => 'Missing data; Perhaps you forgot to send the data.'
        );

        return $errorMessages[$errorCode];
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 6 and the first side effect is on line 4. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			namespace Firebase;
3
4			require_once __DIR__ . '/../src/firebaseStub.php';
5
6			class FirebaseStubTest extends \PHPUnit_Framework_TestCase
7			{
8			/**
9			* @var FirebaseStub
10			*/
11			protected $_firebaseStub;
12
13			const DEFAULT_URL = 'https://firebaseStub.firebaseio.com/';
14			const DEFAULT_TOKEN = 'MqL0c8tKCtheLSYcygBrIanhU8Z2hULOFs9OKPdEp';
15			const DEFAULT_TIMEOUT = 10;
16			const DEFAULT_PATH = 'example/path';
17			const DEFAULT_DATA = '{"firstName": "Howdy", "lastName": "Doody"}';
18			const DEFAULT_PUSH_DATA = '{"firstName": "1skdSDdksdlisS"}';
19
20			const UPDATED_URI = 'https://myfirebaseStub.firebaseio.com/';
21			const UPDATED_TOKEN = 'MqL0c8tEmBeRLSYcygBrIanhU8Z2hULOFs9OKPdEp';
22			const UPDATED_TIMEOUT = 30;
23
24			const INSECURE_URL = 'http://insecure.firebaseio.com';
25			const INVALID_DATA = '"firstName" "Howdy", "lastName": "Doody" "": ';
26			const MISSING_DATA = '';
27			const NULL_DATA = null;
28
29			public function setUp()
30			{
31			$this->_firebaseStub = new FirebaseStub(self::DEFAULT_URL, self::DEFAULT_TOKEN);
32			}
33
34			public function testBaseURIInitializationOnInstantiation()
35			{
36			$this->assertEquals(self::DEFAULT_TOKEN, $this->_firebaseStub->_token);
37			}
38
39			public function testSetBaseURI()
40			{
41			$actualResponse = $this->_firebaseStub->setBaseURI(self::UPDATED_URI);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$actualResponse` is correct as `$this->_firebaseStub->se...eURI(self::UPDATED_URI)` (which targets `Firebase\FirebaseStub::setBaseURI()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
42			$this->assertEquals(null, $actualResponse);
43
44			$this->assertEquals(self::UPDATED_URI, $this->_firebaseStub->_baseURI);
45			}
46
47			public function testTokenInitializationOnInstantiation()
48			{
49			$this->assertEquals(self::DEFAULT_TOKEN, $this->_firebaseStub->_token);
50			}
51
52			public function testSetToken()
53			{
54			$actualResponse = $this->_firebaseStub->setToken(self::UPDATED_TOKEN);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$actualResponse` is correct as `$this->_firebaseStub->se...en(self::UPDATED_TOKEN)` (which targets `Firebase\FirebaseStub::setToken()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
55			$this->assertEquals(null, $actualResponse);
56
57			$this->assertEquals(self::UPDATED_TOKEN, $this->_firebaseStub->_token);
58			}
59
60			public function testTimeoutInitializationOnInstantiation()
61			{
62			$this->assertEquals(self::DEFAULT_TIMEOUT, $this->_firebaseStub->_timeout);
63			}
64
65			public function testSetTimeout()
66			{
67			$actualResponse = $this->_firebaseStub->setTimeout(self::UPDATED_TIMEOUT);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$actualResponse` is correct as `$this->_firebaseStub->se...(self::UPDATED_TIMEOUT)` (which targets `Firebase\FirebaseStub::setTimeOut()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
68			$this->assertEquals(null, $actualResponse);
69
70			$this->assertEquals(self::UPDATED_TIMEOUT, $this->_firebaseStub->_timeout);
71			}
72
73			public function testSet()
74			{
75			$this->_firebaseStub->setResponse(self::DEFAULT_DATA);
76			$actualResponse = $this->_firebaseStub->set(self::DEFAULT_PATH, self::DEFAULT_DATA);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$actualResponse` is correct as `$this->_firebaseStub->se...TH, self::DEFAULT_DATA)` (which targets `Firebase\FirebaseStub::set()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
77			$this->assertEquals(self::DEFAULT_DATA, $actualResponse);
78			}
79
80			public function testPush()
81			{
82			$this->_firebaseStub->setResponse(self::DEFAULT_PUSH_DATA);
83			$actualResponse = $this->_firebaseStub->push(self::DEFAULT_PATH, self::DEFAULT_DATA);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$actualResponse` is correct as `$this->_firebaseStub->pu...TH, self::DEFAULT_DATA)` (which targets `Firebase\FirebaseStub::push()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
84			$this->assertEquals(self::DEFAULT_PUSH_DATA, $actualResponse);
85			}
86
87			public function testUpdate()
88			{
89			$this->_firebaseStub->setResponse(self::DEFAULT_DATA);
90			$actualResponse = $this->_firebaseStub->update(self::DEFAULT_PATH, self::DEFAULT_DATA);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$actualResponse` is correct as `$this->_firebaseStub->up...TH, self::DEFAULT_DATA)` (which targets `Firebase\FirebaseStub::update()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
91			$this->assertEquals(self::DEFAULT_DATA, $actualResponse);
92			}
93
94			public function testDelete()
95			{
96			$actualResponse = $this->_firebaseStub->delete(self::DEFAULT_PATH);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$actualResponse` is correct as `$this->_firebaseStub->delete(self::DEFAULT_PATH)` (which targets `Firebase\FirebaseStub::delete()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
97			$this->assertEquals(null, $actualResponse);
98			}
99
100			public function testInvalidBaseUri()
101			{
102			$firebase = new FirebaseStub(self::INSECURE_URL);
103			$response = $firebase->set(self::DEFAULT_PATH, self::DEFAULT_DATA);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$response` is correct as `$firebase->set(self::DEF...TH, self::DEFAULT_DATA)` (which targets `Firebase\FirebaseStub::set()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
104			$this->assertEquals($this->_getErrorMessages('INSECURE_URL'), $response);
105			}
106
107			public function testMissingData()
108			{
109			$response = $this->_firebaseStub->set(self::DEFAULT_PATH, self::MISSING_DATA);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$response` is correct as `$this->_firebaseStub->se...TH, self::MISSING_DATA)` (which targets `Firebase\FirebaseStub::set()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
110			$this->assertEquals($this->_getErrorMessages('NO_DATA'), $response);
111			}
112
113			public function testNullData()
114			{
115			$response = $this->_firebaseStub->set(self::DEFAULT_PATH, self::NULL_DATA);
			0 ignored issues – show Bug introduced 2016-08-17 19:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$response` is correct as `$this->_firebaseStub->se..._PATH, self::NULL_DATA)` (which targets `Firebase\FirebaseStub::set()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
116			$this->assertEquals($this->_getErrorMessages('NO_DATA'), $response);
117			}
118
119			/**
120			* @param string $errorCode
121			*/
122			private function _getErrorMessages($errorCode)
123			{
124			$errorMessages = Array(
125			'INSECURE_URL' => 'Firebase does not support non-ssl traffic. Please try your request again over https.',
126			'INVALID_JSON' => 'Invalid data; couldn\'t parse JSON object, array, or value. Perhaps you\'re using invalid characters in your key names.',
127			'NO_DATA' => 'Missing data; Perhaps you forgot to send the data.'
128			);
129
130			return $errorMessages[$errorCode];
131			}
132			}
133

pongo / firebase-php

Issues (27)

Security Analysis no request data

tests/firebaseStubTest.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like