pongo / firebase-php

src/firebaseStub.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 13 and the first side effect is on line 4.

namespace Firebase;

require_once __DIR__ . '/firebaseInterface.php';

/**
 * Class FirebaseStub
 *
 * Stubs the Firebase interface without issuing any cURL requests.
 *
 * @package Firebase
 */
class FirebaseStub implements FirebaseInterface
{
    /**
     * @var null|string
     */
    private $_response = null;

    /**
     * @var
     */
    public $_baseURI;

    /**
     * @var
     */
    public $_token;

    /**
     * @param string $baseURI
     * @param string $token
     */
    function __construct($baseURI = '', $token = '')

It is generally recommended to explicitly declare the visibility for methods.

    {
        if (!extension_loaded('curl')) {
            trigger_error('Extension CURL is not loaded.', E_USER_ERROR);
        }

        $this->setBaseURI($baseURI);
        $this->setTimeOut(10);
        $this->setToken($token);
    }

    /**
     * @param string $token
     * @return null
     */
    public function setToken($token)
    {
        $this->_token = $token;
    }

    /**
     * @param string $baseURI
     * @return null
     */
    public function setBaseURI($baseURI)
    {
        $baseURI .= (substr($baseURI, -1) == '/' ? '' : '/');
        $this->_baseURI = $baseURI;
    }

    /**
     * @param integer $seconds
     * @return null
     */
    public function setTimeOut($seconds)
    {
        $this->_timeout = $seconds;

The property _timeout does not exist. Did you maybe forget to declare it?

    }

    /**
     * @param string $path
     * @param string|null $data
     * @param $options
     * @return null
     */
    public function set($path, $data, $options = array())
    {
        return $this->_getSetResponse($data);
    }

    /**
     * @param string $path
     * @param string $data
     * @param $options
     * @return null
     */
    public function push($path, $data, $options = array())
    {
        return $this->set($path, $data);
    }

    /**
     * @param string $path
     * @param string $data
     * @param $options
     * @return null
     */
    public function update($path, $data, $options = array())
    {
        return $this->set($path, $data);
    }

    /**
     * @param $path
     * @param $options
     * @return null
     */
    public function get($path, $options = array())
    {
        return $this->_getGetResponse();
    }

    /**
     * @param string $path
     * @param $options
     * @return null
     */
    public function delete($path, $options = array())
    {
        return $this->_getDeleteResponse();
    }

    /**
     * @param string $expectedResponse
     */
    public function setResponse($expectedResponse)
    {
        $this->_response = $expectedResponse;
    }

    /**
     * @uses $this->_baseURI
     * @return Error
     */
    private function _isBaseURIValid()
    {
        $error = preg_match('/^https:\/\//', $this->_baseURI);
        return new Error(($error == 0 ? true : false), 'Firebase does not support non-ssl traffic. Please try your request again over https.');
    }

    /**
     * @param $data
     * @return Error
     */
    private function _isDataValid($data)
    {
        if ($data == "" || $data == null) {
            return new Error(true, "Missing data; Perhaps you forgot to send the data.");
        }
        $error = json_decode($data);
        return new Error(($error !== null ? false : true), "Invalid data; couldn't parse JSON object, array, or value. Perhaps you're using invalid characters in your key names.");
    }

    /**
     * @param string|null $data
     * @return null
     */
    private function _getSetResponse($data)
    {
        $validBaseUriObject = $this->_isBaseURIValid();
        if ($validBaseUriObject->error) {

The property error does not seem to exist in Firebase\Error.

            return $validBaseUriObject->message;

The property message does not seem to exist in Firebase\Error.

        }

        $validDataObject = $this->_isDataValid($data);
        if ($validDataObject->error) {
            return $validDataObject->message;
        }

        return $this->_response;
    }

    /**
     * @return null
     */
    private function _getGetResponse()
    {
        $validBaseUriObject = $this->_isBaseURIValid();
        if ($validBaseUriObject->error) {

The property error does not seem to exist in Firebase\Error.

            return $validBaseUriObject->message;

The property message does not seem to exist in Firebase\Error.

        }
        return $this->_response;
    }

    /**
     * @return null
     */
    private function _getDeleteResponse()
    {
        return $this->_getGetResponse();
    }
}

/**
 * Class Error
 *
 * @package Firebase
 */
class Error

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    /**
     * @param boolean $error
     * @param string $message
     */
    function __construct($error, $message)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->error = $error;

The property error does not exist. Did you maybe forget to declare it?

        $this->message = $message;

The property message does not exist. Did you maybe forget to declare it?

    }
}