Issues in GenerateEntity.php (master) - Issues in master - pomm-project/Cli - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

sources/lib/Command/GenerateEntity.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of Pomm's Cli package.
 *
 * (c) 2014 - 2015 Grégoire HUBERT <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace PommProject\Cli\Command;

use PommProject\Foundation\ParameterHolder;
use PommProject\ModelManager\Generator\EntityGenerator;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * GenerateEntity
 *
 * Entity generation command.
 *
 * @package   Cli
 * @copyright 2014 - 2015 Grégoire HUBERT
 * @author    Grégoire HUBERT
 * @license   X11 {@link http://opensource.org/licenses/mit-license.php}
 * @see       PommAwareCommand
 */
class GenerateEntity extends RelationAwareCommand

{
    /**
     * configure
     *
     * @see Command
     */
    protected function configure()
    {
        $this
            ->setName('pomm:generate:entity')
            ->setDescription('Generate an Entity class.')
            ->setHelp(<<<HELP
This command generates an empty FlexibleEntity class in the given directory with the given namespace. By default, it creates a tree structure in the following format: ConfigName/NameSchema.

In order to comply with the project’s autoloading rules, it is possible to prefix this directory structure and / or namespace:

<info>pomm:generate:entity -d sources/lib/Model -a 'Vendor\Project\Model' --psr4 builder_name</info>

HELP
        )
        ;
        parent::configure();
    }

    /**
     * configureOptionals
     *
     * @see PommAwareCommand
     */
    protected function configureOptionals()
    {
        parent::configureOptionals()
            ->addOption(
                'force',
                null,
                InputOption::VALUE_NONE,
                'Force overwriting an existing file.'
            )
            ->addOption(
                'psr4',
                null,
                InputOption::VALUE_NONE,
                'Use PSR4 structure.'
            )
            ->addOption(
                'path-pattern',
                null,
                InputOption::VALUE_REQUIRED,
                'Use a different directory pattern when generating classes.',
                '{session}/{schema}Schema'
            )
        ;

        return $this;
    }

    /**
     * execute
     *
     * @see Command
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        parent::execute($input, $output);

        $session = $this->mustBeModelManagerSession($this->getSession());

        $this->pathFile = $this->getPathFile(
            $input->getArgument('config-name'),

            $this->relation,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            '',
            '',
            $input->getOption('psr4'),
            $input->getOption('path-pattern')
        );
        $this->namespace = $this->getNamespace($input->getArgument('config-name'), null, $input->getOption('path-pattern'));


        $this->updateOutput(
            $output,
            (new EntityGenerator(
                $session,
                $this->schema,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $this->relation,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $this->pathFile,
                $this->namespace,
                $this->flexible_container
            ))->generate(new ParameterHolder(['force' => $input->getOption('force')]))
        );

        return 0;
    }
}


1		<?php
2		/*
3		* This file is part of Pomm's Cli package.
4		*
5		* (c) 2014 - 2015 Grégoire HUBERT <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10		namespace PommProject\Cli\Command;
11
12		use PommProject\Foundation\ParameterHolder;
13		use PommProject\ModelManager\Generator\EntityGenerator;
14		use Symfony\Component\Console\Command\Command;
15		use Symfony\Component\Console\Input\InputInterface;
16		use Symfony\Component\Console\Input\InputOption;
17		use Symfony\Component\Console\Output\OutputInterface;
18
19		/**
20		* GenerateEntity
21		*
22		* Entity generation command.
23		*
24		* @package Cli
25		* @copyright 2014 - 2015 Grégoire HUBERT
26		* @author Grégoire HUBERT
27		* @license X11 {@link http://opensource.org/licenses/mit-license.php}
28		* @see PommAwareCommand
29		*/
30	View Code Duplication	class GenerateEntity extends RelationAwareCommand
		0 ignored issues – show Duplication introduced 2015-11-23 09:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		/**
33		* configure
34		*
35		* @see Command
36		*/
37		protected function configure()
38		{
39		$this
40		->setName('pomm:generate:entity')
41		->setDescription('Generate an Entity class.')
42		->setHelp(<<<HELP
43		This command generates an empty FlexibleEntity class in the given directory with the given namespace. By default, it creates a tree structure in the following format: ConfigName/NameSchema.
44
45		In order to comply with the project’s autoloading rules, it is possible to prefix this directory structure and / or namespace:
46
47		<info>pomm:generate:entity -d sources/lib/Model -a 'Vendor\Project\Model' --psr4 builder_name</info>
48
49		HELP
50		)
51		;
52		parent::configure();
53		}
54
55		/**
56		* configureOptionals
57		*
58		* @see PommAwareCommand
59		*/
60		protected function configureOptionals()
61		{
62		parent::configureOptionals()
63		->addOption(
64		'force',
65		null,
66		InputOption::VALUE_NONE,
67		'Force overwriting an existing file.'
68		)
69		->addOption(
70		'psr4',
71		null,
72		InputOption::VALUE_NONE,
73		'Use PSR4 structure.'
74		)
75		->addOption(
76		'path-pattern',
77		null,
78		InputOption::VALUE_REQUIRED,
79		'Use a different directory pattern when generating classes.',
80		'{session}/{schema}Schema'
81		)
82		;
83
84		return $this;
85		}
86
87		/**
88		* execute
89		*
90		* @see Command
91		*/
92		protected function execute(InputInterface $input, OutputInterface $output)
93		{
94		parent::execute($input, $output);
95
96		$session = $this->mustBeModelManagerSession($this->getSession());
97
98		$this->pathFile = $this->getPathFile(
99		$input->getArgument('config-name'),
		0 ignored issues – show Bug introduced 2019-08-15 07:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$input->getArgument('config-name')` targeting `Symfony\Component\Consol...nterface::getArgument()` can also be of type `array<integer,string>` or `null`; however, `PommProject\Cli\Command\...eCommand::getPathFile()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
100		$this->relation,
		0 ignored issues – show Bug introduced 2019-08-15 07:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->relation` can also be of type `array<integer,string>` or `null`; however, `PommProject\Cli\Command\...eCommand::getPathFile()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
101		'',
102		'',
103		$input->getOption('psr4'),
104		$input->getOption('path-pattern')
105		);
106		$this->namespace = $this->getNamespace($input->getArgument('config-name'), null, $input->getOption('path-pattern'));
		0 ignored issues – show Bug introduced 2019-08-15 07:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$input->getArgument('config-name')` targeting `Symfony\Component\Consol...nterface::getArgument()` can also be of type `array<integer,string>` or `null`; however, `PommProject\Cli\Command\...Command::getNamespace()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
107
108		$this->updateOutput(
109		$output,
110		(new EntityGenerator(
111		$session,
112		$this->schema,
		0 ignored issues – show Bug introduced 2019-08-15 07:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->schema` can also be of type `array<integer,string>` or `null`; however, `PommProject\ModelManager...enerator::__construct()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
113		$this->relation,
		0 ignored issues – show Bug introduced 2019-08-15 07:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->relation` can also be of type `array<integer,string>` or `null`; however, `PommProject\ModelManager...enerator::__construct()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
114		$this->pathFile,
115		$this->namespace,
116		$this->flexible_container
117		))->generate(new ParameterHolder(['force' => $input->getOption('force')]))
118		);
119
120		return 0;
121		}
122		}
123

pomm-project / Cli

Issues (41)

Security Analysis no request data

sources/lib/Command/GenerateEntity.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like