Complex classes like ApiMethods often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ApiMethods, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class ApiMethods |
||
11 | { |
||
12 | private $httpClient; |
||
13 | private $currentTeam; |
||
14 | |||
15 | /** |
||
16 | * @param ClientInterface $client |
||
17 | * @param $currentTeam |
||
18 | */ |
||
19 | public function __construct(ClientInterface $client, $currentTeam) |
||
24 | |||
25 | /** |
||
26 | * @param array $params |
||
27 | * @param null $headers |
||
28 | */ |
||
29 | public function user(array $params = []) |
||
35 | |||
36 | /** |
||
37 | * @return \Psr\Http\Message\ResponseInterface |
||
38 | */ |
||
39 | public function teams() |
||
43 | |||
44 | /** |
||
45 | * @param null $name |
||
46 | * |
||
47 | * @return \Psr\Http\Message\ResponseInterface |
||
48 | */ |
||
49 | public function team($name = null) |
||
53 | |||
54 | /** |
||
55 | * @return \Psr\Http\Message\ResponseInterface |
||
56 | */ |
||
57 | public function stats() |
||
61 | |||
62 | /** |
||
63 | * @return \Psr\Http\Message\ResponseInterface |
||
64 | */ |
||
65 | public function members() |
||
69 | |||
70 | /** |
||
71 | * @param array $params |
||
72 | * |
||
73 | * @return \Psr\Http\Message\ResponseInterface |
||
74 | */ |
||
75 | public function posts(array $params = []) |
||
81 | |||
82 | /** |
||
83 | * @param $number |
||
84 | * |
||
85 | * @return \Psr\Http\Message\ResponseInterface |
||
86 | */ |
||
87 | public function post($number) |
||
91 | |||
92 | /** |
||
93 | * @param $data |
||
94 | * |
||
95 | * @return \Psr\Http\Message\ResponseInterface |
||
96 | */ |
||
97 | public function createPost($data) |
||
105 | |||
106 | /** |
||
107 | * @param $number |
||
108 | * @param $data |
||
109 | * |
||
110 | * @return \Psr\Http\Message\ResponseInterface |
||
111 | */ |
||
112 | public function updatePost($number, $data) |
||
120 | |||
121 | /** |
||
122 | * @param $number |
||
123 | * |
||
124 | * @return \Psr\Http\Message\ResponseInterface |
||
125 | */ |
||
126 | public function deletePost($number) |
||
130 | |||
131 | /** |
||
132 | * @param int $number |
||
133 | * @param array $params |
||
134 | * |
||
135 | * @return \Psr\Http\Message\ResponseInterface |
||
136 | */ |
||
137 | public function comments($number = null, $params = []) |
||
149 | |||
150 | /** |
||
151 | * @param $commentId |
||
152 | * @param array $params |
||
153 | * |
||
154 | * @return \Psr\Http\Message\ResponseInterface |
||
155 | */ |
||
156 | public function comment($commentId, $params = []) |
||
162 | |||
163 | /** |
||
164 | * @param $postNumber |
||
165 | * @param $data |
||
166 | * |
||
167 | * @return \Psr\Http\Message\ResponseInterface |
||
168 | */ |
||
169 | public function createComment($postNumber, $data) |
||
177 | |||
178 | /** |
||
179 | * @param $commentId |
||
180 | * @param $data |
||
181 | * |
||
182 | * @return \Psr\Http\Message\ResponseInterface |
||
183 | */ |
||
184 | public function updateComment($commentId, $data) |
||
192 | |||
193 | /** |
||
194 | * @param $commentId |
||
195 | * |
||
196 | * @return \Psr\Http\Message\ResponseInterface |
||
197 | */ |
||
198 | public function deleteComment($commentId) |
||
202 | |||
203 | /** |
||
204 | * @param $postNumber |
||
205 | * @return \Psr\Http\Message\ResponseInterface |
||
206 | */ |
||
207 | public function createSharing($postNumber) |
||
211 | |||
212 | /** |
||
213 | * @param $postNumber |
||
214 | * @return \Psr\Http\Message\ResponseInterface |
||
215 | */ |
||
216 | public function deleteSharing($postNumber) |
||
220 | |||
221 | /** |
||
222 | * @param $postNumber |
||
223 | * @param array $params |
||
224 | * |
||
225 | * @return \Psr\Http\Message\ResponseInterface |
||
226 | */ |
||
227 | public function postStargazers($postNumber, $params = []) |
||
233 | |||
234 | /** |
||
235 | * @param $postNumber |
||
236 | * @param array $params |
||
237 | * |
||
238 | * @return \Psr\Http\Message\ResponseInterface |
||
239 | */ |
||
240 | public function addPostStar($postNumber, $params = []) |
||
246 | |||
247 | /** |
||
248 | * @param $postNumber |
||
249 | * |
||
250 | * @return \Psr\Http\Message\ResponseInterface |
||
251 | */ |
||
252 | public function deletePostStar($postNumber) |
||
256 | |||
257 | /** |
||
258 | * @param $commentId |
||
259 | * @param array $params |
||
260 | * |
||
261 | * @return \Psr\Http\Message\ResponseInterface |
||
262 | */ |
||
263 | public function commentStargazers($commentId, $params = []) |
||
269 | |||
270 | /** |
||
271 | * @param $commentId |
||
272 | * @param array $params |
||
273 | * |
||
274 | * @return \Psr\Http\Message\ResponseInterface |
||
275 | */ |
||
276 | public function addCommentStar($commentId, $params = []) |
||
282 | |||
283 | /** |
||
284 | * @param $commentId |
||
285 | * |
||
286 | * @return \Psr\Http\Message\ResponseInterface |
||
287 | */ |
||
288 | public function deleteCommentStar($commentId) |
||
292 | |||
293 | /** |
||
294 | * @param $postNumber |
||
295 | * @param array $params |
||
296 | * |
||
297 | * @return \Psr\Http\Message\ResponseInterface |
||
298 | */ |
||
299 | public function watchers($postNumber, $params = []) |
||
305 | |||
306 | /** |
||
307 | * @param $postNumber |
||
308 | * |
||
309 | * @return \Psr\Http\Message\ResponseInterface |
||
310 | */ |
||
311 | public function addWatch($postNumber) |
||
315 | |||
316 | /** |
||
317 | * @param $postNumber |
||
318 | * |
||
319 | * @return \Psr\Http\Message\ResponseInterface |
||
320 | */ |
||
321 | public function deleteWatch($postNumber) |
||
325 | |||
326 | /** |
||
327 | * @return \Psr\Http\Message\ResponseInterface |
||
328 | */ |
||
329 | public function categories() |
||
333 | |||
334 | /** |
||
335 | * @param array $params |
||
336 | * |
||
337 | * @return \Psr\Http\Message\ResponseInterface |
||
338 | */ |
||
339 | public function batchMoveCategory($params = []) |
||
345 | |||
346 | /** |
||
347 | * @return \Psr\Http\Message\ResponseInterface |
||
348 | */ |
||
349 | public function tags() |
||
353 | |||
354 | /** |
||
355 | * @return \Psr\Http\Message\ResponseInterface |
||
356 | */ |
||
357 | public function invitation() |
||
361 | |||
362 | /** |
||
363 | * @return \Psr\Http\Message\ResponseInterface |
||
364 | */ |
||
365 | public function regenerateInvitation() |
||
369 | |||
370 | /** |
||
371 | * @param $params |
||
372 | * |
||
373 | * @return \Psr\Http\Message\ResponseInterface |
||
374 | */ |
||
375 | public function pendingInvitations(array $params) |
||
381 | |||
382 | /** |
||
383 | * @param array $data |
||
384 | * |
||
385 | * @return \Psr\Http\Message\ResponseInterface |
||
386 | */ |
||
387 | public function sendInvitation(array $data) |
||
395 | |||
396 | /** |
||
397 | * @param string $code |
||
398 | * |
||
399 | * @return \Psr\Http\Message\ResponseInterface |
||
400 | */ |
||
401 | public function cancelInvitation($code) |
||
405 | |||
406 | /** |
||
407 | * @param array $params |
||
408 | * |
||
409 | * @return \Psr\Http\Message\ResponseInterface |
||
410 | */ |
||
411 | public function emojis(array $params = []) |
||
417 | |||
418 | /** |
||
419 | * @param $data |
||
420 | * |
||
421 | * @return \Psr\Http\Message\ResponseInterface |
||
422 | */ |
||
423 | public function createEmoji($data) |
||
431 | |||
432 | /** |
||
433 | * @param $code |
||
434 | * |
||
435 | * @return \Psr\Http\Message\ResponseInterface |
||
436 | */ |
||
437 | public function deleteEmoji($code) |
||
441 | |||
442 | private function getCurrentTeamUrl($path = '') |
||
446 | } |
||
447 |