Client::request() - Code Metrics - polidog/esa-php - Measure and Improve Code Quality continuously with Scrutinizer

Client::request() A
last analyzed 2020-11-11 14:29 UTC

↳ Parent: Client

Complexity

Conditions	2
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	1
cts	1
cp	1
rs	9.9332
c	0
b	0
f	0
cc	2
nc	3
nop	3
crap	2

<?php

declare(strict_types=1);

namespace Polidog\Esa\Client;

use GuzzleHttp\ClientInterface as HttpClientInterface;
use GuzzleHttp\Exception\GuzzleException;
use GuzzleHttp\HandlerStack;
use Polidog\Esa\Exception\ClientException;

final class Client implements ClientInterface
{
    /**
     * @var string
     */
    private $accessToken;

    /**
     * @var HttpClientInterface
     */
    private $httpClient;

    /**
     * @var array
     */
    private static $httpOptions = [
        'base_uri' => 'https://api.esa.io/v1/',
        'timeout' => 60,
        'allow_redirect' => false,
        'headers' => [
            'User-Agent' => 'esa-php-api v2',
            'Accept' => 'application/json',
        ],
    ];

    public function __construct(HttpClientInterface $httpClient)
    {
        $this->httpClient = $httpClient;
    }

    /**
     * @throws ClientException
     * @throws \RuntimeException
     */
    public function request(string $method, string $path, array $data = []): array
    {
        try {
            $response = $this->httpClient->request($method, $path, $data);

            return json_decode($response->getBody()->getContents(), true);
        } catch (GuzzleException $e) {
            throw ClientException::newException($e, $method, $path, $data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    public static function factory(string $accessToken, array $httpOptions = []): self
    {
        $httpOptions = array_merge(static::$httpOptions, $httpOptions);

        $authorization = new Authorization($accessToken);

        $httpOptions['handler'] = HandlerStack::create();
        $authorization->push($httpOptions['handler']);

        return new self(new \GuzzleHttp\Client($httpOptions));
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Polidog\Esa\Client;
6
7		use GuzzleHttp\ClientInterface as HttpClientInterface;
8		use GuzzleHttp\Exception\GuzzleException;
9		use GuzzleHttp\HandlerStack;
10		use Polidog\Esa\Exception\ClientException;
11
12		final class Client implements ClientInterface
13		{
14		/**
15		* @var string
16		*/
17		private $accessToken;
18
19		/**
20		* @var HttpClientInterface
21		*/
22		private $httpClient;
23
24		/**
25		* @var array
26		*/
27		private static $httpOptions = [
28		'base_uri' => 'https://api.esa.io/v1/',
29		'timeout' => 60,
30		'allow_redirect' => false,
31		'headers' => [
32		'User-Agent' => 'esa-php-api v2',
33		'Accept' => 'application/json',
34		],
35		];
36
37		public function __construct(HttpClientInterface $httpClient)
38		{
39	4	$this->httpClient = $httpClient;
40		}
41	4
42	4	/**
43	4	* @throws ClientException
44		* @throws \RuntimeException
45		*/
46		public function request(string $method, string $path, array $data = []): array
47		{
48		try {
49		$response = $this->httpClient->request($method, $path, $data);
50
51		return json_decode($response->getBody()->getContents(), true);
52		} catch (GuzzleException $e) {
53		throw ClientException::newException($e, $method, $path, $data);
		0 ignored issues – show Documentation introduced 2018-01-28 16:22 UTC by Report Bug Copy Issue Report `$e` is of type `object<GuzzleHttp\Exception\GuzzleException>`, but the function expects a `object<Exception>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54		}
55	2	}
56
57		public static function factory(string $accessToken, array $httpOptions = []): self
58	2	{
59		$httpOptions = array_merge(static::$httpOptions, $httpOptions);
		0 ignored issues – show Comprehensibility introduced 2018-01-28 16:16 UTC by Report Bug Copy Issue Report Since `Polidog\Esa\Client\Client` is declared final, using late-static binding will have no effect. You might want to replace `static` with `self` instead. Late static binding only has effect in subclasses. A `final` class cannot be extended anymore so late static binding cannot occurr. Consider replacing `static::` with `self::`. To learn more about late static binding, please refer to the PHP core documentation. Loading history...
60	1	$authorization = new Authorization($accessToken);
61	1
62	1	$httpOptions['handler'] = HandlerStack::create();
63		$authorization->push($httpOptions['handler']);
64
65		return new self(new \GuzzleHttp\Client($httpOptions));
66		}
67		}
68

polidog / esa-php

Client::request() A last analyzed 2020-11-11 14:29 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Client::request() A
last analyzed 2020-11-11 14:29 UTC