Cron - Code Metrics - Inspection of "code quality improvement" - poliander/cron - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 131d67...b52764 )

by René

created 2016-06-11 13:45 UTC

Cron C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	345
Duplicated Lines	1.74 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	8
Bugs	0	Features	0

Metric	Value
wmc	58
c	8
b	0
f	0
lcom	1
cbo	0
dl	6
loc	345
rs	6.3005

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	setExpression()	0	7	1
A	setTimeZone()	0	5	1
A	isValid()	0	14	3
C	getNext()	0	61	14
B	isMatching()	0	31	6
A	parse()	0	18	4
D	parseSegment()	6	91	28

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Cron often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Cron, and based on these observations, apply Extract Interface, too.

<?php

/**
 * Cron expression parser and validator
 *
 * @author René Pollesch
 */
class Cron
namespace YourVendor;

class YourClass { }
{
    /**
     * Weekday look-up table
     *
     * @var array
     */
    protected static $weekdays = [
        'sun' => 0,
        'mon' => 1,
        'tue' => 2,
        'wed' => 3,
        'thu' => 4,
        'fri' => 5,
        'sat' => 6
    ];

    /**
     * Month name look-up table
     *
     * @var array
     */
    protected static $months = [
        'jan' => 1,
        'feb' => 2,
        'mar' => 3,
        'apr' => 4,
        'may' => 5,
        'jun' => 6,
        'jul' => 7,
        'aug' => 8,
        'sep' => 9,
        'oct' => 10,
        'nov' => 11,
        'dec' => 12
    ];

    /**
     * Cron expression
     *
     * @var string
     */
    protected $expression;

    /**
     * Time zone
     *
     * @var \DateTimeZone
     */
    protected $timeZone;

    /**
     * Matching register
     *
     * @var array|null
     */
    protected $registers;

    /**
     * Class constructor sets cron expression property
     *
     * @param string $expression cron expression
     * @param \DateTimeZone $timeZone
     */
    public function __construct($expression = '* * * * *', \DateTimeZone $timeZone = null)
    {
        $this->setExpression($expression);
        $this->setTimeZone($timeZone);
    }

    /**
     * Set expression
     *
     * @param string $expression
     * @return self
     */
    public function setExpression($expression)
    {
        $this->expression = trim((string)$expression);
        $this->registers = null;

        return $this;
    }

    /**
     * Set time zone
     *
     * @param \DateTimeZone $timeZone
     * @return self
     */
    public function setTimeZone(\DateTimeZone $timeZone = null)
    {
        $this->timeZone = $timeZone;
        return $this;
    }

    /**
     * Parse and validate cron expression
     *
     * @return bool true if expression is valid, or false on error
     */
    public function isValid()
    {
        $result = true;

        if ($this->registers === null) {
            try {
                $this->registers = $this->parse();
            } catch (\Exception $e) {
                $result = false;
            }
        }

        return $result;
    }

    /**
     * Match current or given date/time against cron expression
     *
     * @param mixed $dtime \DateTime object, timestamp or null
     * @return bool
     */
    public function isMatching($dtime = null)
    {
        if ($dtime instanceof \DateTime) {
            $dtime->setTimezone($this->timeZone);
        } else {
            $dt = new \DateTime('now', $this->timeZone);

            if ((int)$dtime > 0) {
                $dt->setTimestamp($dtime);
            }

            $dtime = $dt;
        }

        $segments = sscanf($dtime->format('i G j n w'), '%d %d %d %d %d');

        try {
            $result = true;

            foreach ($this->parse() as $i => $item) {
                if (isset($item[(int)$segments[$i]]) === false) {
                    $result = false;
                    break;
                }
            }
        } catch (\Exception $e) {
            $result = false;
        }

        return $result;
    }

    /**
     * Calculate next matching timestamp
     *
     * @param mixed $dtime \DateTime object, timestamp or null
     * @return int|bool next matching timestamp, or false on error
     */
    public function getNext($dtime = null)
    {
        $result = false;

        if ($this->isValid()) {
            if ($dtime instanceof \DateTime) {
                $timestamp = $dtime->getTimestamp();
            } elseif ((int)$dtime > 0) {
                $timestamp = $dtime;
            } else {
                $timestamp = time();
            }

            $dt = new \DateTime('now', $this->timeZone);
            $dt->setTimestamp(ceil($timestamp / 60) * 60);

            list($pday, $pmonth, $pyear, $phour) = sscanf(
                $dt->format('j n Y G'),
                '%d %d %d %d'
            );

            while ($result === false) {
                list($minute, $hour, $day, $month, $year, $weekday) = sscanf(
                    $dt->format('i G j n Y w'),
                    '%d %d %d %d %d %d'
                );

                if ($pyear !== $year) {
                    $dt->setDate($year, 1, 1);
                    $dt->setTime(0, 0);
                } elseif ($pmonth !== $month) {
                    $dt->setDate($year, $month, 1);
                    $dt->setTime(0, 0);
                } elseif ($pday !== $day) {
                    $dt->setTime(0, 0);
                } elseif ($phour !== $hour) {
                    $dt->setTime($hour, 0);
                }

                list($pday, $pmonth, $pyear, $phour) = [$day, $month, $year, $hour];

                if (isset($this->registers[3][$month]) === false) {
                    $dt->modify('+1 month');
                    continue;
                } elseif (false === (isset($this->registers[2][$day]) && isset($this->registers[4][$weekday]))) {
                    $dt->modify('+1 day');
                    continue;
                } elseif (isset($this->registers[1][$hour]) === false) {
                    $dt->modify('+1 hour');
                    continue;
                } elseif (isset($this->registers[0][$minute]) === false) {
                    $dt->modify('+1 minute');
                    continue;
                }

                $result = $dt->getTimestamp();
            }
        }

        return $result;
    }

    /**
     * Parse cron expression and return expression parsed into matchable registers
     *
     * @return array
     * @throws \Exception
     */
    private function parse()
    {
        $registers = [];

        if (sizeof($segments = preg_split('/\s+/', $this->expression)) === 5) {
            foreach ($segments as $index => $segment) {
                $this->parseSegment($index, $segment, $registers);
            }

            if (isset($registers[4][7])) {
                $registers[4][0] = true;
            }
        } else {
            throw new \Exception('invalid number of segments');
        }

        return $registers;
    }

    /**
     * @param int $index
     * @param string $segment
     * @param array $registers
     * @throws \Exception
     */
    private function parseSegment($index, $segment, &$registers)
    {
        $minv = [0, 0, 1, 1, 0];
        $maxv = [59, 23, 31, 12, 7];
        $strv = [false, false, false, self::$months, self::$weekdays];

        // month names, weekdays
        if ($strv[$index] !== false && isset($strv[$index][strtolower($segment)])) {
            // cannot be used with lists or ranges, see crontab(5) man page
            $registers[$index][$strv[$index][strtolower($segment)]] = true;
        } else {
            // split up list into segments (e.g. "1,3-5,9")
            foreach (explode(',', $segment) as $listsegment) {
                // parse stepping notation
                if (strpos($listsegment, '/') !== false) {
                    if (sizeof($stepsegments = explode('/', $listsegment)) === 2) {
                        $listsegment = $stepsegments[0];

                        if (is_numeric($stepsegments[1])) {
                            if ($stepsegments[1] > 0 && $stepsegments[1] <= $maxv[$index]) {
                                $steps = intval($stepsegments[1]);
                            } else {
                                throw new \Exception('stepping value out of allowed range');
                            }
                        } else {
                            throw new \Exception('non-numeric stepping notation');
                        }
                    } else {
                        throw new \Exception('invalid stepping notation');
                    }
                } else {
                    $steps = 1;
                }

                // single value
                if (is_numeric($listsegment)) {
                    if (intval($listsegment) < $minv[$index] || intval($listsegment) > $maxv[$index]) {
                        throw new \Exception('value out of allowed range');
                    }

                    if ($steps !== 1) {
                        throw new \Exception('invalid combination of value and stepping notation');
                    }

                    $registers[$index][intval($listsegment)] = true;
                } else {
                    // asterisk indicates full range of values
                    if ($listsegment === '*') {
                        $listsegment = sprintf('%d-%d', $minv[$index], $maxv[$index]);
                    }

                    // range of values, e.g. "9-17"
                    if (strpos($listsegment, '-') !== false) {
                        if (sizeof($ranges = explode('-', $listsegment)) !== 2) {
                            throw new \Exception('invalid range notation');
                        }

                        // validate range
                        foreach ($ranges as $range) {
                            if (is_numeric($range)) {
                                if (intval($range) < $minv[$index] || intval($range) > $maxv[$index]) {
                                    throw new \Exception('invalid range start or end value');
                                }
                            } else {
                                throw new \Exception('non-numeric range notation');
                            }
                        }

                        // fill matching register
                        if ($ranges[0] === $ranges[1]) {
                            $registers[$index][$ranges[0]] = true;
                        } else {
                            for ($i = $minv[$index]; $i <= $maxv[$index]; $i++) {
                                if (($i - $ranges[0]) % $steps === 0) {
                                    if ($ranges[0] < $ranges[1]) {
                                        if ($i >= $ranges[0] && $i <= $ranges[1]) {

                                            $registers[$index][$i] = true;
                                        }
                                    } elseif ($i >= $ranges[0] || $i <= $ranges[1]) {

                                        $registers[$index][$i] = true;
                                    }
                                }
                            }
                        }
                    } else {
                        throw new \Exception('failed to parse list segment');
                    }
                }
            }
        }
    }
}


1		<?php
2
3		/**
4		* Cron expression parser and validator
5		*
6		* @author René Pollesch
7		*/
8		class Cron
		0 ignored issues – show Coding Style Compatibility introduced 2016-06-11 10:57 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9		{
10		/**
11		* Weekday look-up table
12		*
13		* @var array
14		*/
15		protected static $weekdays = [
16		'sun' => 0,
17		'mon' => 1,
18		'tue' => 2,
19		'wed' => 3,
20		'thu' => 4,
21		'fri' => 5,
22		'sat' => 6
23		];
24
25		/**
26		* Month name look-up table
27		*
28		* @var array
29		*/
30		protected static $months = [
31		'jan' => 1,
32		'feb' => 2,
33		'mar' => 3,
34		'apr' => 4,
35		'may' => 5,
36		'jun' => 6,
37		'jul' => 7,
38		'aug' => 8,
39		'sep' => 9,
40		'oct' => 10,
41		'nov' => 11,
42		'dec' => 12
43		];
44
45		/**
46		* Cron expression
47		*
48		* @var string
49		*/
50		protected $expression;
51
52		/**
53		* Time zone
54		*
55		* @var \DateTimeZone
56		*/
57		protected $timeZone;
58
59		/**
60		* Matching register
61		*
62		* @var array\|null
63		*/
64		protected $registers;
65
66		/**
67		* Class constructor sets cron expression property
68		*
69		* @param string $expression cron expression
70		* @param \DateTimeZone $timeZone
71		*/
72		public function __construct($expression = '* * * * *', \DateTimeZone $timeZone = null)
73		{
74		$this->setExpression($expression);
75		$this->setTimeZone($timeZone);
76		}
77
78		/**
79		* Set expression
80		*
81		* @param string $expression
82		* @return self
83		*/
84		public function setExpression($expression)
85		{
86		$this->expression = trim((string)$expression);
87		$this->registers = null;
88
89		return $this;
90		}
91
92		/**
93		* Set time zone
94		*
95		* @param \DateTimeZone $timeZone
96		* @return self
97		*/
98		public function setTimeZone(\DateTimeZone $timeZone = null)
99		{
100		$this->timeZone = $timeZone;
101		return $this;
102		}
103
104		/**
105		* Parse and validate cron expression
106		*
107		* @return bool true if expression is valid, or false on error
108		*/
109		public function isValid()
110		{
111		$result = true;
112
113		if ($this->registers === null) {
114		try {
115		$this->registers = $this->parse();
116		} catch (\Exception $e) {
117		$result = false;
118		}
119		}
120
121		return $result;
122		}
123
124		/**
125		* Match current or given date/time against cron expression
126		*
127		* @param mixed $dtime \DateTime object, timestamp or null
128		* @return bool
129		*/
130		public function isMatching($dtime = null)
131		{
132		if ($dtime instanceof \DateTime) {
133		$dtime->setTimezone($this->timeZone);
134		} else {
135		$dt = new \DateTime('now', $this->timeZone);
136
137		if ((int)$dtime > 0) {
138		$dt->setTimestamp($dtime);
139		}
140
141		$dtime = $dt;
142		}
143
144		$segments = sscanf($dtime->format('i G j n w'), '%d %d %d %d %d');
145
146		try {
147		$result = true;
148
149		foreach ($this->parse() as $i => $item) {
150		if (isset($item[(int)$segments[$i]]) === false) {
151		$result = false;
152		break;
153		}
154		}
155		} catch (\Exception $e) {
156		$result = false;
157		}
158
159		return $result;
160		}
161
162		/**
163		* Calculate next matching timestamp
164		*
165		* @param mixed $dtime \DateTime object, timestamp or null
166		* @return int\|bool next matching timestamp, or false on error
167		*/
168		public function getNext($dtime = null)
169		{
170		$result = false;
171
172		if ($this->isValid()) {
173		if ($dtime instanceof \DateTime) {
174		$timestamp = $dtime->getTimestamp();
175		} elseif ((int)$dtime > 0) {
176		$timestamp = $dtime;
177		} else {
178		$timestamp = time();
179		}
180
181		$dt = new \DateTime('now', $this->timeZone);
182		$dt->setTimestamp(ceil($timestamp / 60) * 60);
183
184		list($pday, $pmonth, $pyear, $phour) = sscanf(
185		$dt->format('j n Y G'),
186		'%d %d %d %d'
187		);
188
189		while ($result === false) {
190		list($minute, $hour, $day, $month, $year, $weekday) = sscanf(
191		$dt->format('i G j n Y w'),
192		'%d %d %d %d %d %d'
193		);
194
195		if ($pyear !== $year) {
196		$dt->setDate($year, 1, 1);
197		$dt->setTime(0, 0);
198		} elseif ($pmonth !== $month) {
199		$dt->setDate($year, $month, 1);
200		$dt->setTime(0, 0);
201		} elseif ($pday !== $day) {
202		$dt->setTime(0, 0);
203		} elseif ($phour !== $hour) {
204		$dt->setTime($hour, 0);
205		}
206
207		list($pday, $pmonth, $pyear, $phour) = [$day, $month, $year, $hour];
208
209		if (isset($this->registers[3][$month]) === false) {
210		$dt->modify('+1 month');
211		continue;
212		} elseif (false === (isset($this->registers[2][$day]) && isset($this->registers[4][$weekday]))) {
213		$dt->modify('+1 day');
214		continue;
215		} elseif (isset($this->registers[1][$hour]) === false) {
216		$dt->modify('+1 hour');
217		continue;
218		} elseif (isset($this->registers[0][$minute]) === false) {
219		$dt->modify('+1 minute');
220		continue;
221		}
222
223		$result = $dt->getTimestamp();
224		}
225		}
226
227		return $result;
228		}
229
230		/**
231		* Parse cron expression and return expression parsed into matchable registers
232		*
233		* @return array
234		* @throws \Exception
235		*/
236		private function parse()
237		{
238		$registers = [];
239
240		if (sizeof($segments = preg_split('/\s+/', $this->expression)) === 5) {
241		foreach ($segments as $index => $segment) {
242		$this->parseSegment($index, $segment, $registers);
243		}
244
245		if (isset($registers[4][7])) {
246		$registers[4][0] = true;
247		}
248		} else {
249		throw new \Exception('invalid number of segments');
250		}
251
252		return $registers;
253		}
254
255		/**
256		* @param int $index
257		* @param string $segment
258		* @param array $registers
259		* @throws \Exception
260		*/
261		private function parseSegment($index, $segment, &$registers)
262		{
263		$minv = [0, 0, 1, 1, 0];
264		$maxv = [59, 23, 31, 12, 7];
265		$strv = [false, false, false, self::$months, self::$weekdays];
266
267		// month names, weekdays
268		if ($strv[$index] !== false && isset($strv[$index][strtolower($segment)])) {
269		// cannot be used with lists or ranges, see crontab(5) man page
270		$registers[$index][$strv[$index][strtolower($segment)]] = true;
271		} else {
272		// split up list into segments (e.g. "1,3-5,9")
273		foreach (explode(',', $segment) as $listsegment) {
274		// parse stepping notation
275		if (strpos($listsegment, '/') !== false) {
276		if (sizeof($stepsegments = explode('/', $listsegment)) === 2) {
277		$listsegment = $stepsegments[0];
278
279		if (is_numeric($stepsegments[1])) {
280		if ($stepsegments[1] > 0 && $stepsegments[1] <= $maxv[$index]) {
281		$steps = intval($stepsegments[1]);
282		} else {
283		throw new \Exception('stepping value out of allowed range');
284		}
285		} else {
286		throw new \Exception('non-numeric stepping notation');
287		}
288		} else {
289		throw new \Exception('invalid stepping notation');
290		}
291		} else {
292		$steps = 1;
293		}
294
295		// single value
296		if (is_numeric($listsegment)) {
297		if (intval($listsegment) < $minv[$index] \|\| intval($listsegment) > $maxv[$index]) {
298		throw new \Exception('value out of allowed range');
299		}
300
301		if ($steps !== 1) {
302		throw new \Exception('invalid combination of value and stepping notation');
303		}
304
305		$registers[$index][intval($listsegment)] = true;
306		} else {
307		// asterisk indicates full range of values
308		if ($listsegment === '*') {
309		$listsegment = sprintf('%d-%d', $minv[$index], $maxv[$index]);
310		}
311
312		// range of values, e.g. "9-17"
313		if (strpos($listsegment, '-') !== false) {
314		if (sizeof($ranges = explode('-', $listsegment)) !== 2) {
315		throw new \Exception('invalid range notation');
316		}
317
318		// validate range
319		foreach ($ranges as $range) {
320		if (is_numeric($range)) {
321		if (intval($range) < $minv[$index] \|\| intval($range) > $maxv[$index]) {
322		throw new \Exception('invalid range start or end value');
323		}
324		} else {
325		throw new \Exception('non-numeric range notation');
326		}
327		}
328
329		// fill matching register
330		if ($ranges[0] === $ranges[1]) {
331		$registers[$index][$ranges[0]] = true;
332		} else {
333		for ($i = $minv[$index]; $i <= $maxv[$index]; $i++) {
334		if (($i - $ranges[0]) % $steps === 0) {
335		if ($ranges[0] < $ranges[1]) {
336	View Code Duplication	if ($i >= $ranges[0] && $i <= $ranges[1]) {
		0 ignored issues – show Duplication introduced 2016-06-11 10:57 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
337		$registers[$index][$i] = true;
338		}
339	View Code Duplication	} elseif ($i >= $ranges[0] \|\| $i <= $ranges[1]) {
		0 ignored issues – show Duplication introduced 2016-06-11 10:57 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
340		$registers[$index][$i] = true;
341		}
342		}
343		}
344		}
345		} else {
346		throw new \Exception('failed to parse list segment');
347		}
348		}
349		}
350		}
351		}
352		}
353

poliander / cron