Departements\Datasource\AbstractDatasource

Complexity

Total Complexity

16

Size/Duplication

Total Lines	94
Duplicated Lines	23.4 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes	8
Bugs	2	Features	4

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	slugify()	0	7	1
A	addToIndex()	0	3	1
A	findAllDepartements()	0	7	2
A	findAllRegions()	0	7	2
A	findAllCommunes()	0	3	1
A	findCommunesByZipcode()	0	3	1
A	findDepartementByCode()	0	3	1
A	findDepartementByName()	11	11	2
A	findRegionByName()	11	11	2
A	findRegionByCode()	0	3	1
A	sortByValue()	0	8	1

<?php

namespace Departements\Datasource;

use PhpCollection\Map;

abstract class AbstractDatasource implements DatasourceInterface
{
    protected $regions;
    protected $departements;
    protected $index;

    public function __construct() {
        $this->regions      = new Map();
        $this->departements = new Map();
        $this->communes     = new Map();

The property communes does not exist. Did you maybe forget to declare it?

        $this->index = array(
            'departements' => array(),
            'regions'      => array(),
            'communes'     => array()
        );
    }

    protected function slugify($value) {
        $orginalLocale = setlocale(LC_ALL, 0);
        setlocale(LC_ALL, "en_US.utf8");
        $value = strtolower(iconv('UTF-8', 'ASCII//TRANSLIT', $value));
        setlocale(LC_ALL, $orginalLocale);
        return preg_replace("/[^a-z0-9]/", "", $value);
    }

    protected function addToIndex($type, $value, $key) {
        $this->index[$type][$this->slugify($value)] = $key;
    }

    public function findAllDepartements($sortByValue = false) {
        if (!$sortByValue) {
            return $this->departements;
        }

        return $this->sortByValue($this->departements);
    }

    public function findAllRegions($sortByValue = false) {
        if (!$sortByValue) {
            return $this->regions;
        }

        return $this->sortByValue($this->regions);
    }

    public function findAllCommunes() {
        return $this->communes;
    }

    public function findCommunesByZipcode($zipcode) {
       return $this->communes->get($zipcode)->get();
    }

    public function findDepartementByCode($departementCode) {
        return $this->departements->get($departementCode)->getOrElse(null);
    }

    public function findDepartementByName($departementName) {

This method seems to be duplicated in your project.

        $departementName = $this->slugify($departementName);

        if(!isset($this->index['departements'][$departementName])) {
            return null;
        }

        $departementCode = $this->index['departements'][$departementName];

        return $this->departements->get($departementCode)->get();
    }

    public function findRegionByName($regionName) {

This method seems to be duplicated in your project.

        $regionName = $this->slugify($regionName);

        if(!isset($this->index['regions'][$regionName])) {
            return null;
        }

        $regionCode = $this->index['regions'][$regionName];

        return $this->regions->get($regionCode)->get();
    }

    public function findRegionByCode($regionCode) {
        return $this->regions->get($regionCode)->getOrElse(null);
    }

    protected function sortByValue($collection) {
        $collator = new \Collator('fr_FR');

        $items = iterator_to_array($collection);
        $collator->asort($items);

        return new Map($items);
    }
}