+global\PodsAdmin::configuration()

Complexity

Conditions	13
Paths	28

Size

Total Lines	59
Code Lines	32

Duplication

Lines	0
Ratio	0 %

<?php
	function configuration( $pod = null, $full_field_info = false ){

It is generally recommended to explicitly declare the visibility for methods.

		$api = pods_api();

		if ( is_null( $pod ) ) {

As per coding-style, please use === null instead of is_null.

			$the_pods = $api->load_pods();
		}
		elseif( is_array( $pod ) ) {
			foreach ( $pod as $p ) {
				$the_pods[] = $api->load_pod( $p );

$the_pods was never initialized. Although not strictly required by PHP, it is generally a good practice to add $the_pods = array(); before regardless.

			}
		}
		else {
			$the_pods[] = $api->load_pod( $pod );

$the_pods was never initialized. Although not strictly required by PHP, it is generally a good practice to add $the_pods = array(); before regardless.

		}

		foreach( $the_pods as $pod ) {

The variable $the_pods does not seem to be defined for all execution paths leading up to this point.

The expression $the_pods of type array|object|integer|double|string|null|boolean is not guaranteed to be traversable. How about adding an additional type check?

			$configuration[ $pod[ 'name' ] ] = array(

$configuration was never initialized. Although not strictly required by PHP, it is generally a good practice to add $configuration = array(); before regardless.

				'name' 		=> $pod['name'],
				'ID' 		=> $pod[ 'id' ],
				'storage' 	=> $pod[ 'storage' ],
				'fields' 	=> $pod[ 'fields' ],
			);
		}

		if ( ! $full_field_info ) {
			foreach ( $the_pods as $pod ) {

The expression $the_pods of type array|object|integer|double|string|null|boolean is not guaranteed to be traversable. How about adding an additional type check?

				$fields = $configuration[ $pod['name'] ][ 'fields' ];

The variable $configuration does not seem to be defined for all execution paths leading up to this point.

				unset( $configuration[ $pod['name'] ][ 'fields' ] );
				foreach ( $fields as $field ) {
					$info = array (
						'name' => $field[ 'name' ],
						'type' => $field[ 'type' ],
					);

					if ( $info[ 'type' ]  === 'pick' ) {
						$info[ 'pick_object' ] = $field[ 'pick_object' ];
						if ( isset ( $field[ 'pick_val' ] ) && $field[ 'pick_val' ] !== '' ) {
							$info[ 'pick_val' ] = $field[ 'pick_val' ];
						}
					}

					if ( is_array( $info ) ) {
						$configuration[ $pod[ 'name' ] ][ 'fields' ][ $field[ 'name' ] ] = $info;
					}

					unset( $info );

				}

			}

		}

		if ( is_array ( $configuration ) ) {
			return $configuration;

		}

	}