podlove / podlove-subscribe-button-wp-plugin

settings/buttons_list_table.php

<?php

Filenames should be all lowercase with hyphens as word separators. Expected buttons-list-table.php, but found buttons_list_table.php.

Class file names should be based on the class name with "class-" prepended. Expected class-button-list-table.php, but found buttons_list_table.php.

This file is missing a doc comment.

namespace PodloveSubscribeButton;

if( ! class_exists( 'WP_List_Table' ) ){

Space after opening control structure is required

No space before opening parenthesis is prohibited

Space between opening control structure and closing parenthesis is required

Expected 1 space after IF keyword; 0 found

    require_once( ABSPATH . 'wp-admin/includes/class-wp-list-table.php' );

"require_once" is a statement not a function; no parentheses are required

}

class Button_List_Table extends \WP_List_Table {

Class name "Button_List_Table" is not in PascalCase format

Missing doc comment for class Button_List_Table

	function __construct(){

Missing doc comment for function __construct()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for __construct.

Expected 1 space before opening brace; found 0

		global $status, $page;

		// Set parent defaults

Inline comments must end in full-stops, exclamation marks, or question marks

		parent::__construct( array(

The opening parenthesis of a multi-line function call should be the last content on the line.

		    'singular'  => 'feed',   // singular name of the listed records

Inline comments must end in full-stops, exclamation marks, or question marks

Array double arrow not aligned correctly; expected 1 space(s) between "'singular'" and double arrow, but found 2.

		    'plural'    => 'feeds',  // plural name of the listed records

Inline comments must end in full-stops, exclamation marks, or question marks

Array double arrow not aligned correctly; expected 3 space(s) between "'plural'" and double arrow, but found 4.

		    'ajax'      => false  // does this table support ajax?

Array double arrow not aligned correctly; expected 5 space(s) between "'ajax'" and double arrow, but found 6.

Each array item in a multi-line array declaration must end in a comma

		) );

For multi-line function calls, the closing parenthesis should be on a new line.

	}

Expected 1 blank line before closing function brace; 0 found

	function column_name( $button ) {

Missing doc comment for function column_name()

It is generally recommended to explicitly declare the visibility for methods.

Method name "Button_List_Table::column_name" is not in camel caps format

It is recommend to declare an explicit visibility for column_name.

		$actions = array(
			'edit'   => Settings\Buttons::get_action_link( $button, __( 'Edit', 'podlove-subscribe-button' ), 'edit' ),
			'delete' => Settings\Buttons::get_action_link( $button, __( 'Delete', 'podlove-subscribe-button' ), 'confirm_delete' )

Each array item in a multi-line array declaration must end in a comma

		);

		return sprintf('%1$s %2$s',

The opening parenthesis of a multi-line function call should be the last content on the line.

		    /*$1%s*/ sanitize_title($button->title) . '<br><code>[podlove-subscribe-button button="' . sanitize_text_field($button->name) . '"]</code>',

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

		    /*$3%s*/ $this->row_actions( $actions )
		);
	}

Expected 1 blank line before closing function brace; 0 found

	function column_button_preview( $button ) {

Missing doc comment for function column_button_preview()

It is generally recommended to explicitly declare the visibility for methods.

Method name "Button_List_Table::column_button_preview" is not in camel caps format

It is recommend to declare an explicit visibility for column_button_preview.

		if ( ! $button->feeds ) {
			return '<code>' . __( 'No preview. Please set a feed.', 'podlove-subscribe-button' ) . '</code>';
		} else {

			$preview = "<div class='podlove-button-preview-container'>";

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

			$preview .= $button->render(
				'big',
				'false',
				get_option( 'podlove_subscribe_button_default_style', 'filled' ),
				'rectangle'
			);
			$preview .= "</div>";

The string literal </div> does not require double quotes, as per coding-style, please use single quotes.

			return $preview;

		}

	}


	function column_id( $button ) {

It is generally recommended to explicitly declare the visibility for methods.

Method name "Button_List_Table::column_id" is not in camel caps format

Missing doc comment for function column_id()

It is recommend to declare an explicit visibility for column_id.

		return $button->id;
	}

Expected 1 blank line before closing function brace; 0 found

	function get_columns(){

It is generally recommended to explicitly declare the visibility for methods.

Method name "Button_List_Table::get_columns" is not in camel caps format

Missing doc comment for function get_columns()

It is recommend to declare an explicit visibility for get_columns.

Expected 1 space before opening brace; found 0

		return array(
			'name'    => __( 'Title & Shortcode', 'podlove-subscribe-button' ),

Array double arrow not aligned correctly; expected 11 space(s) between "'name'" and double arrow, but found 4.

			'button_preview'    => __( 'Preview', 'podlove-subscribe-button' ),

Array double arrow not aligned correctly; expected 1 space(s) between "'button_preview'" and double arrow, but found 4.

		);
	}

Expected 1 blank line before closing function brace; 0 found

	function prepare_items() {

It is generally recommended to explicitly declare the visibility for methods.

Method name "Button_List_Table::prepare_items" is not in camel caps format

Missing doc comment for function prepare_items()

It is recommend to declare an explicit visibility for prepare_items.

		// number of items per page

Inline comments must end in full-stops, exclamation marks, or question marks

		$per_page = 1000;

		// define column headers

Inline comments must end in full-stops, exclamation marks, or question marks

		$columns = $this->get_columns();

Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space

		$hidden = array();

Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space

		$sortable = $this->get_sortable_columns();

Equals sign not aligned with surrounding assignments; expected 14 spaces but found 1 space

		$this->_column_headers = array( $columns, $hidden, $sortable );

		// retrieve data
		// TODO select data for current page only

Inline comments must end in full-stops, exclamation marks, or question marks

		$data = ( is_network_admin() ? \PodloveSubscribeButton\Model\NetworkButton::all() : \PodloveSubscribeButton\Model\Button::all() );

		// get current page

Inline comments must end in full-stops, exclamation marks, or question marks

		$current_page = $this->get_pagenum();
		// get total items

Inline comments must end in full-stops, exclamation marks, or question marks

		$total_items = count( $data );
		// extrage page for current page only

Inline comments must end in full-stops, exclamation marks, or question marks

		$data = array_slice( $data, ( ( $current_page - 1 ) * $per_page ) , $per_page );

Space found before comma in argument list

		// add items to table

Inline comments must end in full-stops, exclamation marks, or question marks

		$this->items = $data;

		// register pagination options & calculations

Inline comments must end in full-stops, exclamation marks, or question marks

		$this->set_pagination_args( array(

The opening parenthesis of a multi-line function call should be the last content on the line.

		    'total_items' => $total_items,
		    'per_page'    => $per_page,
		    'total_pages' => ceil( $total_items / $per_page )

Each array item in a multi-line array declaration must end in a comma

		) );

For multi-line function calls, the closing parenthesis should be on a new line.

	}

Expected 1 blank line before closing function brace; 0 found

}