podlove / podlove-subscribe-button-wp-plugin

js/admin.js

(function($) {

This file is missing a doc comment.

    var entityMap = {
      '&': '&',

Found precision alignment of 2 spaces.

      '<': '&lt;',

Found precision alignment of 2 spaces.

      '>': '>',

Found precision alignment of 2 spaces.

      '"': '"',

Found precision alignment of 2 spaces.

      "'": ''',

Found precision alignment of 2 spaces.

      '/': '/',

Found precision alignment of 2 spaces.

      '`': '`',

Found precision alignment of 2 spaces.

      '=': '='

Found precision alignment of 2 spaces.

    };
    
    function escapeHtml(string) {
      return String(string).replace(/[&<>"'`=\/]/g, function (s) {

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

Found precision alignment of 2 spaces.

Opening statement of multi-line function call not indented correctly; expected 4 spaces but found 6

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

        return entityMap[s];

This line of the multi-line function call does not seem to be indented correctly. Expected 10 spaces, but found 8.

      });

For multi-line function calls, the closing parenthesis should be on a new line.

Found precision alignment of 2 spaces.

    }

	function podlove_init_color_buttons() {
        jQuery(document).ready( function($) {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

            var params = {
                change: function(e, ui) {
                    $( e.target ).val( ui.color.toString() );
                    $( e.target ).trigger('change'); // enable widget "Save" button

Inline comments must end in full-stops, exclamation marks, or question marks

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

                },
            }

            $('.podlove_subscribe_button_color').not('[id*="__i__"]').wpColorPicker( params );

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

        })

For multi-line function calls, the closing parenthesis should be on a new line.

	}

	$( document ).ready( function() {

The opening parenthesis of a multi-line function call should be the last content on the line.

		$("#Podlove_cover_image_select").on( 'click', function(event) {

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

The parameter event is not used and could be removed.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			podlove_cover_image_selector = wp.media.frames.customHeader = wp.media( {

The opening parenthesis of a multi-line function call should be the last content on the line.

The variable wp seems to be never declared. If this is a global, consider adding a /** global: wp */ comment.

The variable podlove_cover_image_selector seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.podlove_cover_image_selector.

					title: i18n.media_library,

The variable i18n seems to be never declared. If this is a global, consider adding a /** global: i18n */ comment.

					library: {
						type: 'image'
					},
					button: {
						text: i18n.use_for
			   		},
			   		multiple: false
			    } );

For multi-line function calls, the closing parenthesis should be on a new line.

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

			podlove_cover_image_selector.open();

			podlove_cover_image_selector.on('select', function() {

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

				var podcast_image_url = podlove_cover_image_selector.state().get('selection').first().toJSON().url;

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

				$("#podlove-button-cover").val(podcast_image_url);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

				$("#podlove-button-cover").trigger('change');

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			});

For multi-line function calls, the closing parenthesis should be on a new line.

		} );

For multi-line function calls, the closing parenthesis should be on a new line.

		$(document).ready(function () {

The opening parenthesis of a multi-line function call should be the last content on the line.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

		    podlove_init_color_buttons();

		    jQuery(document).on('widget-updated', podlove_init_color_buttons);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

		    jQuery(document).on('widget-added', podlove_init_color_buttons);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

		    // re-init after saving configs

Inline comments must end in full-stops, exclamation marks, or question marks

		    jQuery(document).on('ajaxComplete', function(e){

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

The parameter e is not used and could be removed.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

		        podlove_init_color_buttons();
		    });

For multi-line function calls, the closing parenthesis should be on a new line.

		})

For multi-line function calls, the closing parenthesis should be on a new line.

		var feed_counter = 0;
		var source = $("#feed_line_template").html();

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

		$(".add_feed").on( 'click', function () {

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			add_new_feed();
		} );

For multi-line function calls, the closing parenthesis should be on a new line.

		if ( window.feeds !== undefined ) {
			$.each( feeds, function (index, feed) {

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

The variable feeds seems to be never declared. If this is a global, consider adding a /** global: feeds */ comment.

				add_existing_feed(feed);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			} );

For multi-line function calls, the closing parenthesis should be on a new line.

		}

		function add_new_feed() {
			row = source.replace( /\{\{url\}\}/g, '' );

The variable row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.row.

			row = row.replace( /\{\{itunesfeedid\}\}/g, '' );
			row = row.replace( /\{\{id\}\}/g, feed_counter );

			$("#feeds_table_body").append(row);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			new_row = $("#feeds_table_body tr:last");

The variable new_row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.new_row.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			new_row.find("input:first").focus();

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			$(".podlove-icon-remove").on( 'click', function () {

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

				$(this).closest("tr").remove();

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			} );

For multi-line function calls, the closing parenthesis should be on a new line.

			feed_counter++;
		}

		function add_existing_feed( feed ) {
			row = source.replace( /\{\{url\}\}/g, escapeHtml(feed.url) );

The variable row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.row.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			row = row.replace( /\{\{id\}\}/g, feed_counter );
			if ( feed.itunesfeedid == null ) {

Comparing feed.itunesfeedid to null using the == operator is not safe. Consider using === instead.

				row = row.replace( /\{\{itunesfeedid\}\}/g, '' );
			} else {
				row = row.replace( /\{\{itunesfeedid\}\}/g, escapeHtml(feed.itunesfeedid) );

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			}

			$("#feeds_table_body").append(row);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			new_row = $("#feeds_table_body tr:last");

The variable new_row seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.new_row.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			new_row.find('select.podlove-media-format option[value="' + escapeHtml(feed.format) + '"]').attr('selected',true);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			$(".podlove-icon-remove").on( 'click', function () {

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

The opening parenthesis of a multi-line function call should be the last content on the line.

For multi-line function calls, each argument should be on a separate line.

				$(this).closest("tr").remove();

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

			} );

For multi-line function calls, the closing parenthesis should be on a new line.

			feed_counter++;
		}

	} );

Expected 0 blank lines before closing brace of nested function; 1 found

For multi-line function calls, the closing parenthesis should be on a new line.

}(jQuery));