Defaults::options() - Code Metrics - Inspection of "refine syntax" - podlove/podlove-subscribe-button-wp-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 78b81a...d0a974 )

by Christian

created 2018-09-12 23:11 UTC

Defaults::options() A

↳ Parent: Defaults

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	8
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	12
rs	10

<?php

/**

 * @author    Podlove <[email protected]>
 * @copyright Copyright (c) 2014-2018, Podlove
 * @license   https://github.com/podlove/podlove-subscribe-button-wp-plugin/blob/master/LICENSE MIT
 * @package   Podlove\PodloveSubscribeButton
 */

namespace PodloveSubscribeButton;

class Defaults {


	static function button( $property ) {


		$style = array(
			'filled'    => __( 'Filled', 'podlove-subscribe-button' ),
			'outline'   => __( 'Outline', 'podlove-subscribe-button' ),
			'frameless' => __( 'Frameless', 'podlove-subscribe-button' ),
		);

		$format = array(
			'rectangle' => __( 'Rectangle', 'podlove-subscribe-button' ),
			'square'    => __( 'Square', 'podlove-subscribe-button' ),
			'cover'     => __( 'Cover', 'podlove-subscribe-button' ),
		);

		$width = array(
			'on'  => __( 'Yes', 'podlove-subscribe-button' ),
			'off' => __( 'No', 'podlove-subscribe-button' ),
		);

		$size = array(
			'small'  => __( 'Small', 'podlove-subscribe-button' ),
			'medium' => __( 'Medium', 'podlove-subscribe-button' ),
			'big'    => __( 'Big', 'podlove-subscribe-button' ),
		);

		$language = array( 'de', 'en', 'eo', 'fi', 'fr', 'nl', 'zh', 'ja', );


		return $$property;

	}

	/**

	 * @return array
	 */
	public static function media_types() {


		$media_types = array(
			0 => array(
				'title'     => 'MP3 audio',
				'mime_type' => 'audio/mpeg',
				'extension' => 'mp3',
			),
			1 => array(
				'title'     => 'MPEG-4 AAC Audio',
				'mime_type' => 'audio/mp4',
				'extension' => 'aac',
			),
			2 => array(
				'title'     => 'MPEG-4 ALAC Audio',
				'mime_type' => 'audio/mp4',
				'extension' => 'aac',
			),
			3 => array(
				'title'     => 'Ogg Vorbis Audio',
				'mime_type' => 'audio/ogg',
				'extension' => 'ogg',
			),
			4 => array(
				'title'     => 'WebM Audio',
				'mime_type' => 'audio/webm',
				'extension' => 'webm',
			),
			5 => array(
				'title'     => 'FLAC Audio',
				'mime_type' => 'audio/flac',
				'extension' => 'flac',
			),
			6 => array(
				'title'     => 'Matroska Audio',
				'mime_type' => 'audio/x-matroska',
				'extension' => 'mka',
			),
			7 => array(
				'title'     => 'Opus Audio',
				'mime_type' => 'audio/opus',
				'extension' => 'opus',
			)

		);

		return apply_filters( 'podlove_subscribe_button_defaults_media_types', $media_types );

	}

	static function options() {


		$options = array(
			'size'      => 'big',
			'autowidth' => 'on',
			'color'     => '#599677',
			'style'     => 'filled',
			'format'    => 'rectangle',
			'language'  => \PodloveSubscribeButton\Helpers::language( '' ),
		);

		return apply_filters( 'podlove_subscribe_button_defaults_options', $options );

	}

} // END class


1			<?php
			0 ignored issues – show introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Filenames should be all lowercase with hyphens as word separators. Expected defaults.php, but found Defaults.php. Loading history... introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Class file names should be based on the class name with "class-" prepended. Expected class-defaults.php, but found Defaults.php. Loading history...
2			/**
			0 ignored issues – show Coding Style introduced 2018-09-04 17:18 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
3			* @author Podlove <[email protected]>
4			* @copyright Copyright (c) 2014-2018, Podlove
5			* @license https://github.com/podlove/podlove-subscribe-button-wp-plugin/blob/master/LICENSE MIT
6			* @package Podlove\PodloveSubscribeButton
7			*/
8
9			namespace PodloveSubscribeButton;
10
11			class Defaults {
			0 ignored issues – show Coding Style Documentation introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Missing doc comment for class Defaults Loading history...
12
13			static function button( $property ) {
			0 ignored issues – show Best Practice introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style Documentation introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Missing doc comment for function button() Loading history... Comprehensibility Best Practice introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report It is recommend to declare an explicit visibility for `button`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
14
15			$style = array(
16			'filled' => __( 'Filled', 'podlove-subscribe-button' ),
17			'outline' => __( 'Outline', 'podlove-subscribe-button' ),
18			'frameless' => __( 'Frameless', 'podlove-subscribe-button' ),
19			);
20
21			$format = array(
22			'rectangle' => __( 'Rectangle', 'podlove-subscribe-button' ),
23			'square' => __( 'Square', 'podlove-subscribe-button' ),
24			'cover' => __( 'Cover', 'podlove-subscribe-button' ),
25			);
26
27			$width = array(
28			'on' => __( 'Yes', 'podlove-subscribe-button' ),
29			'off' => __( 'No', 'podlove-subscribe-button' ),
30			);
31
32			$size = array(
33			'small' => __( 'Small', 'podlove-subscribe-button' ),
34			'medium' => __( 'Medium', 'podlove-subscribe-button' ),
35			'big' => __( 'Big', 'podlove-subscribe-button' ),
36			);
37
38			$language = array( 'de', 'en', 'eo', 'fi', 'fr', 'nl', 'zh', 'ja', );
			0 ignored issues – show introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Comma not allowed after last value in single-line array declaration Loading history...
39
40			return $$property;
41
42			}
43
44			/**
			0 ignored issues – show Coding Style introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
45			* @return array
46			*/
47			public static function media_types() {
			0 ignored issues – show Coding Style introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Method name "Defaults::media_types" is not in camel caps format Loading history...
48
49			$media_types = array(
50			0 => array(
51			'title' => 'MP3 audio',
52			'mime_type' => 'audio/mpeg',
53			'extension' => 'mp3',
54			),
55			1 => array(
56			'title' => 'MPEG-4 AAC Audio',
57			'mime_type' => 'audio/mp4',
58			'extension' => 'aac',
59			),
60			2 => array(
61			'title' => 'MPEG-4 ALAC Audio',
62			'mime_type' => 'audio/mp4',
63			'extension' => 'aac',
64			),
65			3 => array(
66			'title' => 'Ogg Vorbis Audio',
67			'mime_type' => 'audio/ogg',
68			'extension' => 'ogg',
69			),
70			4 => array(
71			'title' => 'WebM Audio',
72			'mime_type' => 'audio/webm',
73			'extension' => 'webm',
74			),
75			5 => array(
76			'title' => 'FLAC Audio',
77			'mime_type' => 'audio/flac',
78			'extension' => 'flac',
79			),
80			6 => array(
81			'title' => 'Matroska Audio',
82			'mime_type' => 'audio/x-matroska',
83			'extension' => 'mka',
84			),
85			7 => array(
86			'title' => 'Opus Audio',
87			'mime_type' => 'audio/opus',
88			'extension' => 'opus',
89			)
			0 ignored issues – show introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Each array item in a multi-line array declaration must end in a comma Loading history...
90			);
91
92			return apply_filters( 'podlove_subscribe_button_defaults_media_types', $media_types );
93
94			}
95
96			static function options() {
			0 ignored issues – show Best Practice introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style Documentation introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report Missing doc comment for function options() Loading history... Comprehensibility Best Practice introduced 2018-09-12 23:13 UTC by Report Bug Copy Issue Report It is recommend to declare an explicit visibility for `options`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
97
98			$options = array(
99			'size' => 'big',
100			'autowidth' => 'on',
101			'color' => '#599677',
102			'style' => 'filled',
103			'format' => 'rectangle',
104			'language' => \PodloveSubscribeButton\Helpers::language( '' ),
105			);
106
107			return apply_filters( 'podlove_subscribe_button_defaults_options', $options );
108
109			}
110
111			} // END class
112

podlove / podlove-subscribe-button-wp-plugin

GitHub Access Token became invalid

Push — master ( 78b81a...d0a974 )

Defaults::options() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like