podlove / podlove-subscribe-button-wp-plugin

widget.php

<?php

namespace PodloveSubscribeButton;

include_once( ABSPATH . 'wp-admin/includes/plugin.php' );

class Widget extends \WP_Widget {

	public function __construct() {

Missing doc comment for function __construct()

		parent::__construct(
					'podlove_subscribe_button_wp_plugin_widget',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

					( self::is_podlove_publisher_active() ? 'Podlove Subscribe Button (WordPress plugin)' : 'Podlove Subscribe Button' ),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

					array( 'description' => __( 'Adds a Podlove Subscribe Button to your Sidebar', 'podlove-subscribe-button' ),)

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

Missing space before array closer.

				);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 16.

	}

Expected 1 blank line before closing function brace; 0 found

	public static $widget_settings = array( 'infotext', 'title', 'size', 'style', 'format', 'autowidth', 'button', 'color' );

Missing member variable doc comment

	public static function is_podlove_publisher_active() {
		if ( is_plugin_active( "podlove-podcasting-plugin-for-wordpress/podlove.php" ) ) {
			return true;
		}

		return false;
	}

Expected 1 blank line before closing function brace; 0 found

	public function widget( $args, $instance ) {
		// Fetch the (network)button by it's name
		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name( $instance[ 'button' ] ) )

It is generally a best practice to always use braces with control structures.

			return sprintf( __( 'Oops. There is no button with the ID "%s".', 'podlove-subscribe-button' ), $args[ 'button' ] );

Array keys must NOT be surrounded by spaces if they only contain a string or an integer.

		echo $args[ 'before_widget' ];
		echo $args[ 'before_title' ] . apply_filters( 'widget_title', $instance[ 'title' ] ) . $args[ 'after_title' ];

		echo $button->render(
				\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'size' ),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'autowidth' ),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'style' ),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'format' ), 

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

				\PodloveSubscribeButton::get_array_value_with_fallback( $instance, 'color' )

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

			);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

		
		if ( strlen( $instance[ 'infotext' ] ) )

It is generally a best practice to always use braces with control structures.

			echo wpautop( $instance[ 'infotext' ] );

		echo $args[ 'after_widget' ];
	}	

Expected 1 blank line before closing function brace; 0 found

Spaces must be used for mid-line alignment; tabs are not allowed

	public function form( $instance ) {
		foreach ( self::$widget_settings as $setting ) {
			$$setting = isset( $instance[ $setting ] ) ? $instance[ $setting ] : '';
		}

		$buttons = \PodloveSubscribeButton\Model\Button::all();

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

		if ( is_multisite() )

It is generally a best practice to always use braces with control structures.

			$network_buttons = \PodloveSubscribeButton\Model\NetworkButton::all();

		$buttons_as_options = function( $buttons ) {
			foreach ( $buttons as $subscribebutton ) {
				echo "<option value='" . $subscribebutton->name . "' " . ( $subscribebutton->name == $button ? 'selected=\"selected\"' : '' ) . " >" . $subscribebutton->title . " (" . $subscribebutton->name . ")</option>";
			}
		}
		?>
		<p>
			<label for="<?php echo $this->get_field_id( 'title' ); ?>"><?php _e( 'Title', 'podlove-subscribe-button' ); ?></label> 
			<input class="widefat" id="<?php echo $this->get_field_id( 'title' ); ?>" name="<?php echo $this->get_field_name( 'title' ); ?>" value="<?php echo $title; ?>" />

			<label for="<?php echo $this->get_field_id( 'color' ); ?>"><?php _e( 'Color', 'podlove-subscribe-button' ); ?></label>
			<input class="podlove_subscribe_button_color" id="<?php echo $this->get_field_id( 'color' ); ?>" name="<?php echo $this->get_field_name( 'color' ); ?>" value="<?php echo $color; ?>" />
			<style type="text/css">
				.sp-replacer {
					display: flex;
				}
				.sp-preview {
					flex-grow: 10;
				}
			</style>

			<label for="<?php echo $this->get_field_id( 'button' ); ?>"><?php _e( 'Button', 'podlove-subscribe-button' ); ?></label> 
			<select class="widefat" id="<?php echo $this->get_field_id( 'button' ); ?>"
				      name="<?php echo $this->get_field_name( 'button' ); ?>">
				<?php if ( isset( $network_buttons ) && count( $network_buttons ) > 0 ) : ?>
					<optgroup label="<?php _e( 'Local', 'podlove-subscribe-button' ); ?>">
						<?php $buttons_as_options( $buttons ); ?>
					</optgroup>
					<optgroup label="<?php _e( 'Network', 'podlove-subscribe-button' ); ?>">
						<?php $buttons_as_options( $network_buttons ); ?>
					</optgroup>
				<?php else : 
					$buttons_as_options( $buttons );
				 endif; ?>
			</select>

			<?php
			$customize_options = array(
				'size'      => array(
					'name'    => __( 'Size', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$size
				),
				'style'     => array(
					'name'    => __( 'Style', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$style
				),
				'format'    => array(
					'name'    => __( 'Format', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$format
				),
				'autowidth' => array(
					'name'    => __( 'Autowidth', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$width
				)
			);

			foreach ( $customize_options as $slug => $properties ) : ?>
				<label for="<?php echo $this->get_field_id( $slug ); ?>"><?php echo $properties[ 'name' ]; ?></label>
				<select class="widefat" id="<?php echo $this->get_field_id( $slug ); ?>" name="<?php echo $this->get_field_name( $slug ); ?>">
					<option value="default" <?php echo ( $$slug == 'default' ? 'selected="selected"' : '' ); ?>><?php printf( __( 'Default %s', 'podlove-subscribe-button' ), $properties[ 'name' ] ) ?></option>
					<optgroup>
						<?php foreach ( $properties[ 'options' ] as $property => $name ) : ?>
						<option value="<?php echo $property; ?>" <?php echo ( $$slug == $property ? 'selected="selected"' : '' ); ?>><?php echo $name; ?></option>
						<?php endforeach; ?>
					</optgroup>
				</select>
			<?php endforeach; ?>
		

Found precision alignment of 1 spaces.

			<label for="<?php echo $this->get_field_id( 'infotext' ); ?>"><?php _e( 'Description', 'podlove-subscribe-button' ); ?></label> 
			<textarea class="widefat" rows="10" id="<?php echo $this->get_field_id( 'infotext' ); ?>" name="<?php echo $this->get_field_name( 'infotext' ); ?>"><?php echo $infotext; ?></textarea>
		</p>
		<?php 
	}

Expected 1 blank line before closing function brace; 0 found

	public function update( $new_instance, $old_instance ) {
		$instance = array();

		foreach ( self::$widget_settings as $setting ) {
			$instance[ $setting ] = ( ! empty( $new_instance[ $setting ] ) ) ? strip_tags( $new_instance[ $setting ] ) : '';
		}

		return $instance;
	}

Expected 1 blank line before closing function brace; 0 found

} // END class