for_every_podcast_blog() - Code Metrics - Inspection of "code style fixes" - podlove/podlove-subscribe-button-wp-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0392a4...4f7518 )

by Christian

created 2018-09-02 14:58 UTC

for_every_podcast_blog() A

↳ Parent: Project

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	10
c	0
b	0
f	0
nc	4
nop	1
dl	0
loc	16
rs	9.9332

<?php


namespace PodloveSubscribeButton;

function for_every_podcast_blog( $callback ) {


	global $wpdb;

	$plugin  = basename( \PodloveSubscribeButton\PLUGIN_DIR ) . '/' . \PodloveSubscribeButton\PLUGIN_FILE_NAME;
	$blogids = $wpdb->get_col( "SELECT blog_id FROM " . $wpdb->blogs );
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

	if ( ! is_array( $blogids ) )
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
		return;

	foreach ( $blogids as $blog_id ) {
		switch_to_blog( $blog_id );
		if ( is_plugin_active( $plugin ) ) {
			$callback();
		}
		restore_current_blog();
	}

}

1			<?php
			0 ignored issues – show Coding Style introduced 2018-09-01 15:32 UTC by Report Bug Copy Issue Report This file is missing a doc comment. Loading history...
2
3			namespace PodloveSubscribeButton;
4
5			function for_every_podcast_blog( $callback ) {
			0 ignored issues – show Coding Style Documentation introduced 2018-09-01 15:32 UTC by Report Bug Copy Issue Report Missing doc comment for function for_every_podcast_blog() Loading history...
6
7			global $wpdb;
8
9			$plugin = basename( \PodloveSubscribeButton\PLUGIN_DIR ) . '/' . \PodloveSubscribeButton\PLUGIN_FILE_NAME;
10			$blogids = $wpdb->get_col( "SELECT blog_id FROM " . $wpdb->blogs );
			0 ignored issues – show introduced 2018-09-01 15:32 UTC by Report Bug Copy Issue Report Usage of a direct database call is discouraged. Loading history... introduced 2018-09-01 15:32 UTC by Report Bug Copy Issue Report Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete(). Loading history... Coding Style Comprehensibility introduced 2018-09-01 15:32 UTC by Report Bug Copy Issue Report The string literal `SELECT blog_id FROM` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
11
12			if ( ! is_array( $blogids ) )
			0 ignored issues – show Coding Style Best Practice introduced 2018-09-01 15:32 UTC by Report Bug Copy Issue Report It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
13			return;
14
15			foreach ( $blogids as $blog_id ) {
16			switch_to_blog( $blog_id );
17			if ( is_plugin_active( $plugin ) ) {
18			$callback();
19			}
20			restore_current_blog();
21			}
22
23			}

podlove / podlove-subscribe-button-wp-plugin

GitHub Access Token became invalid

Push — master ( 0392a4...4f7518 )

for_every_podcast_blog() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like