podlove / podlove-subscribe-button-wp-plugin

version.php

<?php
/**

Missing short description in doc comment

 * @author    Podlove <podlove@podlove.org>
 * @copyright Copyright (c) 2014-2018, Podlove
 * @license   https://github.com/podlove/podlove-subscribe-button-wp-plugin/blob/master/LICENSE MIT
 * @package   Podlove\PodloveSubscribeButton
 */

/**
 * Version management for database migrations.
 *
 * Database changes require special care:
 * - the model has to be adjusted for users installing the plugin
 * - the current setup has to be migrated for current users
 *
 * These migrations are a way to handle current users. They do *not*
 * run on plugin activation.
 *
 * Pattern:
 *
 * - increment \PodloveSubscribeButton\DATABASE_VERSION constant by 1, e.g.
 * 		```php

Spaces must be used for mid-line alignment; tabs are not allowed

 * 		define( __NAMESPACE__ . '\DATABASE_VERSION', 2 );

Spaces must be used for mid-line alignment; tabs are not allowed

 * 		```

Spaces must be used for mid-line alignment; tabs are not allowed

 *
 * - add a case in `\PodloveSubscribeButton\run_migrations_for_version`, e.g.
 * 		```php

Spaces must be used for mid-line alignment; tabs are not allowed

 * 		function run_migrations_for_version( $version ) {

Spaces must be used for mid-line alignment; tabs are not allowed

 *			global $wpdb;

Spaces must be used for mid-line alignment; tabs are not allowed

 *			switch ( $version ) {

Spaces must be used for mid-line alignment; tabs are not allowed

 *				case 2:

Spaces must be used for mid-line alignment; tabs are not allowed

 *					$wbdb-> // run sql or whatever

Spaces must be used for mid-line alignment; tabs are not allowed

 *					break;

Spaces must be used for mid-line alignment; tabs are not allowed

 *			}

Spaces must be used for mid-line alignment; tabs are not allowed

 *		}

Spaces must be used for mid-line alignment; tabs are not allowed

 *		```

Spaces must be used for mid-line alignment; tabs are not allowed

 *
 *		Feel free to move the migration code into a separate function if it's

Spaces must be used for mid-line alignment; tabs are not allowed

 *		rather complex.

Spaces must be used for mid-line alignment; tabs are not allowed

 *
 * - adjust the main model / setup process so new users installing the plugin
 *   will have these changes too
 *
 * - Test the migrations! :)
 */

namespace PodloveSubscribeButton;
use \PodloveSubscribeButton\Model;

define( __NAMESPACE__ . '\DATABASE_VERSION', 2 );

add_action( 'admin_init', '\PodloveSubscribeButton\maybe_run_database_migrations' );
add_action( 'admin_init', '\PodloveSubscribeButton\run_database_migrations', 5 );

function maybe_run_database_migrations() {

Missing doc comment for function maybe_run_database_migrations()

	$database_version = get_option( 'podlove_subscribe_button_plugin_database_version' );

	if ( $database_version === false ) {

Use Yoda Condition checks, you must.

		// plugin has just been installed or Plugin Version < 1.3

Inline comments must end in full-stops, exclamation marks, or question marks

		update_option( 'podlove_subscribe_button_plugin_database_version', DATABASE_VERSION );
	}

}

function run_database_migrations() {

Missing doc comment for function run_database_migrations()

	if ( get_option( 'podlove_subscribe_button_plugin_database_version' ) >= DATABASE_VERSION ) {
		return;
	}

	if ( is_multisite() ) {
		set_time_limit( 0 ); // may take a while, depending on network size

Inline comments must end in full-stops, exclamation marks, or question marks

		\PodloveSubscribeButton\Helpers::for_every_podcast_blog( function() { migrate_for_current_blog(); });

Expected 1 spaces before closing bracket; 0 found

Opening brace must be the last content on the line

Closing brace of nested function must be on a new line

It is generally recommended to place each PHP statement on a line by itself.

	} else {
		migrate_for_current_blog();
	}

	if ( isset( $_REQUEST[ '_wp_http_referer' ] ) && $_REQUEST[ '_wp_http_referer' ] ) {

Processing form data without nonce verification.

Array keys must NOT be surrounded by spaces if they only contain a string or an integer.

Missing wp_unslash() before sanitization.

Detected usage of a non-sanitized input variable: $_REQUEST

		wp_redirect( $_REQUEST[ '_wp_http_referer' ] );

wp_redirect() found. Using wp_safe_redirect(), along with the allowed_redirect_hosts filter if needed, can help avoid any chances of malicious redirects within code. It is also important to remember to call exit() after a redirect so that no other unwanted code is executed.

Missing wp_unslash() before sanitization.

Array keys must NOT be surrounded by spaces if they only contain a string or an integer.

		exit;
	}
}

Expected 1 blank line before closing function brace; 0 found

function migrate_for_current_blog() {

Missing doc comment for function migrate_for_current_blog()

	$database_version = get_option( 'podlove_subscribe_button_plugin_database_version' );

	for ( $i = $database_version + 1; $i <= DATABASE_VERSION; $i++ ) {
		\PodloveSubscribeButton\run_migrations_for_version( $i );
		update_option( 'podlove_subscribe_button_plugin_database_version', $i );
	}

}

/**
 * Find and run migration for given version number.
 *
 * @todo  move migrations into separate files
 *
 * @param  int $version

Missing parameter comment

 */
function run_migrations_for_version( $version ) {
	global $wpdb;

	switch ( $version ) {}

This switch statement is empty, and could be removed.

}