podlove / podlove-subscribe-button-wp-plugin

inc/Options.php

<?php

Filenames should be all lowercase with hyphens as word separators. Expected options.php, but found Options.php.

Class file names should be based on the class name with "class-" prepended. Expected class-options.php, but found Options.php.

/**

Missing short description in doc comment

 * @author    Podlove <podlove@podlove.org>
 * @copyright Copyright (c) 2014-2018, Podlove
 * @license   https://github.com/podlove/podlove-subscribe-button-wp-plugin/blob/master/LICENSE MIT
 * @package   Podlove\PodloveSubscribeButton
 */

namespace PodloveSubscribeButton;

class Options {

Missing doc comment for class Options

	public static function register_settings() {

Method name "Options::register_settings" is not in camel caps format

		$args = array(
			'description'       => '',
			'sanitize_callback' => array( __CLASS__, 'sanitize_settings' ),
		);

		register_setting(
			'podlove-psb',
			'podlove_psb_defaults',
			$args
		);

		add_settings_section(
			'podlove-psb-defaults',
			__( 'Default Settings', 'podlove-subscribe-button' ),
			'__return_empty_string',
			'podlove-psb'
		);

		add_settings_field(
			'size',
			__( 'Size', 'podlove-subscribe-button' ),
			array( __CLASS__, 'field' ),
			'podlove-psb',
			'podlove-psb-defaults',
			array(
				'label_for' => 'size',
				'type'      => 'select',
			)
		);

		add_settings_field(
			'autowidth',
			__( 'Autowidth', 'podlove-subscribe-button' ),
			array( __CLASS__, 'field' ),
			'podlove-psb',
			'podlove-psb-defaults',
			array(
				'label_for' => 'autowidth',
				'type'      => 'checkbox',
			)
		);

		add_settings_field(
			'color',
			__( 'Color', 'podlove-subscribe-button' ),
			array( __CLASS__, 'field' ),
			'podlove-psb',
			'podlove-psb-defaults',
			array(
				'label_for' => 'color',
				'type'      => 'color',
			)
		);

		add_settings_field(
			'style',
			__( 'Style', 'podlove-subscribe-button' ),
			array( __CLASS__, 'field' ),
			'podlove-psb',
			'podlove-psb-defaults',
			array(
				'label_for' => 'style',
				'type'      => 'select',
			)
		);

		add_settings_field(
			'format',
			__( 'Format', 'podlove-subscribe-button' ),
			array( __CLASS__, 'field' ),
			'podlove-psb',
			'podlove-psb-defaults',
			array(
				'label_for' => 'format',
				'type'      => 'select',
			)
		);

		add_settings_field(
			'language',
			__( 'Language', 'podlove-subscribe-button' ),
			array( __CLASS__, 'field' ),
			'podlove-psb',
			'podlove-psb-defaults',
			array(
				'label_for' => 'language',
				'type'      => 'language',
			)
		);

	}

	public static function field( $args ) {

Missing doc comment for function field()

		if ( is_network_admin() ) {
			$option = get_site_option( 'podlove_psb_defaults' );
		} else {
			$option = get_option( 'podlove_psb_defaults' );
		}

		switch ( $args['type'] ) {
			case 'checkbox':
				?>
                <input type="checkbox" name="<?php echo "podlove_psb_defaults[{$args['label_for']}]"; ?>"

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '"podlove_psb_defaults[$args['label_for']]"'.

                       id="<?php echo "podlove_psb_defaults[{$args['label_for']}]"; ?>" <?php checked( $option[ $args['label_for'] ], 'on' ); ?> />

Found precision alignment of 3 spaces.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '"podlove_psb_defaults[$args['label_for']]"'.

				<?php
				break;

			case 'color':
				?>
                <input id="podlove_psb_defaults[color]" name="podlove_psb_defaults[color]" class="podlove_subscribe_button_color"
                       value="<?php echo $option['color'] ?>"/>

Found precision alignment of 3 spaces.

Inline PHP statement must end with a semicolon

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$option'.

				<?php
				break;

			case 'language':
				?>
                <select name="podlove_psb_defaults[language]" id="podlove_psb_defaults[language]">
					<?php foreach ( Defaults::button( 'language' ) as $value ) : ?>
                        <option value="<?php echo $value; ?>" <?php selected( $option['language'], $value ); ?>><?php echo $value; ?></option>
					<?php endforeach; ?>
                </select>
				<?php
				break;

Functions must not contain multiple empty lines in a row; found 2 empty lines

			case 'select':
				?>
                <select name="podlove_psb_defaults[<?php echo $args['label_for']; ?>]" id="podlove_psb_defaults[<?php echo $args['label_for']; ?>]">

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$args'.

					<?php foreach ( Defaults::button( $args['label_for'] ) as $value => $description ) { ?>
                        <option value="<?php echo $value; ?>" <?php selected( $option[ $args['label_for'] ], $value ); ?>><?php echo $description; ?></option>

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$value'.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$description'.

					<?php } ?>
                </select>
				<?php break;

Opening PHP tag must be on a line by itself

		}
	}

Expected 1 blank line before closing function brace; 0 found

	public static function sanitize_settings( $input = null ) {

Method name "Options::sanitize_settings" is not in camel caps format

Missing doc comment for function sanitize_settings()

	    $output = $input;

	    if ( ! array_key_exists('autowidth', $input ) ) {

Expected 1 spaces after opening bracket; 0 found

		    $output['autowidth'] = 'off';
        }

		return $output;
	}

Expected 1 blank line before closing function brace; 0 found

} // END class