podlove / podlove-subscribe-button-wp-plugin

widget.php

<?php

Class file names should be based on the class name with "class-" prepended. Expected class-podlove-subscribe-button-widget.php, but found widget.php.

This file is missing a doc comment.

namespace PodloveSubscribeButton;

include_once( ABSPATH . 'wp-admin/includes/plugin.php' );

"include_once" is a statement not a function; no parentheses are required

File is being unconditionally included; use "require_once" instead

class Podlove_Subscribe_Button_Widget extends \WP_Widget {

Class name "Podlove_Subscribe_Button_Widget" is not in PascalCase format

Missing doc comment for class Podlove_Subscribe_Button_Widget

	public function __construct() {

Missing doc comment for function __construct()

		parent::__construct(
					'podlove_subscribe_button_wp_plugin_widget',

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

					( self::is_podlove_publisher_active() ? 'Podlove Subscribe Button (WordPress plugin)' : 'Podlove Subscribe Button' ),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

					array( 'description' => __( 'Adds a Podlove Subscribe Button to your Sidebar', 'podlove-subscribe-button' ), )

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 20.

Comma not allowed after last value in single-line array declaration

				);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 16.

	}

Expected 1 blank line before closing function brace; 0 found

	public static $widget_settings = array('infotext', 'title', 'size', 'style', 'format', 'autowidth', 'button', 'color');

Missing member variable doc comment

Missing space after array opener.

Missing space before array closer.

	public static function is_podlove_publisher_active() {

Method name "Podlove_Subscribe_Button_Widget::is_podlove_publisher_active" is not in camel caps format

Missing doc comment for function is_podlove_publisher_active()

		if ( is_plugin_active("podlove-podcasting-plugin-for-wordpress/podlove.php") ) {

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

The string literal podlove-podcasting-plugin-for-wordpress/podlove.php does not require double quotes, as per coding-style, please use single quotes.

			return true;
		}

		return false;
	}

Expected 1 blank line before closing function brace; 0 found

	public function widget( $args, $instance ) {

Missing doc comment for function widget()

		// Fetch the (network)button by it's name

Inline comments must end in full-stops, exclamation marks, or question marks

		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name($instance['button']) )

It is generally a best practice to always use braces with control structures.

Variable assignment found within a condition. Did you mean to do a comparison?

Assignments must be the first block of code on a line

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			return sprintf( __('Oops. There is no button with the ID "%s".', 'podlove-subscribe-button'), $args['button'] );

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		echo $args['before_widget'];

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$args'.

		echo $args['before_title'] . apply_filters( 'widget_title', $instance['title'] ). $args['after_title'];

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$args'.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'apply_filters'.

Concat operator must be surrounded by a single space

		echo $button->render(

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$button'.

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'size'),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'autowidth'),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodloveSubscribeButton'.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'style'),

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodloveSubscribeButton'.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'format'), 

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodloveSubscribeButton'.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				\PodloveSubscribeButton::get_array_value_with_fallback($instance, 'color')

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodloveSubscribeButton'.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			);

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

		
		if ( strlen($instance['infotext']) )

It is generally a best practice to always use braces with control structures.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

			echo wpautop($instance['infotext']);

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'wpautop'.

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

		echo $args['after_widget'];

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$args'.

	}	

Expected 1 blank line before closing function brace; 0 found

Spaces must be used for mid-line alignment; tabs are not allowed

	public function form( $instance ) {

Missing doc comment for function form()

		foreach (self::$widget_settings as $setting) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

			$$setting = isset( $instance[$setting] ) ? $instance[$setting] : '';

Array keys must be surrounded by spaces unless they contain a string or an integer.

		}

		$buttons = \PodloveSubscribeButton\Model\Button::all();

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

		if ( is_multisite() )

It is generally a best practice to always use braces with control structures.

			$network_buttons = \PodloveSubscribeButton\Model\NetworkButton::all();

		$buttons_as_options = function ($buttons) {

No space after opening parenthesis is prohibited

Expected 1 spaces after opening parenthesis; 0 found

No space before closing parenthesis is prohibited

			foreach ($buttons as $subscribebutton) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

				echo "<option value='".$subscribebutton->name."' ".( $subscribebutton->name == $button ? 'selected=\"selected\"' : '' )." >".$subscribebutton->title." (".$subscribebutton->name.")</option>";

The variable $button does not exist. Did you maybe mean $buttons?

Concat operator must be surrounded by a single space

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$subscribebutton'.

Found: ==. Use strict comparisons (=== or !==).

The string literal > does not require double quotes, as per coding-style, please use single quotes.

The string literal ( does not require double quotes, as per coding-style, please use single quotes.

The string literal )</option> does not require double quotes, as per coding-style, please use single quotes.

			}
		}
		?>
		<p>
			<label for="<?php echo $this->get_field_id( 'title' ); ?>"><?php _e( 'Title', 'podlove-subscribe-button' ); ?></label> 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

			<input class="widefat" id="<?php echo $this->get_field_id( 'title' ); ?>" name="<?php echo $this->get_field_name( 'title' ); ?>" value="<?php echo $title; ?>" />

The variable $title seems to be never defined.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$title'.

			<label for="<?php echo $this->get_field_id( 'color' ); ?>"><?php _e( 'Color', 'podlove-subscribe-button' ); ?></label>

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

			<input class="podlove_subscribe_button_color" id="<?php echo $this->get_field_id( 'color' ); ?>" name="<?php echo $this->get_field_name( 'color' ); ?>" value="<?php echo $color; ?>" />

The variable $color seems to be never defined.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$color'.

			<style type="text/css">
				.sp-replacer {
					display: flex;
				}
				.sp-preview {
					flex-grow: 10;
				}
			</style>

			<label for="<?php echo $this->get_field_id( 'button' ); ?>"><?php _e( 'Button', 'podlove-subscribe-button' ); ?></label> 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

			<select class="widefat" id="<?php echo $this->get_field_id( 'button' ); ?>"

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

				      name="<?php echo $this->get_field_name( 'button' ); ?>">

Found precision alignment of 2 spaces.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

				<?php if ( isset($network_buttons) && count($network_buttons) > 0 ) : ?>

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

					<optgroup label="<?php _e('Local', 'podlove-subscribe-button' ); ?>">

All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

Expected 1 spaces after opening bracket; 0 found

						<?php $buttons_as_options($buttons); ?>

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

					</optgroup>
					<optgroup label="<?php _e('Network', 'podlove-subscribe-button' ); ?>">

All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

Expected 1 spaces after opening bracket; 0 found

						<?php $buttons_as_options($network_buttons); ?>

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

					</optgroup>
				<?php else : 

Opening PHP tag must be on a line by itself

					$buttons_as_options($buttons);

Expected 1 spaces after opening bracket; 0 found

Expected 1 spaces before closing bracket; 0 found

				 endif; ?>

Found precision alignment of 1 spaces.

Closing brace indented incorrectly; expected 16 spaces, found 17

Closing PHP tag must be on a line by itself

			</select>

			<?php
			$customize_options = array(
				'size'      => array(
					'name'    => __( 'Size', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$size

Each array item in a multi-line array declaration must end in a comma

				),
				'style'     => array(
					'name'    => __( 'Style', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$style

Each array item in a multi-line array declaration must end in a comma

				),
				'format'    => array(
					'name'    => __( 'Format', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$format

Each array item in a multi-line array declaration must end in a comma

				),
				'autowidth' => array(
					'name'    => __( 'Autowidth', 'podlove-subscribe-button' ),
					'options' => \PodloveSubscribeButton\Model\Button::$width

Each array item in a multi-line array declaration must end in a comma

				)

Each array item in a multi-line array declaration must end in a comma

			);

			foreach ($customize_options as $slug => $properties) : ?>

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

Closing PHP tag must be on a line by itself

				<label for="<?php echo $this->get_field_id( $slug ); ?>"><?php echo $properties['name']; ?></label>

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$properties'.

				<select class="widefat" id="<?php echo $this->get_field_id( $slug ); ?>" name="<?php echo $this->get_field_name( $slug ); ?>">

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

					<option value="default" <?php echo ( $$slug == 'default' ? 'selected="selected"' : '' ); ?>><?php printf( __( 'Default %s', 'podlove-subscribe-button' ), $properties['name'] ) ?></option>

Found: ==. Use strict comparisons (=== or !==).

Use Yoda Condition checks, you must.

Inline PHP statement must end with a semicolon

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$properties'.

					<optgroup>
						<?php foreach ( $properties['options'] as $property => $name ) : ?>
						<option value="<?php echo $property; ?>" <?php echo ( $$slug == $property ? 'selected="selected"' : '' ); ?>><?php echo $name; ?></option>

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$property'.

Found: ==. Use strict comparisons (=== or !==).

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$name'.

						<?php endforeach; ?>
					</optgroup>
				</select>
			<?php endforeach; ?>
		

Found precision alignment of 1 spaces.

			<label for="<?php echo $this->get_field_id( 'infotext' ); ?>"><?php _e( 'Description', 'podlove-subscribe-button' ); ?></label> 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (like esc_html_e() or esc_attr_e()), found '_e'.

			<textarea class="widefat" rows="10" id="<?php echo $this->get_field_id( 'infotext' ); ?>" name="<?php echo $this->get_field_name( 'infotext' ); ?>"><?php echo $infotext; ?></textarea>

The variable $infotext seems to be never defined.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$infotext'.

		</p>
		<?php 
	}

Expected 1 blank line before closing function brace; 0 found

	public function update( $new_instance, $old_instance ) {

Missing doc comment for function update()

		$instance = array();

		foreach (self::$widget_settings as $setting) {

No space after opening parenthesis is prohibited

No space before closing parenthesis is prohibited

			$instance[$setting]  = ( ! empty( $new_instance[$setting] ) ) ? strip_tags( $new_instance[$setting] ) : '';

Array keys must be surrounded by spaces unless they contain a string or an integer.

Equals sign not aligned correctly; expected 1 space but found 2 spaces

strip_tags() is discouraged. Use the more comprehensive wp_strip_all_tags() instead.

		}

		return $instance;
	}

Expected 1 blank line before closing function brace; 0 found

}
add_action( 'widgets_init', function(){

Expected 1 space before opening brace; found 0

     register_widget( '\PodloveSubscribeButton\Podlove_Subscribe_Button_Widget' );

Found precision alignment of 1 spaces.

});