PodloveSubscribeButton::interpret_width_attribute() - Code Metrics - Inspection of "improve strings for php error message" - podlove/podlove-subscribe-button-wp-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3b4963...d53694 )

by Christian

created 2018-09-02 13:32 UTC

interpret_width_attribute() A

↳ Parent: PodloveSubscribeButton

Complexity

Conditions	4
Paths	3

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	5
nc	3
nop	1
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php

introduced 2018-09-01 15:32 UTC by

Class file names should be based on the class name with "class-" prepended. Expected class-podlovesubscribebutton.php, but found podlove.php.

/**

 * Plugin Name: Podlove Subscribe Button

 * Plugin URI:  http://wordpress.org/extend/plugins/podlove-subscribe-button/

 * Description: Brings the Podlove Subscribe Button to your WordPress installation.

 * Version:     1.3.4

 * Author:      Podlove

 * Author URI:  http://podlove.org

 * License:     MIT

 * License URI: license.txt

 * Text Domain: podlove-subscribe-button

 * Domain Path: /languages

*/

Coding Style Documentation introduced 2018-09-02 08:27 UTC by

Missing @package tag in file comment

$correct_php_version = version_compare( phpversion(), "15.3", ">=" );

Coding Style Comprehensibility introduced 2018-09-01 15:32 UTC by

The string literal 15.3 does not require double quotes, as per coding-style, please use single quotes.

if ( ! $correct_php_version ) {

	printf( __( 'Podlove Subscribe Button Plugin requires %s or higher.<br>', 'podlove-subscribe-button' ), '<code>PHP 5.3</code>' );

introduced 2018-09-02 13:34 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.

introduced 2018-09-02 13:34 UTC by

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

	echo '<br />';

	printf( __( 'You are running %s', 'podlove-subscribe-button' ), '<code>PHP ' . phpversion() . '</code>' );

introduced 2018-09-02 13:34 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.

introduced 2018-09-02 13:34 UTC by

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

introduced 2018-09-02 13:34 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'phpversion'.

	exit;

// Constants

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('constants.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

require('settings/buttons.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

// Models

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('model/base.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

require('model/button.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

require('model/network_button.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

// Table

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('settings/buttons_list_table.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

// Media Types

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('media_types.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

// Widget

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('widget.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

// Version control

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('version.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

// Helper functions

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('helper.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

add_action( 'admin_menu', array( 'PodloveSubscribeButton', 'admin_menu') );

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

if ( is_multisite() )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

	add_action( 'network_admin_menu', array( 'PodloveSubscribeButton', 'admin_network_menu') );

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

add_action( 'admin_init', array( 'PodloveSubscribeButton\Settings\Buttons', 'process_form' ) );

register_activation_hook( __FILE__, array( 'PodloveSubscribeButton', 'build_models' ) );

// Register Settings

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

add_action( 'admin_init', function () {

	$settings = array('size', 'autowidth', 'style', 'format', 'color');

introduced 2018-09-01 15:32 UTC by

Missing space after array opener.

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

	foreach ($settings as $setting) {

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

		register_setting( 'podlove-subscribe-button', 'podlove_subscribe_button_default_' . $setting );

} );

add_shortcode( 'podlove-subscribe-button', array( 'PodloveSubscribeButton', 'shortcode' ) );

add_action( 'plugins_loaded', function () {

	load_plugin_textdomain( 'podlove-subscribe-button', false, dirname(plugin_basename( __FILE__)) . '/languages/');

Bug introduced 2018-09-02 08:27 UTC by

false of type false is incompatible with the type string expected by parameter $deprecated of load_plugin_textdomain(). ( Ignorable by Annotation )

Coding Style introduced 2018-09-02 08:27 UTC by

Expected 1 spaces before closing bracket; 0 found

Coding Style introduced 2018-09-02 08:27 UTC by

Expected 1 spaces after opening bracket; 0 found

} );

PodloveSubscribeButton::run();

class PodloveSubscribeButton {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for class PodloveSubscribeButton

	public static function run() {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function run()

		add_action( 'admin_enqueue_scripts', array( __CLASS__, 'enqueue_assets' ) );

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

	public static function enqueue_assets( $hook ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::enqueue_assets" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function enqueue_assets()

		$pages = array( 'settings_page_podlove-subscribe-button', 'widgets.php' );

		if ( ! in_array( $hook, $pages )  ) {

introduced 2018-09-01 15:32 UTC by

Expected exactly one space before closing parenthesis; " " found.

introduced 2018-09-01 15:32 UTC by

Not using strict comparison for in_array; supply true for third argument.

			return;

		// CSS Stylesheet

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		wp_register_style( 'podlove-subscribe-button', plugin_dir_url( __FILE__ ) . 'style.css', false, '1.3.3' );

Bug introduced 2018-09-01 15:32 UTC by

false of type false is incompatible with the type array expected by parameter $deps of wp_register_style(). ( Ignorable by Annotation )

		wp_enqueue_style( 'podlove-subscribe-button' );

		// Spectrum JS

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		wp_enqueue_style( 'podlove-subscribe-button-spectrum', plugin_dir_url( __FILE__ ) . 'js/spectrum/spectrum.css', array(), '1.8.0' );

		wp_enqueue_script( 'podlove-subscribe-button-spectrum', plugin_dir_url( __FILE__ ) . 'js/spectrum/spectrum.js', array( 'jquery' ), '1.8.0' );

introduced 2018-09-01 15:32 UTC by

In footer ($in_footer) is not set explicitly wp_enqueue_script; It is recommended to load scripts in the footer. Please set this value to true to load it in the footer, or explicitly false if it should be loaded in the header.

		// Admin JS

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		wp_register_script( 'podlove-subscribe-button-admin-tools', plugin_dir_url( __FILE__ ) . 'js/admin.js', array( 'jquery' ), '1.3.3' );

introduced 2018-09-01 15:32 UTC by

In footer ($in_footer) is not set explicitly wp_register_script; It is recommended to load scripts in the footer. Please set this value to true to load it in the footer, or explicitly false if it should be loaded in the header.

		$js_translations = array(

			'select_color'  => __( 'Select Color', 'podlove-subscribe-button' ),

			'cancel'        => __( 'Cancel', 'podlove-subscribe-button' ),

			'media_library' => __( 'Media Library', 'podlove-subscribe-button' ),

			'use_for'       => __( 'Use for Podcast Cover Art', 'podlove-subscribe-button' ),

);

		wp_localize_script( 'podlove-subscribe-button-admin-tools', 'i18n', $js_translations );

		wp_enqueue_script( 'podlove-subscribe-button-admin-tools' );

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

100

101

	public static function admin_menu() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::admin_menu" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function admin_menu()

102

		add_options_page(

103

				'Podlove Subscribe Button Options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

104

				'Podlove Subscribe Button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

105

				'manage_options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

106

				'podlove-subscribe-button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

107

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

108

);

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

109

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

110

111

	public static function admin_network_menu() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::admin_network_menu" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function admin_network_menu()

112

		add_submenu_page(

113

				'settings.php',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

114

				'Podlove Subscribe Button Options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

115

				'Podlove Subscribe Button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

116

				'manage_options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

117

				'podlove-subscribe-button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

118

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

119

);

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

120

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

121

122

	public static function build_models() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::build_models" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function build_models()

123

		// Build Databases

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

124

		\PodloveSubscribeButton\Model\Button::build();

125

		if ( is_multisite() )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

126

			\PodloveSubscribeButton\Model\NetworkButton::build();

127

128

		// Set Button "default" values

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

129

		$default_values = array(

130

				'size' => 'big',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 6 space(s) between "'size'" and double arrow, but found 1.

131

				'autowidth' => 'on',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

132

				'color' => '#599677',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'color'" and double arrow, but found 1.

133

				'style' => 'filled',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'style'" and double arrow, but found 1.

134

				'format' => 'rectangle'

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'format'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

135

);

introduced 2018-09-01 15:32 UTC by

Array closer not aligned correctly; expected 8 space(s) but found 12

136

137

		foreach ($default_values as $option => $default_value) {

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

138

			if ( ! get_option('podlove_subscribe_button_default_' . $option ) ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

139

				update_option('podlove_subscribe_button_default_' . $option, $default_value);

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

140

141

142

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

143

144

	public static function shortcode( $args ) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function shortcode()

145

		if ( ! $args || ! isset($args['button']) ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

146

			return __('You need to create a Button first and provide its ID.', 'podlove-subscribe-button');

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

147

		} else {

148

			$buttonid = $args['button'];

149

150

151

		// Fetch the (network)button by it's name

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

152

		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name($args['button']) )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-09-01 15:32 UTC by

Variable assignment found within a condition. Did you mean to do a comparison?

Coding Style introduced 2018-09-01 15:32 UTC by

Assignments must be the first block of code on a line

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

153

			return sprintf( __('Oops. There is no button with the ID "%s".', 'podlove-subscribe-button'), $args['button'] );

introduced 2018-09-01 15:32 UTC by

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

154

155

		// Get button styling and options

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

156

		$autowidth = self::interpret_width_attribute( self::get_array_value_with_fallback($args, 'width') );

Bug introduced 2018-09-01 15:32 UTC by

It seems like self::get_array_value_wi...allback($args, 'width') can also be of type false; however, parameter $width_attribute of PodloveSubscribeButton::...rpret_width_attribute() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

157

		$size = self::get_attribute( 'size', self::get_array_value_with_fallback($args, 'size') );

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

Bug introduced 2018-09-01 15:32 UTC by

It seems like self::get_array_value_wi...fallback($args, 'size') can also be of type false; however, parameter $attribute_value of PodloveSubscribeButton::get_attribute() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

158

		$style = self::get_attribute( 'style', self::get_array_value_with_fallback($args, 'style') );

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

159

		$format = self::get_attribute( 'format', self::get_array_value_with_fallback($args, 'format') );

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

160

		$color = self::get_attribute( 'color', self::get_array_value_with_fallback($args, 'color') );

Unused Code introduced 2018-09-01 15:32 UTC by

The assignment to $color is dead and can be removed.

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

161

162

		if ( isset($args['language']) ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

163

			$language = $args['language'];

164

		} else {

165

			$language = 'en';

166

167

168

		if ( isset($args['color']) ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

169

			$color = $args['color'];

170

		} else {

171

			$color = get_option('podlove_subscribe_button_default_color', '#599677');

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

172

173

174

		if ( isset($args['hide']) && $args['hide'] == 'true' ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

175

			$hide = true;

176

		} else {

177

			$hide = false;

178

179

180

		// Render button

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

181

		return $button->render($size, $autowidth, $style, $format, $color, $hide, $buttonid, $language);

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

182

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

183

184

	public static function get_array_value_with_fallback($args, $key) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::get_array_value_with_fallback" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function get_array_value_with_fallback()

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening parenthesis; 0 found

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

185

		if ( isset($args[$key]) )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

186

			return $args[$key];

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

187

188

		return false;

189

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

190

191

/**

Coding Style introduced 2018-09-01 15:32 UTC by

Missing short description in doc comment

192

	 * @param  string $attribute

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

193

	 * @param  string $attribute_value

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

194

	 * @return string

195

*/

196

	private static function get_attribute($attribute=null, $attribute_value=null) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::get_attribute" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$attribute" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$attribute"; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$attribute_value" and equals sign; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between default value and equals sign for argument "$attribute_value"; expected 1 but found 0

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

197

		if ( isset($attribute_value) && ctype_alnum($attribute_value) && key_exists( $attribute_value, \PodloveSubscribeButton\Model\Button::$$attribute ) ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

198

			return $attribute_value;

199

		} else {

200

			return get_option('podlove_subscribe_button_default_' . $attribute, \PodloveSubscribeButton\Model\Button::$properties[$attribute]);

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

201

202

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

203

204

/**

205

	 * Interprets the provided width attribute and return either auto- or a specific width

206

	 * @param  string $width_attribute

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

207

	 * @return string

208

*/

209

	private static function interpret_width_attribute( $width_attribute = null ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::interpret_width_attribute" is not in camel caps format

210

		if ( $width_attribute == 'auto' )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

211

			return 'on';

212

		if ( $width_attribute && $width_attribute !== 'auto' )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

213

			return 'off';

214

215

		return get_option('podlove_subscribe_button_default_autowidth', 'on');

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening bracket; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces before closing bracket; 0 found

216

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

217

podlove / podlove-subscribe-button-wp-plugin

GitHub Access Token became invalid

Push — master ( 3b4963...d53694 )

interpret_width_attribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like