PodloveSubscribeButton::sanitize_settings() - Code Metrics - podlove/podlove-subscribe-button-wp-plugin - Measure and Improve Code Quality continuously with Scrutinizer

PodloveSubscribeButton::sanitize_settings() A
last analyzed 2024-02-06 12:13 UTC

↳ Parent: PodloveSubscribeButton

Complexity

Conditions	3
Paths	3

Size

Total Lines	5
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	4
c	0
b	0
f	0
nc	3
nop	1
dl	0
loc	5
rs	10

<?php

introduced 2018-09-04 17:18 UTC by

Class file names should be based on the class name with "class-" prepended. Expected class-podlovesubscribebutton.php, but found podlove.php.

/**

 * Plugin Name: Podlove Subscribe Button

 * Plugin URI:  https://wordpress.org/extend/plugins/podlove-subscribe-button/

 * Description: Brings the Podlove Subscribe Button to your WordPress installation.

 * Version:     1.3.11

 * Author:      Podlove

 * Author URI:  https://podlove.org

 * License:     MIT

 * License URI: license.txt

 * Text Domain: podlove-subscribe-button

 * Domain Path: /languages

*/

Coding Style Documentation introduced 2018-09-02 08:27 UTC by

Missing @package tag in file comment

$correct_php_version = version_compare( phpversion(), "5.3", ">=" );

Coding Style Comprehensibility introduced 2018-09-01 15:32 UTC by

The string literal 5.3 does not require double quotes, as per coding-style, please use single quotes.

if ( ! $correct_php_version ) {

	printf( __( 'Podlove Subscribe Button Plugin requires %s or higher.<br>', 'podlove-subscribe-button' ), '<code>PHP 5.3</code>' );

introduced 2018-09-02 13:34 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.

introduced 2018-09-01 15:32 UTC by

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

	echo '<br />';

	printf( __( 'You are running %s', 'podlove-subscribe-button' ), '<code>PHP ' . phpversion() . '</code>' );

introduced 2018-09-02 13:34 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '__'.

introduced 2018-09-02 13:34 UTC by

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

introduced 2018-09-12 14:45 UTC by

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'phpversion'.

	exit;

// Constants

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('constants.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

require('settings/buttons.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

// Models

Coding Style introduced 2018-10-10 14:14 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('model/base.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

require('model/button.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

require('model/network_button.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

// Table

Coding Style introduced 2018-10-10 14:14 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('settings/buttons_list_table.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

// Media Types

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('media_types.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

// Widget

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('widget.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

// Version control

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('version.php');

Coding Style introduced 2018-09-01 15:32 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

// Helper functions

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

require('helper.php');

Coding Style introduced 2023-02-10 12:03 UTC by

"require" is a statement not a function; no parentheses are required

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

add_action( 'admin_menu', array( 'PodloveSubscribeButton', 'admin_menu') );

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

if ( is_multisite() )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

	add_action( 'network_admin_menu', array( 'PodloveSubscribeButton', 'admin_network_menu') );

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

add_action( 'admin_init', array( 'PodloveSubscribeButton\Settings\Buttons', 'process_form' ) );

register_activation_hook( __FILE__, array( 'PodloveSubscribeButton', 'build_models' ) );

// Register Settings

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

add_action( 'admin_init', function () {

Coding Style introduced 2018-09-12 14:45 UTC by

The opening parenthesis of a multi-line function call should be the last content on the line.

Coding Style introduced 2018-09-12 14:45 UTC by

For multi-line function calls, each argument should be on a separate line.

	$settings = array( 'size', 'autowidth', 'style', 'format', 'color' );

	foreach ( $settings as $setting ) {

		if ( 'autowidth' == $setting ) {

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

			$args = array(

				'sanitize_callback' => array( 'PodloveSubscribeButton', 'sanitize_settings' ),

);

			register_setting( 'podlove-subscribe-button', 'podlove_subscribe_button_default_' . $setting, $args );

		} else {

			register_setting( 'podlove-subscribe-button', 'podlove_subscribe_button_default_' . $setting );

} );

Coding Style introduced 2023-02-10 12:03 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

add_shortcode( 'podlove-subscribe-button', array( 'PodloveSubscribeButton', 'shortcode' ) );

add_action( 'plugins_loaded', function () {

Coding Style introduced 2023-02-10 12:03 UTC by

The opening parenthesis of a multi-line function call should be the last content on the line.

Coding Style introduced 2023-02-10 12:03 UTC by

For multi-line function calls, each argument should be on a separate line.

	load_plugin_textdomain( 'podlove-subscribe-button', false, dirname(plugin_basename( __FILE__)) . '/languages/');

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

} );

Coding Style introduced 2023-02-10 12:03 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

PodloveSubscribeButton::run();

class PodloveSubscribeButton {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for class PodloveSubscribeButton

	public static function run() {

Coding Style Documentation introduced 2018-09-02 14:06 UTC by

Missing doc comment for function run()

		add_action( 'admin_enqueue_scripts', array( __CLASS__, 'enqueue_assets' ) );

Coding Style introduced 2018-09-14 15:07 UTC by

Expected 1 blank line before closing function brace; 0 found

	public static function enqueue_assets( $hook ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::enqueue_assets" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function enqueue_assets()

		$pages = array( 'settings_page_podlove-subscribe-button', 'widgets.php' );

		if ( ! in_array( $hook, $pages )  ) {

introduced 2018-09-01 15:32 UTC by

Not using strict comparison for in_array; supply true for third argument.

introduced 2018-09-01 15:32 UTC by

Expected exactly one space before closing parenthesis; " " found.

			return;

		// CSS Stylesheet

Coding Style introduced 2023-02-10 12:03 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		wp_register_style( 'podlove-subscribe-button', plugin_dir_url( __FILE__ ) . 'style.css', false, '1.3.6' );

Bug introduced 2023-02-10 12:03 UTC by

false of type false is incompatible with the type string[] expected by parameter $deps of wp_register_style(). ( Ignorable by Annotation )

		wp_enqueue_style( 'podlove-subscribe-button' );

		// Admin JS

Coding Style introduced 2018-09-02 13:22 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		wp_enqueue_style( 'wp-color-picker' );

		wp_register_script( 'podlove-subscribe-button-admin-tools', plugin_dir_url( __FILE__ ) . 'js/admin.js', array( 'jquery', 'wp-color-picker' ), '1.3.6' );

introduced 2018-10-10 14:14 UTC by

In footer ($in_footer) is not set explicitly wp_register_script; It is recommended to load scripts in the footer. Please set this value to true to load it in the footer, or explicitly false if it should be loaded in the header.

		$js_translations = array(

			'media_library' => __( 'Media Library', 'podlove-subscribe-button' ),

			'use_for'       => __( 'Use for Podcast Cover Art', 'podlove-subscribe-button' ),

);

100

		wp_localize_script( 'podlove-subscribe-button-admin-tools', 'i18n', $js_translations );

101

		wp_enqueue_script( 'podlove-subscribe-button-admin-tools' );

102

Coding Style introduced 2018-09-14 15:07 UTC by

Expected 1 blank line before closing function brace; 0 found

103

104

	public static function admin_menu() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::admin_menu" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function admin_menu()

105

		add_options_page(

106

				'Podlove Subscribe Button Options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

107

				'Podlove Subscribe Button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

108

				'manage_options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

109

				'podlove-subscribe-button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

110

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

111

);

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

112

Coding Style introduced 2018-10-05 14:15 UTC by

Expected 1 blank line before closing function brace; 0 found

113

114

	public static function admin_network_menu() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::admin_network_menu" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function admin_network_menu()

115

		add_submenu_page(

116

				'settings.php',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

117

				'Podlove Subscribe Button Options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

118

				'Podlove Subscribe Button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

119

				'manage_options',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

120

				'podlove-subscribe-button',

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

121

				array( 'PodloveSubscribeButton\Settings\Buttons', 'page')

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

introduced 2018-09-01 15:32 UTC by

Missing space before array closer.

122

);

Coding Style introduced 2018-09-01 15:32 UTC by

This line of the multi-line function call does not seem to be indented correctly. Expected 8 spaces, but found 12.

123

Coding Style introduced 2018-10-10 14:14 UTC by

Expected 1 blank line before closing function brace; 0 found

124

125

	public static function build_models() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::build_models" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function build_models()

126

		// Build Databases

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

127

		\PodloveSubscribeButton\Model\Button::build();

128

		if ( is_multisite() )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

129

			\PodloveSubscribeButton\Model\NetworkButton::build();

130

131

		// Set Button "default" values

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

132

		$default_values = array(

133

				'size' => 'big',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 6 space(s) between "'size'" and double arrow, but found 1.

134

				'autowidth' => 'on',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

135

				'color' => '#599677',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'color'" and double arrow, but found 1.

136

				'style' => 'filled',

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 5 space(s) between "'style'" and double arrow, but found 1.

137

				'format' => 'rectangle'

introduced 2018-09-01 15:32 UTC by

Array item not aligned correctly; expected 12 spaces but found 16

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 4 space(s) between "'format'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

138

);

introduced 2018-09-01 15:32 UTC by

Array closer not aligned correctly; expected 8 space(s) but found 12

139

140

		foreach ($default_values as $option => $default_value) {

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

141

			if ( ! get_option('podlove_subscribe_button_default_' . $option ) ) {

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

142

				update_option('podlove_subscribe_button_default_' . $option, $default_value);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

143

144

145

Coding Style introduced 2018-10-05 12:56 UTC by

Expected 1 blank line before closing function brace; 0 found

146

147

	public static function shortcode( $args ) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function shortcode()

148

		if ( ! $args || ! isset($args['button']) ) {

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

149

			return __('You need to create a Button first and provide its ID.', 'podlove-subscribe-button');

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

150

		} else {

151

			$buttonid = $args['button'];

152

153

154

		// Fetch the (network)button by it's name

Coding Style introduced 2023-02-10 12:03 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

155

		if ( ! $button = \PodloveSubscribeButton\Model\Button::get_button_by_name($args['button']) )

introduced 2018-09-01 15:32 UTC by

Variable assignment found within a condition. Did you mean to do a comparison?

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

Coding Style introduced 2023-02-10 12:03 UTC by

Assignments must be the first block of code on a line

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

156

			return sprintf( __('Oops. There is no button with the ID "%s".', 'podlove-subscribe-button'), $args['button'] );

introduced 2023-02-10 12:03 UTC by

A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

157

158

		// Get button styling and options

Coding Style introduced 2023-02-10 12:03 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

159

		$autowidth = self::interpret_width_attribute( self::get_array_value_with_fallback($args, 'width') );

Bug introduced 2018-10-24 12:28 UTC by

It seems like self::get_array_value_wi...allback($args, 'width') can also be of type false; however, parameter $width_attribute of PodloveSubscribeButton::...rpret_width_attribute() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

160

		$size = self::get_attribute( 'size', self::get_array_value_with_fallback($args, 'size') );

Bug introduced 2018-10-24 12:28 UTC by

It seems like self::get_array_value_wi...fallback($args, 'size') can also be of type false; however, parameter $attribute_value of PodloveSubscribeButton::get_attribute() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

161

		$style = self::get_attribute( 'style', self::get_array_value_with_fallback($args, 'style') );

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

162

		$format = self::get_attribute( 'format', self::get_array_value_with_fallback($args, 'format') );

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

163

		$color = self::get_attribute( 'color', self::get_array_value_with_fallback($args, 'color') );

Unused Code introduced 2018-09-01 15:32 UTC by

The assignment to $color is dead and can be removed.

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

164

165

		if ( isset($args['language']) ) {

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

166

			$language = $args['language'];

167

		} else {

168

			$language = 'en';

169

170

171

		if ( isset($args['color']) ) {

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

172

			$color = $args['color'];

173

		} else {

174

			$color = get_option('podlove_subscribe_button_default_color', '#599677');

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

175

176

177

		if ( isset($args['hide']) && $args['hide'] == 'true' ) {

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

178

			$hide = true;

179

		} else {

180

			$hide = false;

181

182

183

		// Render button

Coding Style introduced 2023-02-10 12:03 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

184

		return $button->render($size, $autowidth, $style, $format, $color, $hide, $buttonid, $language);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

185

Coding Style introduced 2018-09-12 23:13 UTC by

Expected 1 blank line before closing function brace; 0 found

186

187

	public static function get_array_value_with_fallback($args, $key) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::get_array_value_with_fallback" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function get_array_value_with_fallback()

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening parenthesis; 0 found

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

188

		if ( isset($args[$key]) )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

189

			return $args[$key];

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

190

191

		return false;

192

Coding Style introduced 2018-10-05 12:56 UTC by

Expected 1 blank line before closing function brace; 0 found

193

194

/**

Coding Style introduced 2018-09-04 17:18 UTC by

Missing short description in doc comment

195

	 * @param  string $attribute

Coding Style Documentation introduced 2018-10-05 12:56 UTC by

Missing parameter comment

196

	 * @param  string $attribute_value

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

197

	 * @return string

198

*/

199

	private static function get_attribute($attribute=null, $attribute_value=null) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::get_attribute" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$attribute" and equals sign; expected 1 but found 0

Coding Style introduced 2023-02-10 12:03 UTC by

Incorrect spacing between default value and equals sign for argument "$attribute"; expected 1 but found 0

Coding Style introduced 2018-09-01 15:32 UTC by

Incorrect spacing between argument "$attribute_value" and equals sign; expected 1 but found 0

Coding Style introduced 2023-02-10 12:03 UTC by

Incorrect spacing between default value and equals sign for argument "$attribute_value"; expected 1 but found 0

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

200

		if ( isset($attribute_value) && ctype_alnum($attribute_value) && key_exists( $attribute_value, \PodloveSubscribeButton\Model\Button::$$attribute ) ) {

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

201

			return $attribute_value;

202

		} else {

203

			return get_option('podlove_subscribe_button_default_' . $attribute, \PodloveSubscribeButton\Model\Button::$properties[$attribute]);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

introduced 2018-09-01 15:32 UTC by

Array keys must be surrounded by spaces unless they contain a string or an integer.

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

204

205

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

206

207

/**

208

	 * Interprets the provided width attribute and return either auto- or a specific width

209

	 * @param  string $width_attribute

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

210

	 * @return string

211

*/

212

	private static function interpret_width_attribute( $width_attribute = null ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "PodloveSubscribeButton::interpret_width_attribute" is not in camel caps format

213

		if ( $width_attribute == 'auto' )

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2023-02-10 12:03 UTC by

Found: ==. Use strict comparisons (=== or !==).

214

			return 'on';

215

		if ( $width_attribute && $width_attribute !== 'auto' )

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

216

			return 'off';

217

218

		return get_option('podlove_subscribe_button_default_autowidth', 'on');

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

219

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 blank line before closing function brace; 0 found

220

221

	public static function sanitize_settings( $input = null ) {

Coding Style introduced 2023-02-10 12:03 UTC by

Method name "PodloveSubscribeButton::sanitize_settings" is not in camel caps format

Coding Style Documentation introduced 2018-10-05 12:56 UTC by

Missing doc comment for function sanitize_settings()

222

		if ( null == $input ) {

introduced 2023-02-10 12:03 UTC by

Found: ==. Use strict comparisons (=== or !==).

223

			return 'off';

224

		} elseif ( 'on' == $input ) {

introduced 2023-02-10 12:03 UTC by

Found: ==. Use strict comparisons (=== or !==).

225

			return $input;

226

227

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 blank line before closing function brace; 0 found

228

229

podlove / podlove-subscribe-button-wp-plugin

GitHub Access Token became invalid

PodloveSubscribeButton::sanitize_settings() A last analyzed 2024-02-06 12:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PodloveSubscribeButton::sanitize_settings() A
last analyzed 2024-02-06 12:13 UTC