Base::save() - Code Metrics - podlove/podlove-subscribe-button-wp-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Base::save() A
last analyzed 2024-02-06 12:13 UTC

↳ Parent: Base

Complexity

Conditions	3
Paths	3

Size

Total Lines	37
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	25
c	1
b	0
f	0
nc	3
nop	0
dl	0
loc	37
rs	9.52

<?php

introduced 2018-09-01 15:32 UTC by

Class file names should be based on the class name with "class-" prepended. Expected class-base.php, but found base.php.

Coding Style introduced 2018-09-01 15:32 UTC by

This file is missing a doc comment.

namespace PodloveSubscribeButton\Model;

abstract class Base {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for class Base

/**

	 * Property dictionary for all tables

*/

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing @var tag in member variable comment

	private static $properties = array();

	private $is_new = true;

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing member variable doc comment

/**

	 * Contains property values

*/

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing @var tag in member variable comment

	private $data = array();

	public function __set( $name, $value ) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function __set()

		if ( static::has_property( $name ) ) {

			$this->set_property( $name, $value );

		} else {

			$this->$name = $value;

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

	private function set_property( $name, $value ) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function set_property()

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::set_property" is not in camel caps format

		$this->data[ $name ] = $value;

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

	public function __get( $name ) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function __get()

		if ( static::has_property( $name ) ) {

			return $this->get_property( $name );

		} elseif ( property_exists( $this, $name ) ) {

			return $this->$name;

		} else {

			return null;

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

	private function get_property( $name ) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function get_property()

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::get_property" is not in camel caps format

		if ( isset( $this->data[ $name ] ) ) {

			return $this->data[ $name ];

		} else {

			return null;

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

	private static function unserialize_property($property) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function unserialize_property()

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::unserialize_property" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

		if ( ! isset($property) )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

			return;

		if ( $unserialized_string = is_serialized($property) )

Unused Code introduced 2018-09-01 15:32 UTC by

The assignment to $unserialized_string is dead and can be removed.

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-09-01 15:32 UTC by

Variable assignment found within a condition. Did you mean to do a comparison?

Coding Style introduced 2023-02-10 12:03 UTC by

Assignments must be the first block of code on a line

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

			return unserialize($property);

introduced 2018-09-01 15:32 UTC by

unserialize() found. Serialized data has known vulnerability problems with Object Injection. JSON is generally a better approach for serializing data. See https://www.owasp.org/index.php/PHP_Object_Injection

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

		return $property;

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

/**

	 * Retrieves the database table name.

	 * The name is derived from the namespace an class name. Additionally, it

	 * is prefixed with the global WordPress database table prefix.

	 * @todo cache

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

	 * @return string database table name

*/

	public static function table_name() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::table_name" is not in camel caps format

		global $wpdb;

		// prefix with $wpdb prefix

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		return $wpdb->prefix . static::name();

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

/**

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Doc comment for parameter "$args" missing

	 * Define a property with name and type.

	 * Currently only supports basics.

	 * @todo enable additional options like NOT NULL, DEFAULT etc.

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

	 * @param string $name Name of the property / column

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Parameter comment must end with a full stop

	 * @param string $type mySQL column type

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Parameter comment must end with a full stop

*/

	public static function property( $name, $type, $args = array() ) {

		$class = get_called_class();

		if ( ! isset( static::$properties[ $class ] ) ) {

Bug introduced 2018-09-01 15:32 UTC by

Since $properties is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $properties to at least protected.

			static::$properties[ $class ] = array();

		// "id" columns and those ending on "_id" get an index by default

		$index = $name == 'id' || stripos( $name, '_id' );

introduced 2018-09-01 15:32 UTC by

Found: ==. Use strict comparisons (=== or !==).

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

		// but if the argument is set, it overrides the default

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

		if (isset($args['index'])) {

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

			$index = $args['index'];

		static::$properties[ $class ][] = array(

			'name'  => $name,

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 9 space(s) between "'name'" and double arrow, but found 2.

			'type'  => $type,

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 9 space(s) between "'type'" and double arrow, but found 2.

			'index' => $index,

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 8 space(s) between "'index'" and double arrow, but found 1.

100

			'index_length' => isset($args['index_length']) ? $args['index_length'] : null,

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

101

			'unique' => isset($args['unique']) ? $args['unique'] : null

introduced 2018-09-01 15:32 UTC by

Array double arrow not aligned correctly; expected 7 space(s) between "'unique'" and double arrow, but found 1.

introduced 2018-09-01 15:32 UTC by

Each array item in a multi-line array declaration must end in a comma

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

102

);

103

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

104

105

/**

106

	 * Return a list of property dictionaries.

107

108

	 * @return array property list

109

*/

110

	private static function properties() {

111

		$class = get_called_class();

112

113

		if ( ! isset( static::$properties[ $class ] ) ) {

Bug introduced 2018-09-01 15:32 UTC by

114

			static::$properties[ $class ] = array();

115

116

117

		return static::$properties[ $class ];

118

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

119

120

/**

121

	 * Does the given property exist?

122

123

	 * @param string $name name of the property to test

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Parameter comment must end with a full stop

124

	 * @return bool True if the property exists, else false.

125

*/

126

	public static function has_property( $name ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::has_property" is not in camel caps format

127

		return in_array( $name, static::property_names() );

introduced 2018-09-01 15:32 UTC by

Not using strict comparison for in_array; supply true for third argument.

128

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

129

130

/**

131

	 * Return a list of property names.

132

133

	 * @return array property names

134

*/

135

	public static function property_names() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::property_names" is not in camel caps format

136

		return array_map( function ( $p ) { return $p['name']; } , static::properties() );

Coding Style introduced 2018-09-01 15:32 UTC by

Opening brace must be the last content on the line

Coding Style introduced 2018-09-01 15:32 UTC by

Closing brace of nested function must be on a new line

Coding Style introduced 2018-09-01 15:32 UTC by

It is generally recommended to place each PHP statement on a line by itself.

Coding Style introduced 2023-02-10 12:03 UTC by

Space found before comma in argument list

137

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

138

139

/**

140

	 * Does the table have any entries?

141

142

	 * @return bool True if there is at least one entry, else false.

143

*/

144

	public static function has_entries() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::has_entries" is not in camel caps format

145

		return static::count() > 0;

146

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

147

148

/**

149

	 * Return number of rows in the table.

150

151

	 * @return int number of rows

152

*/

153

	public static function count() {

154

		global $wpdb;

155

156

		$sql = 'SELECT COUNT(*) FROM ' . static::table_name();

157

		return (int) $wpdb->get_var( $sql );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $sql

158

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

159

160

	public static function find_by_id( $id ) {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function find_by_id()

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::find_by_id" is not in camel caps format

161

		global $wpdb;

162

163

		$class = get_called_class();

164

		$model = new $class();

165

		$model->flag_as_not_new();

166

167

		$row = $wpdb->get_row( 'SELECT * FROM ' . static::table_name() . ' WHERE id = ' . (int) $id );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found static

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found ::

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found table_name

168

169

		if ( ! $row ) {

170

			return null;

171

172

173

		foreach ( $row as $property => $value ) {

174

			$model->$property = static::unserialize_property($value);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

175

176

177

		return $model;

178

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

179

180

	public static function find_one_by_property( $property, $value ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::find_one_by_property" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function find_one_by_property()

181

		global $wpdb;

182

183

		$class = get_called_class();

184

		$model = new $class();

185

		$model->flag_as_not_new();

186

187

		$query = $wpdb->prepare('SELECT * FROM ' . static::table_name() . ' WHERE ' . $property .  ' = \'%s\' LIMIT 0,1', $value);

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found static

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found ::

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found table_name

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $property

Coding Style introduced 2018-09-01 15:32 UTC by

Concat operator must be surrounded by a single space

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

introduced 2024-02-06 08:56 UTC by

Simple placeholders should not be quoted in the query string in $wpdb->prepare(). Found: \'%s\'.

188

		$row = $wpdb->get_row($query);

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

introduced 2024-02-06 08:56 UTC by

Use placeholders and $wpdb->prepare(); found $query

189

190

		if ( ! $row ) {

191

			return null;

192

193

194

		foreach ( $row as $property => $value ) {

introduced 2018-09-01 15:32 UTC by

$value is overwriting one of the parameters of this function.

introduced 2018-09-01 15:32 UTC by

$property is overwriting one of the parameters of this function.

195

			$model->$property = static::unserialize_property($value);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

196

197

198

		return $model;

199

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

200

201

/**

202

	 * Retrieve all entries from the table.

203

204

	 * @return array list of model objects

205

*/

206

	public static function all() {

207

		global $wpdb;

208

209

		$class = get_called_class();

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

210

		$models = array();

211

212

		$rows = $wpdb->get_results( 'SELECT * FROM ' . static::table_name() );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found static

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found ::

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found table_name

213

214

		foreach ( $rows as $row ) {

215

			$model = new $class();

216

			$model->flag_as_not_new();

217

			foreach ( $row as $property => $value ) {

218

				$model->$property = static::unserialize_property($value);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

219

220

			$models[] = $model;

221

222

223

		return $models;

224

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

225

226

/**

227

	 * True if not yet saved to database. Else false.

228

*/

229

	public function is_new() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::is_new" is not in camel caps format

230

		return $this->is_new;

231

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

232

233

	public function flag_as_not_new() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::flag_as_not_new" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function flag_as_not_new()

234

		$this->is_new = false;

235

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

236

237

/**

238

	 * Rails-ish update_attributes for easy form handling.

239

240

	 * Takes an array of form values and takes care of serializing it.

241

242

	 * @param  array $attributes

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

243

	 * @return bool

244

*/

245

	public function update_attributes( $attributes ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::update_attributes" is not in camel caps format

246

247

		if ( ! is_array( $attributes ) )

introduced 2018-10-24 12:28 UTC by

The condition is_array($attributes) is always true.

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

248

			return false;

249

250

		$request = filter_input_array(INPUT_POST); // Do this for security reasons

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

251

252

		foreach ( $attributes as $key => $value ) {

253

			if ( is_array($value) ) {

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

254

				$this->{$key} = serialize($value);

introduced 2018-09-01 15:32 UTC by

serialize() found. Serialized data has known vulnerability problems with Object Injection. JSON is generally a better approach for serializing data. See https://www.owasp.org/index.php/PHP_Object_Injection

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

255

			} else {

256

				$this->{$key} = esc_sql($value);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

257

258

259

260

		if ( isset( $request['checkboxes'] ) && is_array( $request['checkboxes'] ) ) {

261

			foreach ( $request['checkboxes'] as $checkbox ) {

262

				if ( isset( $attributes[ $checkbox ] ) && $attributes[ $checkbox ] === 'on' ) {

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

263

					$this->$checkbox = 1;

264

				} else {

265

					$this->$checkbox = 0;

266

267

268

269

270

		// @todo this is the wrong place to do this!

271

		// The feed password is the only "passphrase" which is saved. It is not encrypted!

272

		// However, we keep this function for later use

273

		if ( isset( $request['passwords'] ) && is_array( $request['passwords'] ) ) {

274

			foreach ( $request['passwords'] as $password ) {

275

				$this->$password = $attributes[ $password ];

276

277

278

		return $this->save();

279

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

280

281

/**

282

	 * Update and save a single attribute.

283

introduced 2018-09-01 15:32 UTC by

Spaces must be used for mid-line alignment; tabs are not allowed

284

	 * @param  string $attribute attribute name

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Parameter comment must end with a full stop

285

	 * @param  mixed  $value

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing parameter comment

286

	 * @return (bool) query success

287

*/

288

	public function update_attribute($attribute, $value) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::update_attribute" is not in camel caps format

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening parenthesis; 0 found

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

289

		global $wpdb;

290

291

		$this->$attribute = $value;

292

293

		$sql = sprintf(

294

			"UPDATE %s SET %s = '%s' WHERE id = %s",

295

			static::table_name(),

296

			$attribute,

297

			mysqli_real_escape_string($value),

Bug introduced 2023-02-10 12:03 UTC by

The call to mysqli_real_escape_string() has too few arguments starting with string. ( Ignorable by Annotation )

introduced 2018-09-01 15:32 UTC by

Accessing the database directly should be avoided. Please use the $wpdb object and associated functions instead. Found: mysqli_real_escape_string.

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

298

			$this->id

299

);

300

301

		return $wpdb->query( $sql );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $sql

302

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

303

304

/**

305

	 * Saves changes to database.

306

307

	 * @todo use wpdb::insert()

308

*/

309

	public function save() {

310

		global $wpdb;

311

312

		if ( $this->is_new() ) {

313

314

			$this->set_defaults();

315

316

			$sql = 'INSERT INTO '

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

317

			     . static::table_name()

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

318

			     . ' ( '

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

319

			     . implode( ',', static::property_names() )

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

320

			     . ' ) '

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

321

			     . 'VALUES'

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

322

			     . ' ( '

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

323

			     . implode( ',', array_map( array( $this, 'property_name_to_sql_value' ), static::property_names() ) )

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

324

			     . ' );'

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

325

introduced 2023-02-10 12:03 UTC by

Space found before semicolon; expected "' );';" but found "' );'\n ;"

326

			$success = $wpdb->query( $sql );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $sql

327

			if ( $success ) {

328

				$this->id = $wpdb->insert_id;

Bug Best Practice introduced 2018-09-01 15:32 UTC by

The property id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

329

330

		} else {

331

			$sql = 'UPDATE ' . static::table_name()

332

			     . ' SET '

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

333

			     . implode( ',', array_map( array( $this, 'property_name_to_sql_update_statement' ), static::property_names() ) )

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

334

			     . ' WHERE id = ' . $this->id

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

335

introduced 2023-02-10 12:03 UTC by

Space found before semicolon; expected "id;" but found "id\n ;"

336

337

			$success = $wpdb->query( $sql );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $sql

338

339

340

		$this->is_new = false;

341

342

		do_action('podlove_model_save', $this);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

343

		do_action('podlove_model_change', $this);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

344

345

		return $success;

346

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

347

348

/**

349

	 * Sets default values.

350

351

	 * @return array

352

*/

353

	private function set_defaults() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::set_defaults" is not in camel caps format

354

355

		$defaults = $this->default_values();

356

357

		if ( ! is_array( $defaults ) || empty( $defaults ) )

introduced 2018-10-24 12:28 UTC by

The condition is_array($defaults) is always true.

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

358

			return;

359

360

		foreach ( $defaults as $property => $value ) {

361

			if ( $this->$property === null )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

362

				$this->$property = $value;

363

364

365

366

367

/**

368

	 * Return default values for properties.

369

370

	 * Can be overridden by inheriting model classes.

371

372

	 * @return array

373

*/

374

	public function default_values() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::default_values" is not in camel caps format

375

		return array();

376

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

377

378

	public function delete() {

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function delete()

379

		global $wpdb;

380

381

		$sql = 'DELETE FROM '

382

		     . static::table_name()

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

383

		     . ' WHERE id = ' . $this->id;

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

384

385

		$rows_affected = $wpdb->query( $sql );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $sql

386

387

	    do_action('podlove_model_delete', $this);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

388

	    do_action('podlove_model_change', $this);

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

389

390

		return $rows_affected !== false;

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

391

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

392

393

	private function property_name_to_sql_update_statement( $p ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::property_name_to_sql_update_statement" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function property_name_to_sql_update_statement()

394

		global $wpdb;

395

396

		if ( $this->$p !== null && $this->$p !== '' ) {

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

397

			return sprintf( "%s = '%s'", $p, ( is_array($this->$p) ? serialize($this->$p) : $this->$p ) );

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

introduced 2018-09-01 15:32 UTC by

398

		} else {

399

			return "$p = NULL";

400

401

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

402

403

	private function property_name_to_sql_value( $p ) {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::property_name_to_sql_value" is not in camel caps format

Coding Style Documentation introduced 2018-09-01 15:32 UTC by

Missing doc comment for function property_name_to_sql_value()

404

		global $wpdb;

405

406

		if ( $this->$p !== null && $this->$p !== '' ) {

introduced 2018-09-01 15:32 UTC by

Use Yoda Condition checks, you must.

407

			return sprintf( "'%s'", $this->$p );

408

		} else {

409

			return 'NULL';

410

411

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

412

413

/**

414

	 * Create database table based on defined properties.

415

416

	 * Automatically includes an id column as auto incrementing primary key.

417

	 * @todo allow model changes

Coding Style introduced 2018-09-01 15:32 UTC by

There must be exactly one blank line before the tags in a doc comment

418

*/

419

	public static function build() {

420

		global $wpdb;

421

422

		$property_sql = array();

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

423

		foreach ( static::properties() as $property )

Coding Style Best Practice introduced 2018-09-01 15:32 UTC by

It is generally a best practice to always use braces with control structures.

424

			$property_sql[] = "`{$property['name']}` {$property['type']}";

425

426

		$sql = 'CREATE TABLE IF NOT EXISTS '

427

		     . static::table_name()

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

428

		     . ' ('

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

429

		     . implode( ',', $property_sql )

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

430

		     . ' ) CHARACTER SET utf8;'

introduced 2018-09-01 15:32 UTC by

Found precision alignment of 1 spaces.

431

introduced 2023-02-10 12:03 UTC by

Space found before semicolon; expected "' ) CHARACTER SET utf8;';" but found "' ) CHARACTER SET utf8;'\n ;"

432

433

		$wpdb->query( $sql );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $sql

434

435

		static::build_indices();

436

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

437

438

/**

439

	 * Convention based index generation.

440

441

	 * Creates default indices for all columns matching both:

442

	 * - equals "id" or contains "_id"

443

	 * - doesn't have an index yet

444

*/

445

	public static function build_indices() {

Coding Style introduced 2018-09-01 15:32 UTC by

Method name "Base::build_indices" is not in camel caps format

446

		global $wpdb;

447

448

		$indices_sql = 'SHOW INDEX FROM `' . static::table_name() . '`';

Coding Style introduced 2024-02-06 08:56 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

449

		$indices = $wpdb->get_results( $indices_sql );

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $indices_sql

450

		$index_columns = array_map( function($index){ return $index->Column_name; }, $indices );

introduced 2018-09-01 15:32 UTC by

No space after opening parenthesis is prohibited

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 spaces after opening parenthesis; 0 found

introduced 2018-09-01 15:32 UTC by

No space before closing parenthesis is prohibited

introduced 2018-09-01 15:32 UTC by

Space between opening control structure and closing parenthesis is required

Coding Style introduced 2018-09-01 15:32 UTC by

Opening brace must be the last content on the line

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 space before opening brace; found 0

introduced 2018-09-01 15:32 UTC by

Object property "Column_name" is not in valid snake_case format

Coding Style introduced 2018-09-01 15:32 UTC by

Closing brace of nested function must be on a new line

Coding Style introduced 2018-09-01 15:32 UTC by

It is generally recommended to place each PHP statement on a line by itself.

451

452

		foreach ( static::properties() as $property ) {

453

454

			if ( $property['index'] && ! in_array( $property['name'], $index_columns ) ) {

introduced 2018-09-01 15:32 UTC by

Not using strict comparison for in_array; supply true for third argument.

455

				$length = isset($property['index_length']) ? '(' . (int) $property['index_length'] . ')' : '';

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

456

				$unique = isset($property['unique']) && $property['unique'] ? 'UNIQUE' : '';

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces after opening parenthesis; 0 found

Coding Style introduced 2023-02-10 12:03 UTC by

Expected 1 spaces before closing parenthesis; 0 found

457

				$sql = 'ALTER TABLE `' . static::table_name() . '` ADD ' . $unique . ' INDEX `' . $property['name'] . '` (' . $property['name'] . $length . ')';

Coding Style introduced 2018-09-01 15:32 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

458

				$wpdb->query( $sql );

introduced 2018-09-01 15:32 UTC by

Usage of a direct database call is discouraged.

introduced 2018-09-01 15:32 UTC by

Direct database call without caching detected. Consider using wp_cache_get() / wp_cache_set() or wp_cache_delete().

introduced 2018-09-01 15:32 UTC by

Use placeholders and $wpdb->prepare(); found $sql

459

460

461

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

462

463

/**

464

	 * Model identifier.

465

*/

466

	public static function name() {

467

		// get name of implementing class

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

468

		$table_name = get_called_class();

469

		// replace backslashes from namespace by underscores

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

470

		$table_name = str_replace( '\\', '_', $table_name );

471

		// remove Models subnamespace from name

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

472

		$table_name = str_replace( 'Model_', '', $table_name );

473

		// all lowercase

Coding Style introduced 2018-09-01 15:32 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

474

		$table_name = strtolower( $table_name );

475

476

		return $table_name;

477

Coding Style introduced 2018-09-01 15:32 UTC by

Expected 1 blank line before closing function brace; 0 found

478

podlove / podlove-subscribe-button-wp-plugin

GitHub Access Token became invalid

Base::save() A last analyzed 2024-02-06 12:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Base::save() A
last analyzed 2024-02-06 12:13 UTC