pmochine /
Laravel-Tongue
| Conditions | 15 |
| Paths | 43 |
| Total Lines | 48 |
| Code Lines | 23 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 62 | public function negotiateLanguage() |
||
| 63 | { |
||
| 64 | $matches = $this->getMatchesFromAcceptedLanguages(); |
||
| 65 | |||
| 66 | foreach ($matches as $key => $q) { |
||
| 67 | if (! empty($this->supportedLanguages[$key])) { |
||
| 68 | return $key; |
||
| 69 | } |
||
| 70 | |||
| 71 | if ($this->use_intl) { |
||
| 72 | $key = Locale::canonicalize($key); |
||
| 73 | } |
||
| 74 | |||
| 75 | // Search for acceptable locale by 'regional' => 'af_ZA' or 'lang' => 'af-ZA' match. |
||
| 76 | foreach ($this->supportedLanguages as $key_supported => $locale) { |
||
| 77 | if ((isset($locale['regional']) && $locale['regional'] == $key) |
||
| 78 | || (isset($locale['lang']) && $locale['lang'] == $key) |
||
| 79 | ) { |
||
| 80 | return $key_supported; |
||
| 81 | } |
||
| 82 | } |
||
| 83 | } |
||
| 84 | |||
| 85 | // If any (i.e. "*") is acceptable, return the first supported format |
||
| 86 | if (isset($matches['*'])) { |
||
| 87 | reset($this->supportedLanguages); |
||
| 88 | |||
| 89 | return key($this->supportedLanguages); |
||
| 90 | } |
||
| 91 | |||
| 92 | if ($this->use_intl && ! empty($_SERVER['HTTP_ACCEPT_LANGUAGE'])) { |
||
| 93 | $http_accept_language = Locale::acceptFromHttp($_SERVER['HTTP_ACCEPT_LANGUAGE']); |
||
| 94 | |||
| 95 | if (! empty($this->supportedLanguages[$http_accept_language])) { |
||
| 96 | return $http_accept_language; |
||
| 97 | } |
||
| 98 | } |
||
| 99 | |||
| 100 | if ($this->request->server('REMOTE_HOST')) { |
||
| 101 | $remote_host = explode('.', $this->request->server('REMOTE_HOST')); |
||
| 102 | $lang = strtolower(end($remote_host)); |
||
| 103 | |||
| 104 | if (! empty($this->supportedLanguages[$lang])) { |
||
| 105 | return $lang; |
||
| 106 | } |
||
| 107 | } |
||
| 108 | |||
| 109 | return $this->fallbackLocale; |
||
| 110 | } |
||
| 192 |
Loading history...
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: