Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class JsonApiHydrator extends ArrayHydrator |
||
8 | { |
||
9 | /** |
||
10 | * @link http://jsonapi.org/format/#document-resource-objects |
||
11 | * @param object|string $entity Doctrine entity or class name |
||
12 | * @param array $data Data to hydrate |
||
13 | * |
||
14 | * @return mixed|object |
||
15 | */ |
||
16 | public function hydrate($entity, array $data) |
||
36 | |||
37 | /** |
||
38 | * Map JSON API resource relations to doctrine entity. |
||
39 | * |
||
40 | * @param $entity |
||
41 | * @param array $relationships |
||
42 | * |
||
43 | * @return array |
||
44 | * @throws \Exception |
||
45 | */ |
||
46 | protected function hydrateRelationships($entity, array $relationships) |
||
80 | } |
||
81 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.