ContextStack::create() - Code Metrics - plvhx/promise - Measure and Improve Code Quality continuously with Scrutinizer

ContextStack::create() A
last analyzed 2017-09-25 18:12 UTC

↳ Parent: ContextStack

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php

namespace Gandung\Promise\Context;

use TaskQueue\TaskQueue;
use TaskQueue\Invoker\FunctionInvoker;
use TaskQueue\Invoker\MethodInvoker;
use DependencyInjection\Container;

/**
 * @author Paulus Gandung Prakosa <[email protected]>
 */
class ContextStack
{
    /**
     * @var array
     */
    private static $queueHandler;
    
    /**
     * Statically create an instance of this class.
     *
     * @param TaskQueue
     */
    public static function create()
    {
        if (null === static::$queueHandler) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$queueHandler = new TaskQueue;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        return new static;
    }

    /**
     * Store a value into task queueing stack.
     *
     * @param \Closure|array $handler
     * @param mixed $value
     */
    public function store($handler, $value = [])
    {
        $value = is_array($value)
            ? $value
            : array_slice(func_get_args(), 1);

        if ($handler instanceof \Closure) {
            self::$queueHandler->add(new FunctionInvoker($handler), $value);

        } else {
            self::$queueHandler->add(new MethodInvoker($handler), $value);

        }
    }

    /**
     * Get task queue handler.
     *
     * @return TaskQueue
     */
    public static function getQueueHandler()
    {
        return self::$queueHandler;
    }
}


1			<?php
2
3			namespace Gandung\Promise\Context;
4
5			use TaskQueue\TaskQueue;
6			use TaskQueue\Invoker\FunctionInvoker;
7			use TaskQueue\Invoker\MethodInvoker;
8			use DependencyInjection\Container;
9
10			/**
11			* @author Paulus Gandung Prakosa <[email protected]>
12			*/
13			class ContextStack
14			{
15			/**
16			* @var array
17			*/
18			private static $queueHandler;
19
20			/**
21			* Statically create an instance of this class.
22			*
23			* @param TaskQueue
24			*/
25			public static function create()
26			{
27			if (null === static::$queueHandler) {
			0 ignored issues – show Bug introduced 2017-08-09 20:36 UTC by Report Bug Copy Issue Report Since `$queueHandler` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$queueHandler` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
28			static::$queueHandler = new TaskQueue;
			0 ignored issues – show Bug introduced 2017-09-24 14:11 UTC by Report Bug Copy Issue Report Since `$queueHandler` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$queueHandler` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history... Documentation Bug introduced 2017-09-24 14:11 UTC by Report Bug Copy Issue Report It seems like `new \TaskQueue\TaskQueue()` of type `object<TaskQueue\TaskQueue>` is incompatible with the declared type `array` of property `$queueHandler`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
29			}
30
31			return new static;
32			}
33
34			/**
35			* Store a value into task queueing stack.
36			*
37			* @param \Closure\|array $handler
38			* @param mixed $value
39			*/
40			public function store($handler, $value = [])
41			{
42			$value = is_array($value)
43			? $value
44			: array_slice(func_get_args(), 1);
45
46			if ($handler instanceof \Closure) {
47			self::$queueHandler->add(new FunctionInvoker($handler), $value);
			0 ignored issues – show Bug introduced 2017-08-09 20:36 UTC by Report Bug Copy Issue Report The method `add` cannot be called on `self::$queueHandler` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
48			} else {
49			self::$queueHandler->add(new MethodInvoker($handler), $value);
			0 ignored issues – show Bug introduced 2017-09-24 14:11 UTC by Report Bug Copy Issue Report The method `add` cannot be called on `self::$queueHandler` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
50			}
51			}
52
53			/**
54			* Get task queue handler.
55			*
56			* @return TaskQueue
57			*/
58			public static function getQueueHandler()
59			{
60			return self::$queueHandler;
61			}
62			}
63

plvhx / promise

GitHub Access Token became invalid

ContextStack::create() A last analyzed 2017-09-25 18:12 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ContextStack::create() A
last analyzed 2017-09-25 18:12 UTC