FulfilledPromise - Code Metrics - plvhx/promise - Measure and Improve Code Quality continuously with Scrutinizer

FulfilledPromise A
last analyzed 2017-09-25 18:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	2
dl	0
loc	92
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	10	2
B	then()	25	5
A	resolve()	11	2
A	reject()	8	1
A	currentState()	4	1

<?php

namespace Gandung\Promise;

/**
 * @author Paulus Gandung Prakosa <[email protected]>
 */
class FulfilledPromise implements PromiseInterface
{
    /**
     * @var mixed
     */
    private $value;

    public function __construct($value)
    {
        if (method_exists($value, 'then')) {
            throw new \InvalidArgumentException(
                sprintf("Unable to get instance of %s with promise as constructor parameter.", __CLASS__)
            );
        }

        $this->value = $value;
    }

    /**
     * {@inheritdoc}
     */
    public function then($onFulfilled = null, $onRejected = null)
    {
        if (!$onFulfilled) {
            return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $q = new Promise();
        $value = $this->value;

        Context\ContextStack::create()->store(static function () use ($q, $value, $onFulfilled) {
            if ($q->currentState() === self::STATE_PENDING) {
                try {
                    $q->resolve($onFulfilled($value));
                } catch (\Throwable $e) {

                    $q->reject($e);
                } catch (\Exception $e) {
                    $q->reject($e);
                }
            }
        });

        Context\ContextStack::getQueueHandler()->run();

        
        return $q;
    }

    /**
     * Resolving the promise if given value are equal to current value. Otherwise,
     * throws an exception.
     *
     * @param integer $value
     * @throws \Exception
     */
    public function resolve($value)
    {
        if ($value !== $this->value) {
            throw new \LogicException(
                sprintf(
                    "Supplied value does not strictly equal to current value." .
                    "Cannot resolve promise from context '%s'", __CLASS__
                )
            );
        }
    }

    /**
     * Rejecting this promise will throw an exception because the state of current
     * promise is fulfilled.
     *
     * @param mixed $reason
     * @throws \Exception
     */
    public function reject($reason)
    {
        throw new \LogicException(
            sprintf(
                "Cannot rejected a promise from context '%s'", __CLASS__
            )
        );
    }

    /**
     * Return the state of current promise.
     *
     * @return integer
     */
    public function currentState()
    {
        return self::STATE_FULFILLED;
    }
}


1			<?php
2
3			namespace Gandung\Promise;
4
5			/**
6			* @author Paulus Gandung Prakosa <[email protected]>
7			*/
8			class FulfilledPromise implements PromiseInterface
9			{
10			/**
11			* @var mixed
12			*/
13			private $value;
14
15			public function __construct($value)
16			{
17			if (method_exists($value, 'then')) {
18			throw new \InvalidArgumentException(
19			sprintf("Unable to get instance of %s with promise as constructor parameter.", __CLASS__)
20			);
21			}
22
23			$this->value = $value;
24			}
25
26			/**
27			* {@inheritdoc}
28			*/
29			public function then($onFulfilled = null, $onRejected = null)
30			{
31			if (!$onFulfilled) {
32			return $this;
			0 ignored issues – show Bug Best Practice introduced 2017-08-12 16:48 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`Gandung\Promise\FulfilledPromise`) is incompatible with the return type declared by the interface `Gandung\Promise\PromiseInterface::then` of type `Gandung\Promise\Promise`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
33			}
34
35			$q = new Promise();
36			$value = $this->value;
37
38			Context\ContextStack::create()->store(static function () use ($q, $value, $onFulfilled) {
39			if ($q->currentState() === self::STATE_PENDING) {
40			try {
41			$q->resolve($onFulfilled($value));
42			} catch (\Throwable $e) {
			0 ignored issues – show Bug introduced 2017-08-11 15:51 UTC by Report Bug Copy Issue Report The class `Throwable` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
43			$q->reject($e);
44			} catch (\Exception $e) {
45			$q->reject($e);
46			}
47			}
48			});
49
50			Context\ContextStack::getQueueHandler()->run();
			0 ignored issues – show Bug introduced 2017-08-09 20:36 UTC by Report Bug Copy Issue Report The method `run` cannot be called on `\Gandung\Promise\Context...tack::getQueueHandler()` (of type `array`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
51
52			return $q;
53			}
54
55			/**
56			* Resolving the promise if given value are equal to current value. Otherwise,
57			* throws an exception.
58			*
59			* @param integer $value
60			* @throws \Exception
61			*/
62			public function resolve($value)
63			{
64			if ($value !== $this->value) {
65			throw new \LogicException(
66			sprintf(
67			"Supplied value does not strictly equal to current value." .
68			"Cannot resolve promise from context '%s'", __CLASS__
69			)
70			);
71			}
72			}
73
74			/**
75			* Rejecting this promise will throw an exception because the state of current
76			* promise is fulfilled.
77			*
78			* @param mixed $reason
79			* @throws \Exception
80			*/
81			public function reject($reason)
82			{
83			throw new \LogicException(
84			sprintf(
85			"Cannot rejected a promise from context '%s'", __CLASS__
86			)
87			);
88			}
89
90			/**
91			* Return the state of current promise.
92			*
93			* @return integer
94			*/
95			public function currentState()
96			{
97			return self::STATE_FULFILLED;
98			}
99			}
100

plvhx / promise

GitHub Access Token became invalid

FulfilledPromise A last analyzed 2017-09-25 18:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like

FulfilledPromise A
last analyzed 2017-09-25 18:12 UTC