Issues in bootstrap.php - All Issues - Inspection of ".." - plvhx/dependency-injection - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (ad06b6)

by Paulus Gandung

created 2017-06-04 16:28 UTC

All Issues
New 0

bootstrap.php (1 issue)

Labels

Best Practice 1
Security 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

@trigger_error("This autoloader just for dummy testing. Just run 'composer dump-autoload --optimize' and you're set.", E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

\spl_autoload_register(function($className) {
	$rootDir = __DIR__ . DIRECTORY_SEPARATOR . 'src';

	$namespace = 'DependencyInjection';

	$className = str_replace(
		'\\',
		DIRECTORY_SEPARATOR,
		str_replace($namespace, $rootDir, $className)
	);

	$className .= '.php';

	if ($file = stream_resolve_include_path($className)) {
		require_once $file;
	}
});


1			<?php
2
3			@trigger_error("This autoloader just for dummy testing. Just run 'composer dump-autoload --optimize' and you're set.", E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2017-05-31 02:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
4
5			\spl_autoload_register(function($className) {
6			$rootDir = __DIR__ . DIRECTORY_SEPARATOR . 'src';
7
8			$namespace = 'DependencyInjection';
9
10			$className = str_replace(
11			'\\',
12			DIRECTORY_SEPARATOR,
13			str_replace($namespace, $rootDir, $className)
14			);
15
16			$className .= '.php';
17
18			if ($file = stream_resolve_include_path($className)) {
19			require_once $file;
20			}
21			});
22

plvhx / dependency-injection

Branch — master (ad06b6)

bootstrap.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like