Pluswerk\TypoScriptAutoFixer\Issue\IssueCollection

Complexity

Total Complexity

10

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	rewind()	0	3	1
A	count()	0	3	1
A	key()	0	3	1
A	add()	0	14	4
A	next()	0	3	1
A	current()	0	3	1
A	valid()	0	3	1

<?php
declare(strict_types=1);

namespace Pluswerk\TypoScriptAutoFixer\Issue;

use Helmich\TypoScriptLint\Linter\Report\Issue;
use Pluswerk\TypoScriptAutoFixer\Issue\AbstractIssue;

class IssueCollection implements \Countable, \Iterator
{
    /**
     * @var AbstractIssue[]
     */
    private $issues = [];

    /**
     * @param AbstractIssue $issue
     */
    public function add(AbstractIssue $issue): void
    {
        $this->issues[] = $issue;
        usort($this->issues, static function ($a, $b) {
            /** @var AbstractIssue $a */
            /** @var AbstractIssue $b */
            if ($a->line() > $b->line()) {
                return 1;
            }
            if ($a->line() < $b->line()) {
                return -1;
            }
            if ($a->line() === $b->line()) {
                return 0;
            }
        });
    }

    /**
     * @return AbstractIssue
     */
    public function current(): AbstractIssue
    {
        return current($this->issues);
    }

    /**
     * @return void
     */
    public function next(): void
    {
        next($this->issues);
    }

    /**
     * @return int
     */
    public function key(): int
    {
        return key($this->issues);

The expression return key($this->issues) could return the type null|string which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }

    /**
     * @return bool
     */
    public function valid(): bool
    {
        return key($this->issues) !== null;
    }

    /**
     * @return void
     */
    public function rewind(): void
    {
        reset($this->issues);
    }

    /**
     * @return int
     */
    public function count(): int
    {
        return count($this->issues);
    }
}