Pluswerk\TypoScriptAutoFixer\Fixer\NestingConsistency\Identifier

Complexity

Total Complexity

9

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	rewind()	0	3	1
A	current()	0	3	1
A	reverseItems()	0	6	2
A	valid()	0	3	1
A	next()	0	3	1
A	key()	0	3	1
A	count()	0	3	1
A	__construct()	0	3	1

<?php
declare(strict_types=1);

namespace Pluswerk\TypoScriptAutoFixer\Fixer\NestingConsistency;

final class Identifier implements \Iterator, \Countable
{
    /**
     * @var array
     */
    private $items;

    /**
     * @var Identifier
     */
    private $reverseItems = null;

    /**
     * Identifier constructor.
     *
     * @param string $identifier
     */
    public function __construct(string $identifier)
    {
        $this->items = explode('.', $identifier);
    }

    /**
     * @return string
     */
    public function current(): string
    {
        return current($this->items);
    }

    /**
     * @return void
     */
    public function next(): void
    {
        next($this->items);
    }

    /**
     * @return int
     */
    public function key(): int
    {
        return key($this->items);

The expression return key($this->items) could return the type null|string which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }

    /**
     * @return bool
     */
    public function valid(): bool
    {
        return key($this->items) !== null;
    }

    /**
     * @return void
     */
    public function rewind(): void
    {
        reset($this->items);
    }

    /**
     * @return int
     */
    public function count(): int
    {
        return count($this->items);
    }

    /**
     * @return Identifier
     */
    public function reverseItems(): Identifier
    {
        if (!($this->reverseItems instanceof Identifier)) {

$this->reverseItems is always a sub-type of Pluswerk\TypoScriptAutoFixer\Fixer\NestingConsistency\Identifier.

            $this->reverseItems = new Identifier(implode('.', array_reverse($this->items)));
        }
        return $this->reverseItems;
    }
}