Complex classes like Client often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Client, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class Client |
||
11 | { |
||
12 | const RESPONSE_SHORT = 1; |
||
13 | const RESPONSE_FULL = 2; |
||
14 | |||
15 | protected $_host; |
||
16 | protected $_port; |
||
17 | protected $_protocol; |
||
18 | protected $_login; |
||
19 | protected $_password; |
||
20 | protected $_secretKey; |
||
21 | protected $_version = ''; |
||
22 | |||
23 | protected static $_isExecutionsLogEnabled = false; |
||
24 | protected static $_executionLog = []; |
||
25 | |||
26 | protected $_operatorsCache = []; |
||
27 | |||
28 | /** |
||
29 | * @var callable |
||
30 | */ |
||
31 | protected $_verifyResponseCallback; |
||
32 | |||
33 | /** |
||
34 | * Create client |
||
35 | * |
||
36 | * @param string $host |
||
37 | * @param int $port |
||
38 | * @param string $protocol |
||
39 | */ |
||
40 | public function __construct($host, $port = 8443, $protocol = 'https') |
||
46 | |||
47 | /** |
||
48 | * Setup credentials for authentication |
||
49 | * |
||
50 | * @param string $login |
||
51 | * @param string $password |
||
52 | */ |
||
53 | public function setCredentials($login, $password) |
||
58 | |||
59 | /** |
||
60 | * Define secret key for alternative authentication |
||
61 | * |
||
62 | * @param string $secretKey |
||
63 | */ |
||
64 | public function setSecretKey($secretKey) |
||
68 | |||
69 | /** |
||
70 | * Set default version for requests |
||
71 | * |
||
72 | * @param string $version |
||
73 | */ |
||
74 | public function setVersion($version) |
||
78 | |||
79 | /** |
||
80 | * Set custom function to verify response of API call according your own needs. Default verifying will be used if it is not specified |
||
81 | * |
||
82 | * @param callable|null $function |
||
83 | */ |
||
84 | public function setVerifyResponse(callable $function = null) |
||
88 | |||
89 | /** |
||
90 | * Retrieve host used for communication |
||
91 | * |
||
92 | * @return string |
||
93 | */ |
||
94 | public function getHost() |
||
98 | |||
99 | /** |
||
100 | * Retrieve port used for communication |
||
101 | * |
||
102 | * @return int |
||
103 | */ |
||
104 | public function getPort() |
||
108 | |||
109 | /** |
||
110 | * Retrieve name of the protocol (http or https) used for communication |
||
111 | * |
||
112 | * @return string |
||
113 | */ |
||
114 | public function getProtocol() |
||
118 | |||
119 | /** |
||
120 | * Retrieve XML template for packet |
||
121 | * |
||
122 | * @param string|null $version |
||
123 | * @return SimpleXMLElement |
||
124 | */ |
||
125 | public function getPacket($version = null) |
||
132 | |||
133 | /** |
||
134 | * Perform API request |
||
135 | * |
||
136 | * @param string|array|SimpleXMLElement $request |
||
137 | * @param int $mode |
||
138 | * @return XmlResponse |
||
139 | */ |
||
140 | public function request($request, $mode = self::RESPONSE_SHORT) |
||
168 | |||
169 | /** |
||
170 | * Perform HTTP request to end-point |
||
171 | * |
||
172 | * @param string $request |
||
173 | * @return XmlResponse |
||
174 | * @throws Client\Exception |
||
175 | */ |
||
176 | private function _performHttpRequest($request) |
||
207 | |||
208 | /** |
||
209 | * Perform multiple API requests using single HTTP request |
||
210 | * |
||
211 | * @param $requests |
||
212 | * @param int $mode |
||
213 | * @return array |
||
214 | * @throws Client\Exception |
||
215 | */ |
||
216 | public function multiRequest($requests, $mode = self::RESPONSE_SHORT) |
||
255 | |||
256 | /** |
||
257 | * Retrieve list of headers needed for request |
||
258 | * |
||
259 | * @return array |
||
260 | */ |
||
261 | protected function _getHeaders() |
||
277 | |||
278 | /** |
||
279 | * Enable or disable execution log |
||
280 | * |
||
281 | * @param bool $enable |
||
282 | */ |
||
283 | public static function enableExecutionLog($enable = true) |
||
287 | |||
288 | /** |
||
289 | * Retrieve execution log |
||
290 | * |
||
291 | * @return array |
||
292 | */ |
||
293 | public static function getExecutionLog() |
||
297 | |||
298 | /** |
||
299 | * Verify that response does not contain errors |
||
300 | * |
||
301 | * @param XmlResponse $xml |
||
302 | * @throws Exception |
||
303 | */ |
||
304 | protected function _verifyResponse($xml) |
||
316 | |||
317 | /** |
||
318 | * Expand short syntax (some.method.call) into full XML representation |
||
319 | * |
||
320 | * @param string $request |
||
321 | * @param SimpleXMLElement $xml |
||
322 | * @return string |
||
323 | */ |
||
324 | protected function _expandRequestShortSyntax($request, SimpleXMLElement $xml) |
||
336 | |||
337 | /** |
||
338 | * Convert array to XML representation |
||
339 | * |
||
340 | * @param array $array |
||
341 | * @param SimpleXMLElement $xml |
||
342 | * @return SimpleXMLElement |
||
343 | */ |
||
344 | protected function _arrayToXml(array $array, SimpleXMLElement $xml) |
||
356 | |||
357 | /** |
||
358 | * @param string $name |
||
359 | * @return \PleskX\Api\Operator |
||
360 | */ |
||
361 | protected function _getOperator($name) |
||
370 | |||
371 | /** |
||
372 | * @return Operator\Server |
||
373 | */ |
||
374 | public function server() |
||
378 | |||
379 | /** |
||
380 | * @return Operator\Customer |
||
381 | */ |
||
382 | public function customer() |
||
386 | |||
387 | /** |
||
388 | * @return Operator\Webspace |
||
389 | */ |
||
390 | public function webspace() |
||
394 | |||
395 | /** |
||
396 | * @return Operator\Subdomain |
||
397 | */ |
||
398 | public function subdomain() |
||
402 | |||
403 | /** |
||
404 | * @return Operator\Dns |
||
405 | */ |
||
406 | public function dns() |
||
410 | |||
411 | /** |
||
412 | * @return Operator\DatabaseServer |
||
413 | */ |
||
414 | public function databaseServer() |
||
418 | |||
419 | /** |
||
420 | * @return Operator\Mail |
||
421 | */ |
||
422 | public function mail() |
||
426 | |||
427 | /** |
||
428 | * @return Operator\Migration |
||
429 | */ |
||
430 | public function migration() |
||
434 | |||
435 | /** |
||
436 | * @return Operator\Certificate |
||
437 | */ |
||
438 | public function certificate() |
||
442 | |||
443 | /** |
||
444 | * @return Operator\SiteAlias |
||
445 | */ |
||
446 | public function siteAlias() |
||
450 | |||
451 | /** |
||
452 | * @return Operator\Ip |
||
453 | */ |
||
454 | public function ip() |
||
458 | |||
459 | /** |
||
460 | * @return Operator\EventLog |
||
461 | */ |
||
462 | public function eventLog() |
||
466 | |||
467 | /** |
||
468 | * @return Operator\SpamFilter |
||
469 | */ |
||
470 | public function spamFilter() |
||
474 | |||
475 | /** |
||
476 | * @return Operator\SecretKey |
||
477 | */ |
||
478 | public function secretKey() |
||
482 | |||
483 | /** |
||
484 | * @return Operator\Ui |
||
485 | */ |
||
486 | public function ui() |
||
490 | |||
491 | /** |
||
492 | * @return Operator\ServicePlan |
||
493 | */ |
||
494 | public function servicePlan() |
||
498 | |||
499 | /** |
||
500 | * @return Operator\WebUser |
||
501 | */ |
||
502 | public function webUser() |
||
506 | |||
507 | /** |
||
508 | * @return Operator\MailList |
||
509 | */ |
||
510 | public function mailList() |
||
514 | |||
515 | /** |
||
516 | * @return Operator\VirtualDirectory |
||
517 | */ |
||
518 | public function virtualDirectory() |
||
522 | |||
523 | /** |
||
524 | * @return Operator\Database |
||
525 | */ |
||
526 | public function database() |
||
530 | |||
531 | /** |
||
532 | * @return Operator\FtpUser |
||
533 | */ |
||
534 | public function ftpUser() |
||
538 | |||
539 | /** |
||
540 | * @return Operator\Session |
||
541 | */ |
||
542 | public function session() |
||
546 | |||
547 | /** |
||
548 | * @return Operator\Updater |
||
549 | */ |
||
550 | public function updater() |
||
554 | |||
555 | /** |
||
556 | * @return Operator\Locale |
||
557 | */ |
||
558 | public function locale() |
||
562 | |||
563 | /** |
||
564 | * @return Operator\LogRotation |
||
565 | */ |
||
566 | public function logRotation() |
||
570 | |||
571 | /** |
||
572 | * @return Operator\BackupManager |
||
573 | */ |
||
574 | public function backupManager() |
||
578 | |||
579 | /** |
||
580 | * @return Operator\Sso |
||
581 | */ |
||
582 | public function sso() |
||
586 | |||
587 | /** |
||
588 | * @return Operator\ProtectedDirectory |
||
589 | */ |
||
590 | public function protectedDirectory() |
||
594 | |||
595 | /** |
||
596 | * @return Operator\Reseller |
||
597 | */ |
||
598 | public function reseller() |
||
602 | |||
603 | /** |
||
604 | * @return Operator\ResellerPlan |
||
605 | */ |
||
606 | public function resellerPlan() |
||
610 | |||
611 | /** |
||
612 | * @return Operator\Aps |
||
613 | */ |
||
614 | public function aps() |
||
618 | |||
619 | /** |
||
620 | * @return Operator\ServicePlanAddon |
||
621 | */ |
||
622 | public function servicePlanAddon() |
||
626 | |||
627 | /** |
||
628 | * @return Operator\Site |
||
629 | */ |
||
630 | public function site() |
||
634 | |||
635 | /** |
||
636 | * @return Operator\User |
||
637 | */ |
||
638 | public function user() |
||
642 | |||
643 | /** |
||
644 | * @return Operator\Role |
||
645 | */ |
||
646 | public function role() |
||
650 | |||
651 | /** |
||
652 | * @return Operator\BusinessLogicUpgrade |
||
653 | */ |
||
654 | public function businessLogicUpgrade() |
||
658 | |||
659 | /** |
||
660 | * @return Operator\Webmail |
||
661 | */ |
||
662 | public function webmail() |
||
666 | |||
667 | /** |
||
668 | * @return Operator\PlanItem |
||
669 | */ |
||
670 | public function planItem() |
||
674 | |||
675 | /** |
||
676 | * @return Operator\Sitebuilder |
||
677 | */ |
||
678 | public function sitebuilder() |
||
682 | |||
683 | /** |
||
684 | * @return Operator\ServiceNode |
||
685 | */ |
||
686 | public function serviceNode() |
||
690 | |||
691 | /** |
||
692 | * @return Operator\IpBan |
||
693 | */ |
||
694 | public function ipBan() |
||
698 | |||
699 | /** |
||
700 | * @return Operator\WpInstance |
||
701 | */ |
||
702 | public function wpInstance() |
||
706 | |||
707 | } |
||
708 |