PleskX\Api\Operator\SecretKey

Complexity

Total Complexity

7

Size/Duplication

Total Lines	70
Duplicated Lines	27.14 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	7	1
A	delete()	0	4	1
A	get()	0	5	1
A	getAll()	0	4	1
A	_get()	19	19	3

<?php
// Copyright 1999-2016. Parallels IP Holdings GmbH.

namespace PleskX\Api\Operator;
use PleskX\Api\Struct\SecretKey as Struct;

class SecretKey extends \PleskX\Api\Operator
{

    protected $_wrapperTag = 'secret_key';

    /**
     * @param string $ipAddress
     * @return string
     */
    public function create($ipAddress)
    {
        $packet = $this->_client->getPacket();
        $packet->addChild($this->_wrapperTag)->addChild('create')->addChild('ip_address', $ipAddress);
        $response = $this->_client->request($packet);
        return (string)$response->key;
    }

    /**
     * @param string $keyId
     * @return bool
     */
    public function delete($keyId)
    {
        return $this->_delete('key', $keyId, 'delete');
    }

    /**
     * @param string $keyId
     * @return Struct\Info
     */
    public function get($keyId)
    {
        $items = $this->_get($keyId);
        return reset($items);

The expression reset($items); of type PleskX\Api\Struct\SecretKey\Info|false adds false to the return on line 40 which is incompatible with the return type documented by PleskX\Api\Operator\SecretKey::get of type PleskX\Api\Struct\SecretKey\Info. It seems like you forgot to handle an error condition.

    }

    /**
     * @return Struct\Info[]
     */
    public function getAll()
    {
        return $this->_get();
    }

    /**
     * @param string $field

There is no parameter named $field. Was it maybe removed?

     * @param integer|string $value

There is no parameter named $value. Was it maybe removed?

     * @return Struct\Info[]
     */
    public function _get($keyId = null)

This method seems to be duplicated in your project.

    {
        $packet = $this->_client->getPacket();
        $getTag = $packet->addChild($this->_wrapperTag)->addChild('get_info');

        $filterTag = $getTag->addChild('filter');
        if (!is_null($keyId)) {
            $filterTag->addChild('key', $keyId);
        }

        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);

        $items = [];
        foreach ($response->xpath('//result') as $xmlResult) {
            $items[] = new Struct\Info($xmlResult->key_info);
        }

        return $items;
    }

}