Complex classes like Client often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Client, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class Client |
||
| 11 | { |
||
| 12 | const RESPONSE_SHORT = 1; |
||
| 13 | const RESPONSE_FULL = 2; |
||
| 14 | |||
| 15 | protected $_host; |
||
| 16 | protected $_port; |
||
| 17 | protected $_protocol; |
||
| 18 | protected $_login; |
||
| 19 | protected $_password; |
||
| 20 | protected $_secretKey; |
||
| 21 | protected $_version = ''; |
||
| 22 | |||
| 23 | protected static $_isExecutionsLogEnabled = false; |
||
| 24 | protected static $_executionLog = []; |
||
| 25 | |||
| 26 | protected $_operatorsCache = []; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var callable |
||
| 30 | */ |
||
| 31 | protected $_verifyResponseCallback; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * Create client |
||
| 35 | * |
||
| 36 | * @param string $host |
||
| 37 | * @param int $port |
||
| 38 | * @param string $protocol |
||
| 39 | */ |
||
| 40 | public function __construct($host, $port = 8443, $protocol = 'https') |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Setup credentials for authentication |
||
| 49 | * |
||
| 50 | * @param string $login |
||
| 51 | * @param string $password |
||
| 52 | */ |
||
| 53 | public function setCredentials($login, $password) |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Define secret key for alternative authentication |
||
| 61 | * |
||
| 62 | * @param string $secretKey |
||
| 63 | */ |
||
| 64 | public function setSecretKey($secretKey) |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Set default version for requests |
||
| 71 | * |
||
| 72 | * @param string $version |
||
| 73 | */ |
||
| 74 | public function setVersion($version) |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Set custom function to verify response of API call according your own needs. Default verifying will be used if it is not specified |
||
| 81 | * |
||
| 82 | * @param callable|null $function |
||
| 83 | */ |
||
| 84 | public function setVerifyResponse(callable $function = null) |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Retrieve host used for communication |
||
| 91 | * |
||
| 92 | * @return string |
||
| 93 | */ |
||
| 94 | public function getHost() |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Retrieve port used for communication |
||
| 101 | * |
||
| 102 | * @return int |
||
| 103 | */ |
||
| 104 | public function getPort() |
||
| 108 | |||
| 109 | /** |
||
| 110 | * Retrieve name of the protocol (http or https) used for communication |
||
| 111 | * |
||
| 112 | * @return string |
||
| 113 | */ |
||
| 114 | public function getProtocol() |
||
| 118 | |||
| 119 | /** |
||
| 120 | * Retrieve XML template for packet |
||
| 121 | * |
||
| 122 | * @param string|null $version |
||
| 123 | * @return SimpleXMLElement |
||
| 124 | */ |
||
| 125 | public function getPacket($version = null) |
||
| 132 | |||
| 133 | /** |
||
| 134 | * Perform API request |
||
| 135 | * |
||
| 136 | * @param string|array|SimpleXMLElement $request |
||
| 137 | * @param int $mode |
||
| 138 | * @return XmlResponse |
||
| 139 | */ |
||
| 140 | public function request($request, $mode = self::RESPONSE_SHORT) |
||
| 168 | |||
| 169 | /** |
||
| 170 | * Perform HTTP request to end-point |
||
| 171 | * |
||
| 172 | * @param string $request |
||
| 173 | * @return XmlResponse |
||
| 174 | * @throws Client\Exception |
||
| 175 | */ |
||
| 176 | private function _performHttpRequest($request) |
||
| 207 | |||
| 208 | /** |
||
| 209 | * Perform multiple API requests using single HTTP request |
||
| 210 | * |
||
| 211 | * @param $requests |
||
| 212 | * @param int $mode |
||
| 213 | * @return array |
||
| 214 | * @throws Client\Exception |
||
| 215 | */ |
||
| 216 | public function multiRequest($requests, $mode = self::RESPONSE_SHORT) |
||
| 255 | |||
| 256 | /** |
||
| 257 | * Retrieve list of headers needed for request |
||
| 258 | * |
||
| 259 | * @return array |
||
| 260 | */ |
||
| 261 | protected function _getHeaders() |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Enable or disable execution log |
||
| 280 | * |
||
| 281 | * @param bool $enable |
||
| 282 | */ |
||
| 283 | public static function enableExecutionLog($enable = true) |
||
| 287 | |||
| 288 | /** |
||
| 289 | * Retrieve execution log |
||
| 290 | * |
||
| 291 | * @return array |
||
| 292 | */ |
||
| 293 | public static function getExecutionLog() |
||
| 297 | |||
| 298 | /** |
||
| 299 | * Verify that response does not contain errors |
||
| 300 | * |
||
| 301 | * @param XmlResponse $xml |
||
| 302 | * @throws Exception |
||
| 303 | */ |
||
| 304 | protected function _verifyResponse($xml) |
||
| 316 | |||
| 317 | /** |
||
| 318 | * Expand short syntax (some.method.call) into full XML representation |
||
| 319 | * |
||
| 320 | * @param string $request |
||
| 321 | * @param SimpleXMLElement $xml |
||
| 322 | * @return string |
||
| 323 | */ |
||
| 324 | protected function _expandRequestShortSyntax($request, SimpleXMLElement $xml) |
||
| 336 | |||
| 337 | /** |
||
| 338 | * Convert array to XML representation |
||
| 339 | * |
||
| 340 | * @param array $array |
||
| 341 | * @param SimpleXMLElement $xml |
||
| 342 | * @param string $parentEl |
||
| 343 | * @return SimpleXMLElement |
||
| 344 | */ |
||
| 345 | protected function _arrayToXml(array $array, SimpleXMLElement $xml, $parentEl = null) |
||
| 358 | |||
| 359 | /** |
||
| 360 | * @param array $array |
||
| 361 | * @return bool |
||
| 362 | */ |
||
| 363 | protected function _isAssocArray(array $array) |
||
| 367 | |||
| 368 | /** |
||
| 369 | * @param string $name |
||
| 370 | * @return \PleskX\Api\Operator |
||
| 371 | */ |
||
| 372 | protected function _getOperator($name) |
||
| 381 | |||
| 382 | /** |
||
| 383 | * @return Operator\Server |
||
| 384 | */ |
||
| 385 | public function server() |
||
| 389 | |||
| 390 | /** |
||
| 391 | * @return Operator\Customer |
||
| 392 | */ |
||
| 393 | public function customer() |
||
| 397 | |||
| 398 | /** |
||
| 399 | * @return Operator\Webspace |
||
| 400 | */ |
||
| 401 | public function webspace() |
||
| 405 | |||
| 406 | /** |
||
| 407 | * @return Operator\Subdomain |
||
| 408 | */ |
||
| 409 | public function subdomain() |
||
| 413 | |||
| 414 | /** |
||
| 415 | * @return Operator\Dns |
||
| 416 | */ |
||
| 417 | public function dns() |
||
| 421 | |||
| 422 | /** |
||
| 423 | * @return Operator\DatabaseServer |
||
| 424 | */ |
||
| 425 | public function databaseServer() |
||
| 429 | |||
| 430 | /** |
||
| 431 | * @return Operator\Mail |
||
| 432 | */ |
||
| 433 | public function mail() |
||
| 437 | |||
| 438 | /** |
||
| 439 | * @return Operator\Migration |
||
| 440 | */ |
||
| 441 | public function migration() |
||
| 445 | |||
| 446 | /** |
||
| 447 | * @return Operator\Certificate |
||
| 448 | */ |
||
| 449 | public function certificate() |
||
| 453 | |||
| 454 | /** |
||
| 455 | * @return Operator\SiteAlias |
||
| 456 | */ |
||
| 457 | public function siteAlias() |
||
| 461 | |||
| 462 | /** |
||
| 463 | * @return Operator\Ip |
||
| 464 | */ |
||
| 465 | public function ip() |
||
| 469 | |||
| 470 | /** |
||
| 471 | * @return Operator\EventLog |
||
| 472 | */ |
||
| 473 | public function eventLog() |
||
| 477 | |||
| 478 | /** |
||
| 479 | * @return Operator\SpamFilter |
||
| 480 | */ |
||
| 481 | public function spamFilter() |
||
| 485 | |||
| 486 | /** |
||
| 487 | * @return Operator\SecretKey |
||
| 488 | */ |
||
| 489 | public function secretKey() |
||
| 493 | |||
| 494 | /** |
||
| 495 | * @return Operator\Ui |
||
| 496 | */ |
||
| 497 | public function ui() |
||
| 501 | |||
| 502 | /** |
||
| 503 | * @return Operator\ServicePlan |
||
| 504 | */ |
||
| 505 | public function servicePlan() |
||
| 509 | |||
| 510 | /** |
||
| 511 | * @return Operator\WebUser |
||
| 512 | */ |
||
| 513 | public function webUser() |
||
| 517 | |||
| 518 | /** |
||
| 519 | * @return Operator\MailList |
||
| 520 | */ |
||
| 521 | public function mailList() |
||
| 525 | |||
| 526 | /** |
||
| 527 | * @return Operator\VirtualDirectory |
||
| 528 | */ |
||
| 529 | public function virtualDirectory() |
||
| 533 | |||
| 534 | /** |
||
| 535 | * @return Operator\Database |
||
| 536 | */ |
||
| 537 | public function database() |
||
| 541 | |||
| 542 | /** |
||
| 543 | * @return Operator\FtpUser |
||
| 544 | */ |
||
| 545 | public function ftpUser() |
||
| 549 | |||
| 550 | /** |
||
| 551 | * @return Operator\Session |
||
| 552 | */ |
||
| 553 | public function session() |
||
| 557 | |||
| 558 | /** |
||
| 559 | * @return Operator\Updater |
||
| 560 | */ |
||
| 561 | public function updater() |
||
| 565 | |||
| 566 | /** |
||
| 567 | * @return Operator\Locale |
||
| 568 | */ |
||
| 569 | public function locale() |
||
| 573 | |||
| 574 | /** |
||
| 575 | * @return Operator\LogRotation |
||
| 576 | */ |
||
| 577 | public function logRotation() |
||
| 581 | |||
| 582 | /** |
||
| 583 | * @return Operator\BackupManager |
||
| 584 | */ |
||
| 585 | public function backupManager() |
||
| 589 | |||
| 590 | /** |
||
| 591 | * @return Operator\Sso |
||
| 592 | */ |
||
| 593 | public function sso() |
||
| 597 | |||
| 598 | /** |
||
| 599 | * @return Operator\ProtectedDirectory |
||
| 600 | */ |
||
| 601 | public function protectedDirectory() |
||
| 605 | |||
| 606 | /** |
||
| 607 | * @return Operator\Reseller |
||
| 608 | */ |
||
| 609 | public function reseller() |
||
| 613 | |||
| 614 | /** |
||
| 615 | * @return Operator\ResellerPlan |
||
| 616 | */ |
||
| 617 | public function resellerPlan() |
||
| 621 | |||
| 622 | /** |
||
| 623 | * @return Operator\Aps |
||
| 624 | */ |
||
| 625 | public function aps() |
||
| 629 | |||
| 630 | /** |
||
| 631 | * @return Operator\ServicePlanAddon |
||
| 632 | */ |
||
| 633 | public function servicePlanAddon() |
||
| 637 | |||
| 638 | /** |
||
| 639 | * @return Operator\Site |
||
| 640 | */ |
||
| 641 | public function site() |
||
| 645 | |||
| 646 | /** |
||
| 647 | * @return Operator\User |
||
| 648 | */ |
||
| 649 | public function user() |
||
| 653 | |||
| 654 | /** |
||
| 655 | * @return Operator\Role |
||
| 656 | */ |
||
| 657 | public function role() |
||
| 661 | |||
| 662 | /** |
||
| 663 | * @return Operator\BusinessLogicUpgrade |
||
| 664 | */ |
||
| 665 | public function businessLogicUpgrade() |
||
| 669 | |||
| 670 | /** |
||
| 671 | * @return Operator\Webmail |
||
| 672 | */ |
||
| 673 | public function webmail() |
||
| 677 | |||
| 678 | /** |
||
| 679 | * @return Operator\PlanItem |
||
| 680 | */ |
||
| 681 | public function planItem() |
||
| 685 | |||
| 686 | /** |
||
| 687 | * @return Operator\Sitebuilder |
||
| 688 | */ |
||
| 689 | public function sitebuilder() |
||
| 693 | |||
| 694 | /** |
||
| 695 | * @return Operator\ServiceNode |
||
| 696 | */ |
||
| 697 | public function serviceNode() |
||
| 701 | |||
| 702 | /** |
||
| 703 | * @return Operator\IpBan |
||
| 704 | */ |
||
| 705 | public function ipBan() |
||
| 709 | |||
| 710 | /** |
||
| 711 | * @return Operator\WpInstance |
||
| 712 | */ |
||
| 713 | public function wpInstance() |
||
| 717 | |||
| 718 | } |
||
| 719 |