Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Client often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Client, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class Client |
||
11 | { |
||
12 | const RESPONSE_SHORT = 1; |
||
13 | const RESPONSE_FULL = 2; |
||
14 | |||
15 | protected $_host; |
||
16 | protected $_port; |
||
17 | protected $_protocol; |
||
18 | protected $_login; |
||
19 | protected $_password; |
||
20 | protected $_secretKey; |
||
21 | protected $_version = ''; |
||
22 | |||
23 | protected static $_isExecutionsLogEnabled = false; |
||
24 | protected static $_executionLog = []; |
||
25 | |||
26 | protected $_operatorsCache = []; |
||
27 | |||
28 | /** |
||
29 | * Create client |
||
30 | * |
||
31 | * @param string $host |
||
32 | * @param int $port |
||
33 | * @param string $protocol |
||
34 | */ |
||
35 | public function __construct($host, $port = 8443, $protocol = 'https') |
||
41 | |||
42 | /** |
||
43 | * Setup credentials for authentication |
||
44 | * |
||
45 | * @param string $login |
||
46 | * @param string $password |
||
47 | */ |
||
48 | public function setCredentials($login, $password) |
||
53 | |||
54 | /** |
||
55 | * Define secret key for alternative authentication |
||
56 | * |
||
57 | * @param string $secretKey |
||
58 | */ |
||
59 | public function setSecretKey($secretKey) |
||
63 | |||
64 | /** |
||
65 | * Set default version for requests |
||
66 | * |
||
67 | * @param string $version |
||
68 | */ |
||
69 | public function setVersion($version) |
||
73 | |||
74 | /** |
||
75 | * Retrieve host used for communication |
||
76 | * |
||
77 | * @return string |
||
78 | */ |
||
79 | public function getHost() |
||
83 | |||
84 | /** |
||
85 | * Retrieve port used for communication |
||
86 | * |
||
87 | * @return int |
||
88 | */ |
||
89 | public function getPort() |
||
93 | |||
94 | /** |
||
95 | * Retrieve name of the protocol (http or https) used for communication |
||
96 | * |
||
97 | * @return int |
||
98 | */ |
||
99 | public function getProtocol() |
||
103 | |||
104 | /** |
||
105 | * Retrieve XML template for packet |
||
106 | * |
||
107 | * @param string|null $version |
||
108 | * @return SimpleXMLElement |
||
109 | */ |
||
110 | public function getPacket($version = null) |
||
117 | |||
118 | /** |
||
119 | * Perform API request |
||
120 | * |
||
121 | * @param string|array|SimpleXMLElement $request |
||
122 | * @param int $mode |
||
123 | * @return XmlResponse |
||
124 | */ |
||
125 | public function request($request, $mode = self::RESPONSE_SHORT) |
||
143 | |||
144 | /** |
||
145 | * Perform HTTP request to end-point |
||
146 | * |
||
147 | * @param string $request |
||
148 | * @return XmlResponse |
||
149 | * @throws Exception |
||
150 | */ |
||
151 | protected function _performHttpRequest($request) |
||
184 | |||
185 | /** |
||
186 | * Perform multiple API requests using single HTTP request |
||
187 | * |
||
188 | * @param $requests |
||
189 | * @param int $mode |
||
190 | * @return array |
||
191 | */ |
||
192 | public function multiRequest($requests, $mode = self::RESPONSE_SHORT) |
||
227 | |||
228 | /** |
||
229 | * Retrieve list of headers needed for request |
||
230 | * |
||
231 | * @return array |
||
232 | */ |
||
233 | protected function _getHeaders() |
||
249 | |||
250 | /** |
||
251 | * Enable or disable execution log |
||
252 | * |
||
253 | * @param bool $enable |
||
254 | */ |
||
255 | public static function enableExecutionLog($enable = true) |
||
259 | |||
260 | /** |
||
261 | * Retrieve execution log |
||
262 | * |
||
263 | * @return array |
||
264 | */ |
||
265 | public static function getExecutionLog() |
||
269 | |||
270 | /** |
||
271 | * Verify that response does not contain errors |
||
272 | * |
||
273 | * @param XmlResponse $xml |
||
274 | * @throws \Exception |
||
275 | */ |
||
276 | protected function _verifyResponse($xml) |
||
288 | |||
289 | /** |
||
290 | * Expand short syntax (some.method.call) into full XML representation |
||
291 | * |
||
292 | * @param string $request |
||
293 | * @param SimpleXMLElement $xml |
||
294 | * @return string |
||
295 | */ |
||
296 | protected function _expandRequestShortSyntax($request, SimpleXMLElement $xml) |
||
308 | |||
309 | /** |
||
310 | * Convert array to XML representation |
||
311 | * |
||
312 | * @param array $array |
||
313 | * @param SimpleXMLElement $xml |
||
314 | * @return SimpleXMLElement |
||
315 | */ |
||
316 | protected function _arrayToXml(array $array, SimpleXMLElement $xml) |
||
328 | |||
329 | /** |
||
330 | * @param string $name |
||
331 | * @return \PleskX\Api\Operator |
||
332 | */ |
||
333 | protected function _getOperator($name) |
||
342 | |||
343 | /** |
||
344 | * @return Operator\Server |
||
345 | */ |
||
346 | public function server() |
||
350 | |||
351 | /** |
||
352 | * @return Operator\Customer |
||
353 | */ |
||
354 | public function customer() |
||
358 | |||
359 | /** |
||
360 | * @return Operator\Webspace |
||
361 | */ |
||
362 | public function webspace() |
||
366 | |||
367 | /** |
||
368 | * @return Operator\Subdomain |
||
369 | */ |
||
370 | public function subdomain() |
||
374 | |||
375 | /** |
||
376 | * @return Operator\Dns |
||
377 | */ |
||
378 | public function dns() |
||
382 | |||
383 | /** |
||
384 | * @return Operator\DatabaseServer |
||
385 | */ |
||
386 | public function databaseServer() |
||
390 | |||
391 | /** |
||
392 | * @return Operator\Mail |
||
393 | */ |
||
394 | public function mail() |
||
398 | |||
399 | /** |
||
400 | * @return Operator\Migration |
||
401 | */ |
||
402 | public function migration() |
||
406 | |||
407 | /** |
||
408 | * @return Operator\Certificate |
||
409 | */ |
||
410 | public function certificate() |
||
414 | |||
415 | /** |
||
416 | * @return Operator\SiteAlias |
||
417 | */ |
||
418 | public function siteAlias() |
||
422 | |||
423 | /** |
||
424 | * @return Operator\Ip |
||
425 | */ |
||
426 | public function ip() |
||
430 | |||
431 | /** |
||
432 | * @return Operator\EventLog |
||
433 | */ |
||
434 | public function eventLog() |
||
438 | |||
439 | /** |
||
440 | * @return Operator\SpamFilter |
||
441 | */ |
||
442 | public function spamFilter() |
||
446 | |||
447 | /** |
||
448 | * @return Operator\SecretKey |
||
449 | */ |
||
450 | public function secretKey() |
||
454 | |||
455 | /** |
||
456 | * @return Operator\Ui |
||
457 | */ |
||
458 | public function ui() |
||
462 | |||
463 | /** |
||
464 | * @return Operator\ServicePlan |
||
465 | */ |
||
466 | public function servicePlan() |
||
470 | |||
471 | /** |
||
472 | * @return Operator\WebUser |
||
473 | */ |
||
474 | public function webUser() |
||
478 | |||
479 | /** |
||
480 | * @return Operator\MailList |
||
481 | */ |
||
482 | public function mailList() |
||
486 | |||
487 | /** |
||
488 | * @return Operator\VirtualDirectory |
||
489 | */ |
||
490 | public function virtualDirectory() |
||
494 | |||
495 | /** |
||
496 | * @return Operator\Database |
||
497 | */ |
||
498 | public function database() |
||
502 | |||
503 | /** |
||
504 | * @return Operator\FtpUser |
||
505 | */ |
||
506 | public function ftpUser() |
||
510 | |||
511 | /** |
||
512 | * @return Operator\Session |
||
513 | */ |
||
514 | public function session() |
||
518 | |||
519 | /** |
||
520 | * @return Operator\Updater |
||
521 | */ |
||
522 | public function updater() |
||
526 | |||
527 | /** |
||
528 | * @return Operator\Locale |
||
529 | */ |
||
530 | public function locale() |
||
534 | |||
535 | /** |
||
536 | * @return Operator\LogRotation |
||
537 | */ |
||
538 | public function logRotation() |
||
542 | |||
543 | /** |
||
544 | * @return Operator\BackupManager |
||
545 | */ |
||
546 | public function backupManager() |
||
550 | |||
551 | /** |
||
552 | * @return Operator\Sso |
||
553 | */ |
||
554 | public function sso() |
||
558 | |||
559 | /** |
||
560 | * @return Operator\ProtectedDirectory |
||
561 | */ |
||
562 | public function protectedDirectory() |
||
566 | |||
567 | /** |
||
568 | * @return Operator\Reseller |
||
569 | */ |
||
570 | public function reseller() |
||
574 | |||
575 | /** |
||
576 | * @return Operator\ResellerPlan |
||
577 | */ |
||
578 | public function resellerPlan() |
||
582 | |||
583 | /** |
||
584 | * @return Operator\Aps |
||
585 | */ |
||
586 | public function aps() |
||
590 | |||
591 | /** |
||
592 | * @return Operator\ServicePlanAddon |
||
593 | */ |
||
594 | public function servicePlanAddon() |
||
598 | |||
599 | /** |
||
600 | * @return Operator\Site |
||
601 | */ |
||
602 | public function site() |
||
606 | |||
607 | /** |
||
608 | * @return Operator\User |
||
609 | */ |
||
610 | public function user() |
||
614 | |||
615 | /** |
||
616 | * @return Operator\Role |
||
617 | */ |
||
618 | public function role() |
||
622 | |||
623 | /** |
||
624 | * @return Operator\BusinessLogicUpgrade |
||
625 | */ |
||
626 | public function businessLogicUpgrade() |
||
630 | |||
631 | /** |
||
632 | * @return Operator\Webmail |
||
633 | */ |
||
634 | public function webmail() |
||
638 | |||
639 | /** |
||
640 | * @return Operator\PlanItem |
||
641 | */ |
||
642 | public function planItem() |
||
646 | |||
647 | /** |
||
648 | * @return Operator\Sitebuilder |
||
649 | */ |
||
650 | public function sitebuilder() |
||
654 | |||
655 | /** |
||
656 | * @return Operator\ServiceNode |
||
657 | */ |
||
658 | public function serviceNode() |
||
662 | |||
663 | /** |
||
664 | * @return Operator\IpBan |
||
665 | */ |
||
666 | public function ipBan() |
||
670 | |||
671 | /** |
||
672 | * @return Operator\WpInstance |
||
673 | */ |
||
674 | public function wpInstance() |
||
678 | |||
679 | } |
||
680 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.