Complex classes like Client often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Client, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class Client |
||
| 11 | { |
||
| 12 | const RESPONSE_SHORT = 1; |
||
| 13 | const RESPONSE_FULL = 2; |
||
| 14 | |||
| 15 | protected $_host; |
||
| 16 | protected $_port; |
||
| 17 | protected $_protocol; |
||
| 18 | protected $_login; |
||
| 19 | protected $_password; |
||
| 20 | protected $_secretKey; |
||
| 21 | protected $_version = ''; |
||
| 22 | |||
| 23 | protected static $_isExecutionsLogEnabled = false; |
||
| 24 | protected static $_executionLog = []; |
||
| 25 | |||
| 26 | protected $_operatorsCache = []; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var callable |
||
| 30 | */ |
||
| 31 | protected $_verifyResponseCallback; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * Create client |
||
| 35 | * |
||
| 36 | * @param string $host |
||
| 37 | * @param int $port |
||
| 38 | * @param string $protocol |
||
| 39 | */ |
||
| 40 | public function __construct($host, $port = 8443, $protocol = 'https') |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Setup credentials for authentication |
||
| 49 | * |
||
| 50 | * @param string $login |
||
| 51 | * @param string $password |
||
| 52 | */ |
||
| 53 | public function setCredentials($login, $password) |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Define secret key for alternative authentication |
||
| 61 | * |
||
| 62 | * @param string $secretKey |
||
| 63 | */ |
||
| 64 | public function setSecretKey($secretKey) |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Set default version for requests |
||
| 71 | * |
||
| 72 | * @param string $version |
||
| 73 | */ |
||
| 74 | public function setVersion($version) |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Set custom function to verify response of API call according your own needs. Default verifying will be used if it is not specified |
||
| 81 | * |
||
| 82 | * @param callable|null $function |
||
| 83 | */ |
||
| 84 | public function setVerifyResponse(callable $function = null) |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Retrieve host used for communication |
||
| 91 | * |
||
| 92 | * @return string |
||
| 93 | */ |
||
| 94 | public function getHost() |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Retrieve port used for communication |
||
| 101 | * |
||
| 102 | * @return int |
||
| 103 | */ |
||
| 104 | public function getPort() |
||
| 108 | |||
| 109 | /** |
||
| 110 | * Retrieve name of the protocol (http or https) used for communication |
||
| 111 | * |
||
| 112 | * @return string |
||
| 113 | */ |
||
| 114 | public function getProtocol() |
||
| 118 | |||
| 119 | /** |
||
| 120 | * Retrieve XML template for packet |
||
| 121 | * |
||
| 122 | * @param string|null $version |
||
| 123 | * @return SimpleXMLElement |
||
| 124 | */ |
||
| 125 | public function getPacket($version = null) |
||
| 132 | |||
| 133 | /** |
||
| 134 | * Perform API request |
||
| 135 | * |
||
| 136 | * @param string|array|SimpleXMLElement $request |
||
| 137 | * @param int $mode |
||
| 138 | * @return XmlResponse |
||
| 139 | */ |
||
| 140 | public function request($request, $mode = self::RESPONSE_SHORT) |
||
| 168 | |||
| 169 | /** |
||
| 170 | * Perform HTTP request to end-point |
||
| 171 | * |
||
| 172 | * @param string $request |
||
| 173 | * @return XmlResponse |
||
| 174 | * @throws Client\Exception |
||
| 175 | */ |
||
| 176 | private function _performHttpRequest($request) |
||
| 207 | |||
| 208 | /** |
||
| 209 | * Perform multiple API requests using single HTTP request |
||
| 210 | * |
||
| 211 | * @param $requests |
||
| 212 | * @param int $mode |
||
| 213 | * @return array |
||
| 214 | * @throws Client\Exception |
||
| 215 | */ |
||
| 216 | public function multiRequest($requests, $mode = self::RESPONSE_SHORT) |
||
| 255 | |||
| 256 | /** |
||
| 257 | * Retrieve list of headers needed for request |
||
| 258 | * |
||
| 259 | * @return array |
||
| 260 | */ |
||
| 261 | protected function _getHeaders() |
||
| 277 | |||
| 278 | /** |
||
| 279 | * Enable or disable execution log |
||
| 280 | * |
||
| 281 | * @param bool $enable |
||
| 282 | */ |
||
| 283 | public static function enableExecutionLog($enable = true) |
||
| 287 | |||
| 288 | /** |
||
| 289 | * Retrieve execution log |
||
| 290 | * |
||
| 291 | * @return array |
||
| 292 | */ |
||
| 293 | public static function getExecutionLog() |
||
| 297 | |||
| 298 | /** |
||
| 299 | * Verify that response does not contain errors |
||
| 300 | * |
||
| 301 | * @param XmlResponse $xml |
||
| 302 | * @throws Exception |
||
| 303 | */ |
||
| 304 | protected function _verifyResponse($xml) |
||
| 316 | |||
| 317 | /** |
||
| 318 | * Expand short syntax (some.method.call) into full XML representation |
||
| 319 | * |
||
| 320 | * @param string $request |
||
| 321 | * @param SimpleXMLElement $xml |
||
| 322 | * @return string |
||
| 323 | */ |
||
| 324 | protected function _expandRequestShortSyntax($request, SimpleXMLElement $xml) |
||
| 336 | |||
| 337 | /** |
||
| 338 | * Convert array to XML representation |
||
| 339 | * |
||
| 340 | * @param array $array |
||
| 341 | * @param SimpleXMLElement $xml |
||
| 342 | * @return SimpleXMLElement |
||
| 343 | */ |
||
| 344 | protected function _arrayToXml(array $array, SimpleXMLElement $xml) |
||
| 363 | |||
| 364 | protected function _isAssoc(array $arr) |
||
| 369 | |||
| 370 | /** |
||
| 371 | * @param string $name |
||
| 372 | * @return \PleskX\Api\Operator |
||
| 373 | */ |
||
| 374 | protected function _getOperator($name) |
||
| 383 | |||
| 384 | /** |
||
| 385 | * @return Operator\Server |
||
| 386 | */ |
||
| 387 | public function server() |
||
| 391 | |||
| 392 | /** |
||
| 393 | * @return Operator\Customer |
||
| 394 | */ |
||
| 395 | public function customer() |
||
| 399 | |||
| 400 | /** |
||
| 401 | * @return Operator\Webspace |
||
| 402 | */ |
||
| 403 | public function webspace() |
||
| 407 | |||
| 408 | /** |
||
| 409 | * @return Operator\Subdomain |
||
| 410 | */ |
||
| 411 | public function subdomain() |
||
| 415 | |||
| 416 | /** |
||
| 417 | * @return Operator\Dns |
||
| 418 | */ |
||
| 419 | public function dns() |
||
| 423 | |||
| 424 | /** |
||
| 425 | * @return Operator\DatabaseServer |
||
| 426 | */ |
||
| 427 | public function databaseServer() |
||
| 431 | |||
| 432 | /** |
||
| 433 | * @return Operator\Mail |
||
| 434 | */ |
||
| 435 | public function mail() |
||
| 439 | |||
| 440 | /** |
||
| 441 | * @return Operator\Migration |
||
| 442 | */ |
||
| 443 | public function migration() |
||
| 447 | |||
| 448 | /** |
||
| 449 | * @return Operator\Certificate |
||
| 450 | */ |
||
| 451 | public function certificate() |
||
| 455 | |||
| 456 | /** |
||
| 457 | * @return Operator\SiteAlias |
||
| 458 | */ |
||
| 459 | public function siteAlias() |
||
| 463 | |||
| 464 | /** |
||
| 465 | * @return Operator\Ip |
||
| 466 | */ |
||
| 467 | public function ip() |
||
| 471 | |||
| 472 | /** |
||
| 473 | * @return Operator\EventLog |
||
| 474 | */ |
||
| 475 | public function eventLog() |
||
| 479 | |||
| 480 | /** |
||
| 481 | * @return Operator\SpamFilter |
||
| 482 | */ |
||
| 483 | public function spamFilter() |
||
| 487 | |||
| 488 | /** |
||
| 489 | * @return Operator\SecretKey |
||
| 490 | */ |
||
| 491 | public function secretKey() |
||
| 495 | |||
| 496 | /** |
||
| 497 | * @return Operator\Ui |
||
| 498 | */ |
||
| 499 | public function ui() |
||
| 503 | |||
| 504 | /** |
||
| 505 | * @return Operator\ServicePlan |
||
| 506 | */ |
||
| 507 | public function servicePlan() |
||
| 511 | |||
| 512 | /** |
||
| 513 | * @return Operator\WebUser |
||
| 514 | */ |
||
| 515 | public function webUser() |
||
| 519 | |||
| 520 | /** |
||
| 521 | * @return Operator\MailList |
||
| 522 | */ |
||
| 523 | public function mailList() |
||
| 527 | |||
| 528 | /** |
||
| 529 | * @return Operator\VirtualDirectory |
||
| 530 | */ |
||
| 531 | public function virtualDirectory() |
||
| 535 | |||
| 536 | /** |
||
| 537 | * @return Operator\Database |
||
| 538 | */ |
||
| 539 | public function database() |
||
| 543 | |||
| 544 | /** |
||
| 545 | * @return Operator\FtpUser |
||
| 546 | */ |
||
| 547 | public function ftpUser() |
||
| 551 | |||
| 552 | /** |
||
| 553 | * @return Operator\Session |
||
| 554 | */ |
||
| 555 | public function session() |
||
| 559 | |||
| 560 | /** |
||
| 561 | * @return Operator\Updater |
||
| 562 | */ |
||
| 563 | public function updater() |
||
| 567 | |||
| 568 | /** |
||
| 569 | * @return Operator\Locale |
||
| 570 | */ |
||
| 571 | public function locale() |
||
| 575 | |||
| 576 | /** |
||
| 577 | * @return Operator\LogRotation |
||
| 578 | */ |
||
| 579 | public function logRotation() |
||
| 583 | |||
| 584 | /** |
||
| 585 | * @return Operator\BackupManager |
||
| 586 | */ |
||
| 587 | public function backupManager() |
||
| 591 | |||
| 592 | /** |
||
| 593 | * @return Operator\Sso |
||
| 594 | */ |
||
| 595 | public function sso() |
||
| 599 | |||
| 600 | /** |
||
| 601 | * @return Operator\ProtectedDirectory |
||
| 602 | */ |
||
| 603 | public function protectedDirectory() |
||
| 607 | |||
| 608 | /** |
||
| 609 | * @return Operator\Reseller |
||
| 610 | */ |
||
| 611 | public function reseller() |
||
| 615 | |||
| 616 | /** |
||
| 617 | * @return Operator\ResellerPlan |
||
| 618 | */ |
||
| 619 | public function resellerPlan() |
||
| 623 | |||
| 624 | /** |
||
| 625 | * @return Operator\Aps |
||
| 626 | */ |
||
| 627 | public function aps() |
||
| 631 | |||
| 632 | /** |
||
| 633 | * @return Operator\ServicePlanAddon |
||
| 634 | */ |
||
| 635 | public function servicePlanAddon() |
||
| 639 | |||
| 640 | /** |
||
| 641 | * @return Operator\Site |
||
| 642 | */ |
||
| 643 | public function site() |
||
| 647 | |||
| 648 | /** |
||
| 649 | * @return Operator\User |
||
| 650 | */ |
||
| 651 | public function user() |
||
| 655 | |||
| 656 | /** |
||
| 657 | * @return Operator\Role |
||
| 658 | */ |
||
| 659 | public function role() |
||
| 663 | |||
| 664 | /** |
||
| 665 | * @return Operator\BusinessLogicUpgrade |
||
| 666 | */ |
||
| 667 | public function businessLogicUpgrade() |
||
| 671 | |||
| 672 | /** |
||
| 673 | * @return Operator\Webmail |
||
| 674 | */ |
||
| 675 | public function webmail() |
||
| 679 | |||
| 680 | /** |
||
| 681 | * @return Operator\PlanItem |
||
| 682 | */ |
||
| 683 | public function planItem() |
||
| 687 | |||
| 688 | /** |
||
| 689 | * @return Operator\Sitebuilder |
||
| 690 | */ |
||
| 691 | public function sitebuilder() |
||
| 695 | |||
| 696 | /** |
||
| 697 | * @return Operator\ServiceNode |
||
| 698 | */ |
||
| 699 | public function serviceNode() |
||
| 703 | |||
| 704 | /** |
||
| 705 | * @return Operator\IpBan |
||
| 706 | */ |
||
| 707 | public function ipBan() |
||
| 711 | |||
| 712 | /** |
||
| 713 | * @return Operator\WpInstance |
||
| 714 | */ |
||
| 715 | public function wpInstance() |
||
| 719 | |||
| 720 | } |
||
| 721 |