Complex classes like Client often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Client, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class Client |
||
11 | { |
||
12 | const RESPONSE_SHORT = 1; |
||
13 | const RESPONSE_FULL = 2; |
||
14 | |||
15 | protected $_host; |
||
16 | protected $_port; |
||
17 | protected $_protocol; |
||
18 | protected $_login; |
||
19 | protected $_password; |
||
20 | protected $_secretKey; |
||
21 | protected $_version = ''; |
||
22 | |||
23 | protected static $_isExecutionsLogEnabled = false; |
||
24 | protected static $_executionLog = []; |
||
25 | |||
26 | protected $_operatorsCache = []; |
||
27 | |||
28 | /** |
||
29 | * @var callable |
||
30 | */ |
||
31 | protected $_verifyResponseCallback; |
||
32 | |||
33 | /** |
||
34 | * Create client |
||
35 | * |
||
36 | * @param string $host |
||
37 | * @param int $port |
||
38 | * @param string $protocol |
||
39 | */ |
||
40 | public function __construct($host, $port = 8443, $protocol = 'https') |
||
46 | |||
47 | /** |
||
48 | * Setup credentials for authentication |
||
49 | * |
||
50 | * @param string $login |
||
51 | * @param string $password |
||
52 | */ |
||
53 | public function setCredentials($login, $password) |
||
58 | |||
59 | /** |
||
60 | * Define secret key for alternative authentication |
||
61 | * |
||
62 | * @param string $secretKey |
||
63 | */ |
||
64 | public function setSecretKey($secretKey) |
||
68 | |||
69 | /** |
||
70 | * Set default version for requests |
||
71 | * |
||
72 | * @param string $version |
||
73 | */ |
||
74 | public function setVersion($version) |
||
78 | |||
79 | /** |
||
80 | * Set custom function to verify response of API call according your own needs. Default verifying will be used if it is not specified |
||
81 | * |
||
82 | * @param callable|null $function |
||
83 | */ |
||
84 | public function setVerifyResponseCallback(callable $function = null) { |
||
87 | |||
88 | /** |
||
89 | * Retrieve host used for communication |
||
90 | * |
||
91 | * @return string |
||
92 | */ |
||
93 | public function getHost() |
||
97 | |||
98 | /** |
||
99 | * Retrieve port used for communication |
||
100 | * |
||
101 | * @return int |
||
102 | */ |
||
103 | public function getPort() |
||
107 | |||
108 | /** |
||
109 | * Retrieve name of the protocol (http or https) used for communication |
||
110 | * |
||
111 | * @return string |
||
112 | */ |
||
113 | public function getProtocol() |
||
117 | |||
118 | /** |
||
119 | * Retrieve XML template for packet |
||
120 | * |
||
121 | * @param string|null $version |
||
122 | * @return SimpleXMLElement |
||
123 | */ |
||
124 | public function getPacket($version = null) |
||
131 | |||
132 | /** |
||
133 | * Perform API request |
||
134 | * |
||
135 | * @param string|array|SimpleXMLElement $request |
||
136 | * @param int $mode |
||
137 | * @return XmlResponse |
||
138 | */ |
||
139 | public function request($request, $mode = self::RESPONSE_SHORT) |
||
167 | |||
168 | /** |
||
169 | * Perform HTTP request to end-point |
||
170 | * |
||
171 | * @param string $request |
||
172 | * @return XmlResponse |
||
173 | * @throws Client\Exception |
||
174 | */ |
||
175 | private function _performHttpRequest($request) |
||
206 | |||
207 | /** |
||
208 | * Perform multiple API requests using single HTTP request |
||
209 | * |
||
210 | * @param $requests |
||
211 | * @param int $mode |
||
212 | * @return array |
||
213 | * @throws Client\Exception |
||
214 | */ |
||
215 | public function multiRequest($requests, $mode = self::RESPONSE_SHORT) |
||
254 | |||
255 | /** |
||
256 | * Retrieve list of headers needed for request |
||
257 | * |
||
258 | * @return array |
||
259 | */ |
||
260 | protected function _getHeaders() |
||
276 | |||
277 | /** |
||
278 | * Enable or disable execution log |
||
279 | * |
||
280 | * @param bool $enable |
||
281 | */ |
||
282 | public static function enableExecutionLog($enable = true) |
||
286 | |||
287 | /** |
||
288 | * Retrieve execution log |
||
289 | * |
||
290 | * @return array |
||
291 | */ |
||
292 | public static function getExecutionLog() |
||
296 | |||
297 | /** |
||
298 | * Verify that response does not contain errors |
||
299 | * |
||
300 | * @param XmlResponse $xml |
||
301 | * @throws Exception |
||
302 | */ |
||
303 | protected function _verifyResponse($xml) |
||
315 | |||
316 | /** |
||
317 | * Expand short syntax (some.method.call) into full XML representation |
||
318 | * |
||
319 | * @param string $request |
||
320 | * @param SimpleXMLElement $xml |
||
321 | * @return string |
||
322 | */ |
||
323 | protected function _expandRequestShortSyntax($request, SimpleXMLElement $xml) |
||
335 | |||
336 | /** |
||
337 | * Convert array to XML representation |
||
338 | * |
||
339 | * @param array $array |
||
340 | * @param SimpleXMLElement $xml |
||
341 | * @return SimpleXMLElement |
||
342 | */ |
||
343 | protected function _arrayToXml(array $array, SimpleXMLElement $xml) |
||
355 | |||
356 | /** |
||
357 | * @param string $name |
||
358 | * @return \PleskX\Api\Operator |
||
359 | */ |
||
360 | protected function _getOperator($name) |
||
369 | |||
370 | /** |
||
371 | * @return Operator\Server |
||
372 | */ |
||
373 | public function server() |
||
377 | |||
378 | /** |
||
379 | * @return Operator\Customer |
||
380 | */ |
||
381 | public function customer() |
||
385 | |||
386 | /** |
||
387 | * @return Operator\Webspace |
||
388 | */ |
||
389 | public function webspace() |
||
393 | |||
394 | /** |
||
395 | * @return Operator\Subdomain |
||
396 | */ |
||
397 | public function subdomain() |
||
401 | |||
402 | /** |
||
403 | * @return Operator\Dns |
||
404 | */ |
||
405 | public function dns() |
||
409 | |||
410 | /** |
||
411 | * @return Operator\DatabaseServer |
||
412 | */ |
||
413 | public function databaseServer() |
||
417 | |||
418 | /** |
||
419 | * @return Operator\Mail |
||
420 | */ |
||
421 | public function mail() |
||
425 | |||
426 | /** |
||
427 | * @return Operator\Migration |
||
428 | */ |
||
429 | public function migration() |
||
433 | |||
434 | /** |
||
435 | * @return Operator\Certificate |
||
436 | */ |
||
437 | public function certificate() |
||
441 | |||
442 | /** |
||
443 | * @return Operator\SiteAlias |
||
444 | */ |
||
445 | public function siteAlias() |
||
449 | |||
450 | /** |
||
451 | * @return Operator\Ip |
||
452 | */ |
||
453 | public function ip() |
||
457 | |||
458 | /** |
||
459 | * @return Operator\EventLog |
||
460 | */ |
||
461 | public function eventLog() |
||
465 | |||
466 | /** |
||
467 | * @return Operator\SpamFilter |
||
468 | */ |
||
469 | public function spamFilter() |
||
473 | |||
474 | /** |
||
475 | * @return Operator\SecretKey |
||
476 | */ |
||
477 | public function secretKey() |
||
481 | |||
482 | /** |
||
483 | * @return Operator\Ui |
||
484 | */ |
||
485 | public function ui() |
||
489 | |||
490 | /** |
||
491 | * @return Operator\ServicePlan |
||
492 | */ |
||
493 | public function servicePlan() |
||
497 | |||
498 | /** |
||
499 | * @return Operator\WebUser |
||
500 | */ |
||
501 | public function webUser() |
||
505 | |||
506 | /** |
||
507 | * @return Operator\MailList |
||
508 | */ |
||
509 | public function mailList() |
||
513 | |||
514 | /** |
||
515 | * @return Operator\VirtualDirectory |
||
516 | */ |
||
517 | public function virtualDirectory() |
||
521 | |||
522 | /** |
||
523 | * @return Operator\Database |
||
524 | */ |
||
525 | public function database() |
||
529 | |||
530 | /** |
||
531 | * @return Operator\FtpUser |
||
532 | */ |
||
533 | public function ftpUser() |
||
537 | |||
538 | /** |
||
539 | * @return Operator\Session |
||
540 | */ |
||
541 | public function session() |
||
545 | |||
546 | /** |
||
547 | * @return Operator\Updater |
||
548 | */ |
||
549 | public function updater() |
||
553 | |||
554 | /** |
||
555 | * @return Operator\Locale |
||
556 | */ |
||
557 | public function locale() |
||
561 | |||
562 | /** |
||
563 | * @return Operator\LogRotation |
||
564 | */ |
||
565 | public function logRotation() |
||
569 | |||
570 | /** |
||
571 | * @return Operator\BackupManager |
||
572 | */ |
||
573 | public function backupManager() |
||
577 | |||
578 | /** |
||
579 | * @return Operator\Sso |
||
580 | */ |
||
581 | public function sso() |
||
585 | |||
586 | /** |
||
587 | * @return Operator\ProtectedDirectory |
||
588 | */ |
||
589 | public function protectedDirectory() |
||
593 | |||
594 | /** |
||
595 | * @return Operator\Reseller |
||
596 | */ |
||
597 | public function reseller() |
||
601 | |||
602 | /** |
||
603 | * @return Operator\ResellerPlan |
||
604 | */ |
||
605 | public function resellerPlan() |
||
609 | |||
610 | /** |
||
611 | * @return Operator\Aps |
||
612 | */ |
||
613 | public function aps() |
||
617 | |||
618 | /** |
||
619 | * @return Operator\ServicePlanAddon |
||
620 | */ |
||
621 | public function servicePlanAddon() |
||
625 | |||
626 | /** |
||
627 | * @return Operator\Site |
||
628 | */ |
||
629 | public function site() |
||
633 | |||
634 | /** |
||
635 | * @return Operator\User |
||
636 | */ |
||
637 | public function user() |
||
641 | |||
642 | /** |
||
643 | * @return Operator\Role |
||
644 | */ |
||
645 | public function role() |
||
649 | |||
650 | /** |
||
651 | * @return Operator\BusinessLogicUpgrade |
||
652 | */ |
||
653 | public function businessLogicUpgrade() |
||
657 | |||
658 | /** |
||
659 | * @return Operator\Webmail |
||
660 | */ |
||
661 | public function webmail() |
||
665 | |||
666 | /** |
||
667 | * @return Operator\PlanItem |
||
668 | */ |
||
669 | public function planItem() |
||
673 | |||
674 | /** |
||
675 | * @return Operator\Sitebuilder |
||
676 | */ |
||
677 | public function sitebuilder() |
||
681 | |||
682 | /** |
||
683 | * @return Operator\ServiceNode |
||
684 | */ |
||
685 | public function serviceNode() |
||
689 | |||
690 | /** |
||
691 | * @return Operator\IpBan |
||
692 | */ |
||
693 | public function ipBan() |
||
697 | |||
698 | /** |
||
699 | * @return Operator\WpInstance |
||
700 | */ |
||
701 | public function wpInstance() |
||
705 | |||
706 | } |
||
707 |