Dns::bulkDelete() - Code Metrics - Inspection of "Merge pull request #86 from guyasyou/master" - plesk/api-php-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 328543...824e88 )

by Alexei

created 2020-12-17 05:04 UTC

Dns::bulkDelete() A

↳ Parent: Dns

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	3
nc	4
nop	1

<?php
// Copyright 1999-2020. Plesk International GmbH.

namespace PleskX\Api\Operator;

use PleskX\Api\Struct\Dns as Struct;

class Dns extends \PleskX\Api\Operator
{
    /**
     * @param array $properties
     *
     * @return Struct\Info
     */
    public function create($properties)
    {
        $packet = $this->_client->getPacket();
        $info = $packet->addChild($this->_wrapperTag)->addChild('add_rec');

        foreach ($properties as $name => $value) {
            $info->addChild($name, $value);
        }

        return new Struct\Info($this->_client->request($packet));
    }

    /**
     * Send multiply records by one request.
     *
     * @param array $records
     *
     * @return \PleskX\Api\XmlResponse[]
     */
    public function bulkCreate(array $records)
    {
        $packet = $this->_client->getPacket();

        foreach ($records as $properties) {
            $info = $packet->addChild($this->_wrapperTag)->addChild('add_rec');

            foreach ($properties as $name => $value) {
                $info->addChild($name, $value);
            }
        }

        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
        $items = [];
        foreach ($response->xpath('//result') as $xmlResult) {
            $items[] = $xmlResult;
        }

        return $items;
    }

    /**
     * @param string $field
     * @param int|string $value
     *
     * @return Struct\Info
     */
    public function get($field, $value)
    {
        $items = $this->getAll($field, $value);

        return reset($items);

    }

    /**
     * @param string $field
     * @param int|string $value
     *
     * @return Struct\Info[]
     */
    public function getAll($field, $value)
    {
        $packet = $this->_client->getPacket();
        $getTag = $packet->addChild($this->_wrapperTag)->addChild('get_rec');

        $filterTag = $getTag->addChild('filter');
        if (!is_null($field)) {
            $filterTag->addChild($field, $value);
        }

        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
        $items = [];
        foreach ($response->xpath('//result') as $xmlResult) {
            $item = new Struct\Info($xmlResult->data);
            $item->id = (int) $xmlResult->id;
            $items[] = $item;
        }

        return $items;
    }

    /**
     * @param string $field
     * @param int|string $value
     *
     * @return bool
     */
    public function delete($field, $value)
    {
        return $this->_delete($field, $value, 'del_rec');
    }

    /**
     * Delete multiply records by one request.
     *
     * @param array $recordIds
     *
     * @return \PleskX\Api\XmlResponse[]
     */
    public function bulkDelete(array $recordIds)
    {
        $packet = $this->_client->getPacket();

        foreach ($recordIds as $recordId) {
            $packet->addChild($this->_wrapperTag)->addChild('del_rec')
                ->addChild('filter')->addChild('id', $recordId);
        }

        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
        $items = [];
        foreach ($response->xpath('//result') as $xmlResult) {
            $items[] = $xmlResult;
        }

        return $items;
    }
}


1			<?php
2			// Copyright 1999-2020. Plesk International GmbH.
3
4			namespace PleskX\Api\Operator;
5
6			use PleskX\Api\Struct\Dns as Struct;
7
8			class Dns extends \PleskX\Api\Operator
9			{
10			/**
11			* @param array $properties
12			*
13			* @return Struct\Info
14			*/
15			public function create($properties)
16			{
17			$packet = $this->_client->getPacket();
18			$info = $packet->addChild($this->_wrapperTag)->addChild('add_rec');
19
20			foreach ($properties as $name => $value) {
21			$info->addChild($name, $value);
22			}
23
24			return new Struct\Info($this->_client->request($packet));
25			}
26
27			/**
28			* Send multiply records by one request.
29			*
30			* @param array $records
31			*
32			* @return \PleskX\Api\XmlResponse[]
33			*/
34			public function bulkCreate(array $records)
35			{
36			$packet = $this->_client->getPacket();
37
38			foreach ($records as $properties) {
39			$info = $packet->addChild($this->_wrapperTag)->addChild('add_rec');
40
41			foreach ($properties as $name => $value) {
42			$info->addChild($name, $value);
43			}
44			}
45
46			$response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
47			$items = [];
48			foreach ($response->xpath('//result') as $xmlResult) {
49			$items[] = $xmlResult;
50			}
51
52			return $items;
53			}
54
55			/**
56			* @param string $field
57			* @param int\|string $value
58			*
59			* @return Struct\Info
60			*/
61			public function get($field, $value)
62			{
63			$items = $this->getAll($field, $value);
64
65			return reset($items);
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-11-23 18:43 UTC by Report Bug Copy Issue Report The expression `reset($items);` of type `PleskX\Api\Struct\Dns\Info\|false` adds `false` to the return on line 65 which is incompatible with the return type documented by `PleskX\Api\Operator\Dns::get` of type `PleskX\Api\Struct\Dns\Info`. It seems like you forgot to handle an error condition. Loading history...
66			}
67
68			/**
69			* @param string $field
70			* @param int\|string $value
71			*
72			* @return Struct\Info[]
73			*/
74			public function getAll($field, $value)
75			{
76			$packet = $this->_client->getPacket();
77			$getTag = $packet->addChild($this->_wrapperTag)->addChild('get_rec');
78
79			$filterTag = $getTag->addChild('filter');
80			if (!is_null($field)) {
81			$filterTag->addChild($field, $value);
82			}
83
84			$response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
85			$items = [];
86			foreach ($response->xpath('//result') as $xmlResult) {
87			$item = new Struct\Info($xmlResult->data);
88			$item->id = (int) $xmlResult->id;
89			$items[] = $item;
90			}
91
92			return $items;
93			}
94
95			/**
96			* @param string $field
97			* @param int\|string $value
98			*
99			* @return bool
100			*/
101			public function delete($field, $value)
102			{
103			return $this->_delete($field, $value, 'del_rec');
104			}
105
106			/**
107			* Delete multiply records by one request.
108			*
109			* @param array $recordIds
110			*
111			* @return \PleskX\Api\XmlResponse[]
112			*/
113			public function bulkDelete(array $recordIds)
114			{
115			$packet = $this->_client->getPacket();
116
117			foreach ($recordIds as $recordId) {
118			$packet->addChild($this->_wrapperTag)->addChild('del_rec')
119			->addChild('filter')->addChild('id', $recordId);
120			}
121
122			$response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
123			$items = [];
124			foreach ($response->xpath('//result') as $xmlResult) {
125			$items[] = $xmlResult;
126			}
127
128			return $items;
129			}
130			}
131

plesk / api-php-lib

Push — master ( 328543...824e88 )

Dns::bulkDelete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like