Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Database extends \PleskX\Api\Operator |
||
9 | { |
||
10 | /** |
||
11 | * @param array $properties |
||
12 | * |
||
13 | * @return Struct\Info |
||
14 | */ |
||
15 | public function create($properties) |
||
19 | |||
20 | /** |
||
21 | * @param array $properties |
||
22 | * |
||
23 | * @return Struct\UserInfo |
||
24 | */ |
||
25 | public function createUser($properties) |
||
29 | |||
30 | /** |
||
31 | * @param string $command |
||
32 | * @param array $properties |
||
33 | * |
||
34 | * @return \PleskX\Api\XmlResponse |
||
35 | */ |
||
36 | private function _process($command, array $properties) |
||
51 | |||
52 | /** |
||
53 | * @param array $properties |
||
54 | * |
||
55 | * @return bool |
||
56 | */ |
||
57 | public function updateUser(array $properties) |
||
63 | |||
64 | /** |
||
65 | * @param string $field |
||
66 | * @param int|string $value |
||
67 | * |
||
68 | * @return Struct\Info |
||
69 | */ |
||
70 | public function get($field, $value) |
||
76 | |||
77 | /** |
||
78 | * @param string $field |
||
79 | * @param int|string $value |
||
80 | * |
||
81 | * @return Struct\UserInfo |
||
82 | */ |
||
83 | public function getUser($field, $value) |
||
89 | |||
90 | /** |
||
91 | * @param string $field |
||
92 | * @param int|string $value |
||
93 | * |
||
94 | * @return Struct\Info[] |
||
95 | */ |
||
96 | View Code Duplication | public function getAll($field, $value) |
|
106 | |||
107 | /** |
||
108 | * @param string $field |
||
109 | * @param int|string $value |
||
110 | * |
||
111 | * @return Struct\UserInfo[] |
||
112 | */ |
||
113 | View Code Duplication | public function getAllUsers($field, $value) |
|
123 | |||
124 | /** |
||
125 | * @param string $command |
||
126 | * @param string $field |
||
127 | * @param int|string $value |
||
128 | * |
||
129 | * @return \PleskX\Api\XmlResponse |
||
130 | */ |
||
131 | View Code Duplication | private function _get($command, $field, $value) |
|
145 | |||
146 | /** |
||
147 | * @param string $field |
||
148 | * @param int|string $value |
||
149 | * |
||
150 | * @return bool |
||
151 | */ |
||
152 | public function delete($field, $value) |
||
156 | |||
157 | /** |
||
158 | * @param string $field |
||
159 | * @param int|string $value |
||
160 | * |
||
161 | * @return bool |
||
162 | */ |
||
163 | public function deleteUser($field, $value) |
||
167 | } |
||
168 |