W2w\Lib\Apie\Core\Models\ApiResourceListFacadeResponse

Complexity

Total Complexity

3

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getResponse()	0	10	2
A	__construct()	0	11	1

<?php

namespace W2w\Lib\Apie\Core\Models;

use Psr\Http\Message\ResponseInterface;
use W2w\Lib\Apie\Core\SearchFilters\SearchFilterRequest;
use W2w\Lib\Apie\Events\ResponseAllEvent;
use W2w\Lib\Apie\Interfaces\ResourceSerializerInterface;
use W2w\Lib\Apie\PluginInterfaces\ResourceLifeCycleInterface;

/**
 * Data class returned by ApiResourceFacade for the GET resources.
 */
class ApiResourceListFacadeResponse extends ApiResourceFacadeResponse
{
    /**
     * @var string
     */
    private $resourceClass;

    /**
     * @var SearchFilterRequest
     */
    private $filterRequest;

    /**
     * @param ResourceSerializerInterface $serializer
     * @param mixed $resourceList
     * @param string $resourceClass
     * @param SearchFilterRequest $filterRequest
     * @param string|null $acceptHeader
     * @param ResourceLifeCycleInterface[]
     */
    public function __construct(
        ResourceSerializerInterface $serializer,
        iterable $resourceList,
        string $resourceClass,
        SearchFilterRequest $filterRequest,
        ?string $acceptHeader,
        iterable $resourceLifeCycles = []
    ) {
        parent::__construct($serializer, $resourceList, $acceptHeader, $resourceLifeCycles);
        $this->resourceClass = $resourceClass;
        $this->filterRequest = $filterRequest;
    }

    /**
     * @return ResponseInterface
     */
    public function getResponse(): ResponseInterface
    {
        $event = new ResponseAllEvent($this->resourceClass, $this->filterRequest, $this->getResource(), $this->getAcceptHeader());
        $this->runLifeCycleEvent('onPreCreateResponse', $event);
        if (!$event->getResponse()) {
            $event->setResponse($this->getSerializer()->toResponse($this->getResource(), $this->getAcceptHeader()));
        }
        $this->runLifeCycleEvent('onPostCreateResponse', $event);

        return $event->getResponse();

The expression return $event->getResponse() could return the type null which is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding an additional type-check to rule them out.

    }
}