W2w\Lib\Apie\Serializers\SymfonySerializerAdapter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	putData()	0	10	1
A	__construct()	0	4	1
A	postData()	0	9	1
A	toResponse()	0	7	2
A	normalize()	0	4	1

<?php


namespace W2w\Lib\Apie\Serializers;


use Psr\Http\Message\ResponseInterface;
use Symfony\Component\Serializer\Serializer;
use W2w\Lib\Apie\Encodings\FormatRetrieverInterface;
use Zend\Diactoros\Response\TextResponse;

class SymfonySerializerAdapter implements ResourceSerializerInterface
{
    private $serializer;

    private $formatRetriever;

    public function __construct(Serializer $serializer, FormatRetrieverInterface $formatRetriever)
    {
        $this->serializer = $serializer;
        $this->formatRetriever = $formatRetriever;
    }

    /**
     * {@inheritDoc}
     */
    public function putData(object $resource, string $requestBody, string $contentType): object
    {
        $contentFormat = $this->formatRetriever->getFormat($contentType);
        return $this->serializer->deserialize(

The expression return $this->serializer->deserialize($requestBody, get_class($resource), $contentFormat, array('groups' => array('base', 'write', 'put'), 'object_to_populate' => $resource)) could return the type array which is incompatible with the type-hinted return object. Consider adding an additional type-check to rule them out.

            $requestBody,
            get_class($resource),
            $contentFormat,

It seems like $contentFormat can also be of type null; however, parameter $format of Symfony\Component\Serializer\Serializer::deserialize() does only seem to accept string, maybe add an additional type check?

            [
                'groups' => ['base', 'write', 'put'],
                'object_to_populate' => $resource
            ]
        );
    }

    /**
     * {@inheritDoc}
     */
    public function postData(string $resourceClass, string $requestBody, string $contentType): object
    {
        $contentFormat = $this->formatRetriever->getFormat($contentType);
        return $this->serializer->deserialize(

The expression return $this->serializer->deserialize($requestBody, $resourceClass, $contentFormat, array('groups' => array('base', 'write', 'post'))) could return the type array which is incompatible with the type-hinted return object. Consider adding an additional type-check to rule them out.

            $requestBody,
            $resourceClass,
            $contentFormat,

It seems like $contentFormat can also be of type null; however, parameter $format of Symfony\Component\Serializer\Serializer::deserialize() does only seem to accept string, maybe add an additional type check?

            [
                'groups' => ['base', 'write', 'post'],
            ]
        );
    }

    /**
     * {@inheritDoc}
     */
    public function toResponse(?object $resource, string $acceptHeader): ResponseInterface
    {
        $format = $this->formatRetriever->getFormat($acceptHeader ?? 'application/json');
        $contentType = $this->formatRetriever->getContentType($format);

It seems like $format can also be of type null; however, parameter $format of W2w\Lib\Apie\Encodings\FormatRetrieverInterface::getContentType() does only seem to accept string, maybe add an additional type check?

        $response = $this->serializer->serialize($this->resource, $format, ['groups' => ['base', 'read', 'get']]);

It seems like $format can also be of type null; however, parameter $format of Symfony\Component\Serializer\Serializer::serialize() does only seem to accept string, maybe add an additional type check?

The property resource does not exist on W2w\Lib\Apie\Serializers\SymfonySerializerAdapter. Did you maybe forget to declare it?

        return new TextResponse($response, is_null($resource) ? 204 : 200, ['content-type' => $contentType]);
    }

    /**
     * {@inheritDoc}
     */
    public function normalize(?object $resource, string $acceptHeader)
    {
        $format = $this->formatRetriever->getFormat($acceptHeader ?? 'application/json');
        return $this->serializer->normalize($this->resource, $format, ['groups' => ['base', 'read', 'get']]);

The property resource does not exist on W2w\Lib\Apie\Serializers\SymfonySerializerAdapter. Did you maybe forget to declare it?

    }
}